[TC 11.57rc5] Shift+F4: Tree button not disabled when pasting or selecting from MRU list a test that contains an error

Bug reports will be moved here when the described bug has been fixed

Moderators: Stefan2, Hacker, petermad

Post Reply
User avatar
white
Power Member
Power Member
Posts: 6940
Joined: 2003-11-19, 08:16 UTC
Location: Netherlands

[TC 11.57rc5] Shift+F4: Tree button not disabled when pasting or selecting from MRU list a test that contains an error

Post by *white »

If you press Shift+F4 and type "<", the Tree button is removed.
If you press Shift+F4 and type some text and then insert "<" at the beginning (by typing or pasting a text that starts with "<"), the Tree button is removed.
This is not the case when the new text results in an error.
Expected: Tree button is always removed when the resulting text starts with "<".
  • Press Shift+F4
  • Enter:

    Code: Select all

    File [0].txt
  • Press Home
  • Type "<"
The Tree button is not disabled.
Expected: Tree button is disabled.
  • Copy for example the following text to clipboard:

    Code: Select all

    <[C
  • Press Shift+F4
  • Paste the value from clipboard
The Tree button is not disabled.
Expected: Tree button is disabled.
  • Select a jpg file with EXIF info
  • Press Shift+F4
  • Enter:

    Code: Select all

    <[T4][YMD]
  • Click OK
  • Select a file without EXIF info
  • Press Shift+F4
  • Press Down key / Select the previous entry from MRU list / Paste the text "<[T4][YMD]"
The Tree button is not disabled.
Expected: Tree button is disabled.
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 53138
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Re: [TC 11.57rc5] Shift+F4: Tree button not disabled when pasting or selecting from MRU list a test that contains an err

Post by *ghisler(Author) »

The reason why the tree button is removed is to have more screen space for name examples. Therefore the button only gets removed when Total Commander shows a name or range of names in the example field, even if that name is empty (typing just <). It doesn't get removed when there is an error.

I'm considering to keep the tree button when the user just types <, so when he makes a typo, he can still use the tree button then. Or show the tree button again when the user removes the < character - in this case, I could also hide it when there is an error with the < character.
Author of Total Commander
https://www.ghisler.com
User avatar
white
Power Member
Power Member
Posts: 6940
Joined: 2003-11-19, 08:16 UTC
Location: Netherlands

Re: [TC 11.57rc5] Shift+F4: Tree button not disabled when pasting or selecting from MRU list a test that contains an err

Post by *white »

It appears I have mentioned this before:
white wrote: 2023-06-30, 11:09 UTC In the current design there are some problems:
  • If a placeholder is added and there is an error, the Tree button is not hidden. For example, first use the Tree button and then the placeholder button.
  • If placeholders are removed, the Tree button doesn't reappear.
Perhaps the new file and new folder dialogs can be improved in the next version (after version 11.57). Perhaps when the user types <, instead of removing the Tree button to make room for the preview, the window can dynamically be made larger to make room for the preview.
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 53138
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Re: [TC 11.57rc5] Shift+F4: Tree button not disabled when pasting or selecting from MRU list a test that contains an err

Post by *ghisler(Author) »

For now I will just hide the tree button when the name starts with < and show it when the < is gone.
Author of Total Commander
https://www.ghisler.com
User avatar
white
Power Member
Power Member
Posts: 6940
Joined: 2003-11-19, 08:16 UTC
Location: Netherlands

Re: [TC 11.57rc5] Shift+F4: Tree button not disabled when pasting or selecting from MRU list a test that contains an err

Post by *white »

ghisler(Author) wrote: 2026-04-24, 06:53 UTC For now I will just hide the tree button when the name starts with < and show it when the < is gone.
Seems you did more than that:
Changelog:
22.04.26 Fixed: New file/New folder dialog: Remove the "Tree" button when the first character is a '<', and re-add it when not (32/64)
Tested using TC 11.57rc5a.
Tested OK for the New file dialog.
The New folder dialog did not have a Tree button and now enables the Define button to define a search?
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 53138
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Re: [TC 11.57rc5] Shift+F4: Tree button not disabled when pasting or selecting from MRU list a test that contains an err

Post by *ghisler(Author) »

Oh, you're right! I didn't consider that the tree button only exists in the new file dialog, not in the new folder dialog.
Author of Total Commander
https://www.ghisler.com
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 53138
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Re: [TC 11.57rc5] Shift+F4: Tree button not disabled when pasting or selecting from MRU list a test that contains an err

Post by *ghisler(Author) »

This should be fixed in Total Commander 11.57 RC6, please test it!
Author of Total Commander
https://www.ghisler.com
User avatar
white
Power Member
Power Member
Posts: 6940
Joined: 2003-11-19, 08:16 UTC
Location: Netherlands

Re: [TC 11.57rc5] Shift+F4: Tree button not disabled when pasting or selecting from MRU list a test that contains an err

Post by *white »

HISTORY.TXT wrote: 22.04.26 Fixed: New file dialog: Remove the "Tree" button when the first character is an opening square bracket '<', and re-add it when not (32/64)
Tested OK using TC 11.57rc6 32-bit and 64-bit.
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 53138
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Re: [TC 11.57rc5] Shift+F4: Tree button not disabled when pasting or selecting from MRU list a test that contains an err

Post by *ghisler(Author) »

Thanks!

Moderator message from: ghisler(Author) » 2026-04-29, 16:57 UTC

Moved to fixed bugs
Author of Total Commander
https://www.ghisler.com
Post Reply