SFTP Plugin Updates

[klodoma]

Hi

I use this plugin but it needs tuning. I took the source code and improved some aspects like:
- fix login glitches
- allow usage of ssh config (so just provide a sshconfig as "server") and it works

How can we contribute? I have pushed the source code to a Github Repo, maybe we can create a shared space for the plugins?

https://www.ghisler.com/plugins.htm
SFTP - 3.05 - 2023/03/24

Let me know.

[AntonyD]

Did you firstly checked this next repo?
https://github.com/wesmar/sftp/releases
discussed here: viewtopic.php?t=87152&start=45

[klodoma]

Did you firstly checked this next repo?
https://github.com/wesmar/sftp/releases
discussed here: viewtopic.php?t=87152&start=45

Great... no I didn't I'll check it. thx

[klodoma]

Did you firstly checked this next repo?
https://github.com/wesmar/sftp/releases
discussed here: viewtopic.php?t=87152&start=45

Thanks for this, I didn't know it existed. I downloaded the source code from the plugins page.
I'll fork it and check my changes accordingly. If all good I'll create a PR.

[AntonyD]

Good luck)))

P.S.
But I was thinking that all possible changes already were made in this variant of SFTP plug.
Interesting -what else you can add in this project....

[ghisler(Author)]

Do you think that any of these changes should make it back into my own version? If yes, which and why?

[klodoma]

I will check both and follow up here.
I want a simple feature: use ssh config directly

[ghisler(Author)]

What do you mean with that? Import a configuration from e.g. Putty?

[larry99]

I also do not like to have the same config at different places. This is why I would not like an import solution. Then you still have two entries for the same connection which were in sync at one moment in time (when imported) but can differ again from then on. Better to directly use the config of Putty and/or openssh (usually installed on recent Windows versions).
With very few exceptions every ssh connection can also be used for sftp, so why not use the existing config instead of maintaining a separate one?

[klodoma]

I'll be out the next weeks so I cannot work on this for a while, but I can tell you my "pain point" and what I already changed to this plugin, but its not quite finished yet.

I manage my SSH Connections in `~/.ssh/config`. For example: the command `ssh myserver` works.

Code: Select all

Host myserver
	HostName myserver.mydomain.com
        Port 5062
	IdentityFile "~/.ssh/myuser.key"
	User myuser

Now, I want to add ONLY this config in sftp plugin like here. I don't want todo any key conversion, any config import, nothing. Just a single entry. The `~/.ssh/config` is the ONLY place where I manage my SSH connections.

Image: https://www.pasteboard.co/E1s0KnERB1-v.png

In the "original" SFTP plugin code, I managed to do this, its just not finished yet.

I tried to inject this into `https://github.com/wesmar/sftp` this repository too, but here I noticed it doesn't work with`ed25519` keys only rsa(which is not acceptable)

All the best, we hear again soon.

[JOUBE]

I also do not like to have the same config at different places. This is why I would not like an import solution. Then you still have two entries for the same connection which were in sync at one moment in time (when imported) but can differ again from then on. Better to directly use the config of Putty and/or openssh (usually installed on recent Windows versions).
With very few exceptions every ssh connection can also be used for sftp, so why not use the existing config instead of maintaining a separate one?

For me, it is exactly the opposite. That is why the current behavior of the SFTP plugin is perfect. Because everything is contained within the plugin's configuration, it is completely portable; it can be used independently on any system - whether Windows or Linux (via wine) - simply by copying it, or even just by running it as a portable application. Therefore, whatever is done in this regard: please entirely(!) optional. In then moment it is posible to use all SFTP-Plugin connection totaly independent form the system on what it is running (e.g. at the customer side) whitout disturbing it. Portability and independency are the outstanding features of the plugin.

[larry99]

Good point.
But I think at least for the openssh config file there could be a solution that fits both: Just have a config option of the connection file. You could set this option to something like %COMMANDER_PATH%\plugins\sftp\config if you want it portable or to %USERPROFILE\.ssh\config if you want it the same as the system ssh config. Support for the openssh config format would make this possible and flexible. PuTTY would be out of the game then though.

[Dalai]

I second JOUBE's take on this.

[Dalai]

Support for the openssh config format would make this possible and flexible. PuTTY would be out of the game then though.

Well, the way you described it doesn't sound like it's backwards compatible to existing SFTP plugin settings, is it? Support for the OpenSSH config file format is OK as long as the existing INI file is still supported and left untouched.

[larry99]

Well, since the code to read the sftp.ini file is already there it could/would be used if no (openssh)config-path parameter is set.