[BUG] Custom fields order in Overwrite dialog

Bug reports will be moved here when the described bug has been fixed

Moderators: white, Hacker, petermad, Stefan2

Post Reply
User avatar
roentgen
Power Member
Power Member
Posts: 757
Joined: 2005-12-03, 19:58 UTC

[BUG] Custom fields order in Overwrite dialog

Post by *roentgen »

In overwrite dialog the defined custom fields by file type don't seem to react to the order that they are arranged.

For example: I have 2 custom fields: a. (the first in the list) for Images (a saved search) and b. (the last in the list) for *.*, but everytime the settings for *.* custom field are taken into account.
TC for Linux please!
User avatar
Lefteous
Power Member
Power Member
Posts: 9535
Joined: 2003-02-09, 01:18 UTC
Location: Germany
Contact:

Post by *Lefteous »

I just want to state I have the same problem for a long time and also for custom tooltips. I always thought it was my fault and didn't report it.
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 48021
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Post by *ghisler(Author) »

I cannot confirm that. My [OverwriteCustomField] section looks like this:

Code: Select all

0exts=*.jpg *.gif *.png
0fields=[=imgsize.Width"x"][=imgsize.Height" Pixel"]\n[=tc.comment]
1exts=*.*
1fields=[=tc.comment]
In the overwrite dialog, TC shows both the image dimensions and the comment (both from field 0). Now I click on "+" and rearrange the two, so the *.* item comes first. The extra fields immediately change to show only the comment.

How does your [OverwriteCustomField] section looks like?
Author of Total Commander
https://www.ghisler.com
User avatar
Lefteous
Power Member
Power Member
Posts: 9535
Joined: 2003-02-09, 01:18 UTC
Location: Germany
Contact:

Post by *Lefteous »

How does your [OverwriteCustomField] section looks like?
I have created a minimal configuration which doesn't work here:

Code: Select all

[OverwriteCustomField]
0exts=>Einstellungsdateien
0fields=DOS-Name: [=tc.dosname]
1exts=*.*
1fields=Attr: [=tc.attributestr]

Code: Select all

Einstellungsdateien_SearchFor=*.ini
Einstellungsdateien_SearchIn=
Einstellungsdateien_SearchText=
Einstellungsdateien_SearchFlags=0|000002000020||||||||22220|0000|
TC always shows the field values for *.* instead of the field values for >Einstellungsdateien (for *.ini files of course) although it's the first in the list.
When I delete the *.* definition TC shows the field values for >Einstellungsdateien properly.
User avatar
petermad
Power Member
Power Member
Posts: 14739
Joined: 2003-02-05, 20:24 UTC
Location: Denmark
Contact:

Post by *petermad »

If I use 2 searches:

Code: Select all

[OverwriteCustomField]
0exts=>Billeder (web)
0fields=[=imgsize.Width] x [=imgsize.Height] pixels
1exts=>Kommentar
1fields=[=tc.comment]

Code: Select all

[Searches]
Billeder (web)_SearchFor=*.gif *.jpg *.jpeg *.jpe *.png
Billeder (web)_SearchIn=
Billeder (web)_SearchText=
Billeder (web)_SearchFlags=0|000002000020|||||||||0000| 
Kommentar_SearchFor=
Kommentar_SearchIn=
Kommentar_SearchText=
Kommentar_SearchFlags=0|000002000020|||||||||0000|
then, if I try to owerwrite a .jpg file that does not have a comment, I get the width x height in the overwrite dialog, but if I try to overwrite a .jpg file without a comment with a file that do have a comment I get the comment for the source file and the width x height for the target file.

If I change:

Code: Select all

1exts=>Kommentar
to

Code: Select all

1exts=*.*
then, if I try overwriting the same file I always only get the comment (if any), but never get the width x height no matter whether >Billeder (web) or *.* is placed first in the OverwriteCustomField section - here I would expect to have width x height shown if no comment is set.


E.g. always use the last found filter that has a value, not just the last filter that applies.
License #524 (1994)
Danish Total Commander Translator
TC 11.03 32+64bit on Win XP 32bit & Win 7, 8.1 & 10 (22H2) 64bit, 'Everything' 1.5.0.1371a
TC 3.50b4 on Android 6 & 13
Try: TC Extended Menus | TC Languagebar | TC Dark Help | PHSM-Calendar
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 48021
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Post by *ghisler(Author) »

Thanks for all the details, I will investigate.
Author of Total Commander
https://www.ghisler.com
User avatar
petermad
Power Member
Power Member
Posts: 14739
Joined: 2003-02-05, 20:24 UTC
Location: Denmark
Contact:

Post by *petermad »

Not fixed in TC7pb3...
License #524 (1994)
Danish Total Commander Translator
TC 11.03 32+64bit on Win XP 32bit & Win 7, 8.1 & 10 (22H2) 64bit, 'Everything' 1.5.0.1371a
TC 3.50b4 on Android 6 & 13
Try: TC Extended Menus | TC Languagebar | TC Dark Help | PHSM-Calendar
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 48021
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Post by *ghisler(Author) »

I did change that! What settings did you use?
Author of Total Commander
https://www.ghisler.com
User avatar
petermad
Power Member
Power Member
Posts: 14739
Joined: 2003-02-05, 20:24 UTC
Location: Denmark
Contact:

Post by *petermad »

What settings did you use
As described in http://ghisler.ch/board/viewtopic.php?p=107647#107647
License #524 (1994)
Danish Total Commander Translator
TC 11.03 32+64bit on Win XP 32bit & Win 7, 8.1 & 10 (22H2) 64bit, 'Everything' 1.5.0.1371a
TC 3.50b4 on Android 6 & 13
Try: TC Extended Menus | TC Languagebar | TC Dark Help | PHSM-Calendar
User avatar
roentgen
Power Member
Power Member
Posts: 757
Joined: 2005-12-03, 19:58 UTC

Post by *roentgen »

It works for me.
TC for Linux please!
User avatar
petermad
Power Member
Power Member
Posts: 14739
Joined: 2003-02-05, 20:24 UTC
Location: Denmark
Contact:

Post by *petermad »

2ghisler(Author)
2roentgen

Sorry :oops: - I must have made an error while setting up the test conditions - now trying again, everything works as expected :-)
License #524 (1994)
Danish Total Commander Translator
TC 11.03 32+64bit on Win XP 32bit & Win 7, 8.1 & 10 (22H2) 64bit, 'Everything' 1.5.0.1371a
TC 3.50b4 on Android 6 & 13
Try: TC Extended Menus | TC Languagebar | TC Dark Help | PHSM-Calendar
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 48021
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Post by *ghisler(Author) »

Nice to hear that it does work now. :)
Author of Total Commander
https://www.ghisler.com
User avatar
Lefteous
Power Member
Power Member
Posts: 9535
Joined: 2003-02-09, 01:18 UTC
Location: Germany
Contact:

Post by *Lefteous »

I just want to complement that it also works fine for tooltips in beta 3.
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 48021
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Post by *ghisler(Author) »

Thanks!
Author of Total Commander
https://www.ghisler.com
Post Reply