Menu spacing

The behaviour described in the bug report is either by design, or would be far too complex/time-consuming to be changed

Moderators: white, Hacker, petermad, Stefan2

User avatar
petermad
Power Member
Power Member
Posts: 14809
Joined: 2003-02-05, 20:24 UTC
Location: Denmark
Contact:

Post by *petermad »

I can now confirm the extra menu spacing - if I have Cleartype enabled AND I have "Windows XP theme background (menu+all bars)" enabled.
License #524 (1994)
Danish Total Commander Translator
TC 11.03 32+64bit on Win XP 32bit & Win 7, 8.1 & 10 (22H2) 64bit, 'Everything' 1.5.0.1371a
TC 3.50 on Android 6 & 13
Try: TC Extended Menus | TC Languagebar | TC Dark Help | PHSM-Calendar
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 48088
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Post by *ghisler(Author) »

As I wrote, it's not a bug - before that fix, there were even some overlaps between menu items in some languages! TC just reports the exact width of the string to Windows, and Windows adds some extra space between the menus.
Author of Total Commander
https://www.ghisler.com
User avatar
petermad
Power Member
Power Member
Posts: 14809
Joined: 2003-02-05, 20:24 UTC
Location: Denmark
Contact:

Post by *petermad »

TC just reports the exact width of the string to Windows, and Windows adds some extra space between the menus.
But apparently only under certain conditions - why so?
License #524 (1994)
Danish Total Commander Translator
TC 11.03 32+64bit on Win XP 32bit & Win 7, 8.1 & 10 (22H2) 64bit, 'Everything' 1.5.0.1371a
TC 3.50 on Android 6 & 13
Try: TC Extended Menus | TC Languagebar | TC Dark Help | PHSM-Calendar
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 48088
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Post by *ghisler(Author) »

No, it does it always - the problem was just that TC reported a wrong string width in older versions, by measuring the width of the ANSI text instead of Unicode text...
Author of Total Commander
https://www.ghisler.com
User avatar
petermad
Power Member
Power Member
Posts: 14809
Joined: 2003-02-05, 20:24 UTC
Location: Denmark
Contact:

Post by *petermad »

No, it does it always
Apparently TC only expands the width for ANSI text menus IF Cleartype AND "Windows XP theme background (menu+all bars)" are enabled. That's what I meant by "certain conditions".
License #524 (1994)
Danish Total Commander Translator
TC 11.03 32+64bit on Win XP 32bit & Win 7, 8.1 & 10 (22H2) 64bit, 'Everything' 1.5.0.1371a
TC 3.50 on Android 6 & 13
Try: TC Extended Menus | TC Languagebar | TC Dark Help | PHSM-Calendar
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 48088
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Post by *ghisler(Author) »

This is true only when using the same language as the system language - then TC uses ANSI functions when theming is off. The bugfix was when using a language from a different codepage.
Author of Total Commander
https://www.ghisler.com
User avatar
petermad
Power Member
Power Member
Posts: 14809
Joined: 2003-02-05, 20:24 UTC
Location: Denmark
Contact:

Post by *petermad »

Hmm - here: http://madsenworld.dk/tcmd/cleartype_menu3.png I am using Russian with Danish system language - and I don't see the extra spacing ?
License #524 (1994)
Danish Total Commander Translator
TC 11.03 32+64bit on Win XP 32bit & Win 7, 8.1 & 10 (22H2) 64bit, 'Everything' 1.5.0.1371a
TC 3.50 on Android 6 & 13
Try: TC Extended Menus | TC Languagebar | TC Dark Help | PHSM-Calendar
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 48088
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Post by *ghisler(Author) »

You need to compare RC1 with older versions to see the extra spacing.
Author of Total Commander
https://www.ghisler.com
User avatar
Herr Mann
Power Member
Power Member
Posts: 574
Joined: 2004-05-30, 17:11 UTC
Location: Niedersachsen, Deutschland

Post by *Herr Mann »

OFF-Tropic,
but I look at your screenhots and I am confused.
There are not vertical Line between the Menu and the Buttonbar.
How does it work? How is you TC set?
Whatever I configure, this look does not work. :? :?
User avatar
petermad
Power Member
Power Member
Posts: 14809
Joined: 2003-02-05, 20:24 UTC
Location: Denmark
Contact:

Post by *petermad »

2Herr Mann
There are not vertical Line between the Menu and the Buttonbar.
How does it work? How is you TC set?
I guess you mean horizontal lines - right.? Here is my setup:

Code: Select all

[Layout]
InterfaceFlat=0
XPthemeBg=0

Code: Select all

[Buttonbar]
FlatIcons=0
XPstyle=1
Windows XP theme:

Code: Select all

[Theme]

; My Computer
[CLSID\{20D04FE0-3AEA-1069-A2D8-08002B30309D}\DefaultIcon]
DefaultValue=C:\WINDOWS\Explorer.exe,0

; My Documents
[CLSID\{450D8FBA-AD25-11D0-98A8-0800361B1103}\DefaultIcon]
DefaultValue=C:\WINDOWS\SYSTEM32\mydocs.dll,0

; My Network Places
[CLSID\{208D2C60-3AEA-1069-A2D7-08002B30309D}\DefaultIcon]
DefaultValue=C:\WINDOWS\system32\SHELL32.dll,17

; Recycle Bin
[CLSID\{645FF040-5081-101B-9F08-00AA002F954E}\DefaultIcon]
full=C:\WINDOWS\System32\shell32.dll,32
empty=C:\WINDOWS\System32\shell32.dll,31

[Control Panel\Colors]
ActiveTitle=192 192 192
Background=0 0 0
Hilight=0 0 128
HilightText=255 255 255
TitleText=0 0 0
Window=255 255 255
WindowText=0 0 0
Scrollbar=239 240 245
InactiveTitle=239 239 239
Menu=224 226 235
WindowFrame=0 0 0
MenuText=0 0 0
ActiveBorder=224 226 235
InactiveBorder=224 226 235
AppWorkspace=131 138 175
ButtonFace=224 226 235
ButtonShadow=131 138 175
GrayText=131 138 175
ButtonText=0 0 0
InactiveTitleText=192 192 192
ButtonHilight=239 240 245
ButtonDkShadow=113 111 100
ButtonLight=224 226 235
InfoText=0 0 0
InfoWindow=255 255 225
GradientActiveTitle=200 200 200
GradientInactiveTitle=247 247 247
ButtonAlternateFace=181 181 181
HotTrackingColor=100 139 203
MenuHilight=187 183 199
MenuBar=224 226 235

[Metrics]
IconMetrics=76 0 0 0 105 0 0 0 75 0 0 0 1 0 0 0 245 255 255 255 0 0 0 0 0 0 0 0 0 0 0 0 144 1 0 0 0 0 0 1 0 0 0 0 65 114 105 97 108 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0  
NonclientMetrics=84 1 0 0 1 0 0 0 17 0 0 0 17 0 0 0 18 0 0 0 22 0 0 0 243 255 255 255 0 0 0 0 0 0 0 0 0 0 0 0 188 2 0 0 0 0 0 1 0 0 0 0 65 114 105 97 108 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 18 0 0 0 18 0 0 0 243 255 255 255 0 0 0 0 0 0 0 0 0 0 0 0 188 2 0 0 0 0 0 1 0 0 0 0 65 114 105 97 108 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 20 0 0 0 20 0 0 0 243 255 255 255 0 0 0 0 0 0 0 0 0 0 0 0 144 1 0 0 0 0 0 1 0 0 0 0 65 114 105 97 108 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 243 255 255 255 0 0 0 0 0 0 0 0 0 0 0 0 144 1 0 0 0 0 0 1 0 0 0 0 65 114 105 97 108 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 243 255 255 255 0 0 0 0 0 0 0 0 0 0 0 0 144 1 0 0 0 0 0 1 0 0 0 0 65 114 105 97 108 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0  

[VisualStyles]
Path=%WinDir%Resources\themes\Luna\Luna.msstyles
ColorStyle=Metallic
Size=NormalSize
But is is basically the [Buttonbar] FlatIcons=0 that does it
License #524 (1994)
Danish Total Commander Translator
TC 11.03 32+64bit on Win XP 32bit & Win 7, 8.1 & 10 (22H2) 64bit, 'Everything' 1.5.0.1371a
TC 3.50 on Android 6 & 13
Try: TC Extended Menus | TC Languagebar | TC Dark Help | PHSM-Calendar
User avatar
Herr Mann
Power Member
Power Member
Posts: 574
Joined: 2004-05-30, 17:11 UTC
Location: Niedersachsen, Deutschland

Post by *Herr Mann »

petermad wrote:2Herr Mann
There are not vertical Line between the Menu and the Buttonbar.
How does it work? How is you TC set?
I guess you mean horizontal lines - right.? Here is my setup:
Damn, of course!

Code: Select all

vertical from top to button, horizontal left to right 
:oops: :oops:
Post Reply