[8.0ß17a] Add to DirHotlist: Submenu selected, not indicated

Bug reports will be moved here when the described bug has been fixed

Moderators: white, Hacker, petermad, Stefan2

Post Reply
User avatar
Flint
Power Member
Power Member
Posts: 3487
Joined: 2003-10-27, 09:25 UTC
Location: Antalya, Turkey
Contact:

[8.0ß17a] Add to DirHotlist: Submenu selected, not indicated

Post by *Flint »

1. Make sure there is at least one submenu in Directory Hotlist present.
2. Open any dir not present in DirHotlist, press Ctrl+D, select "Add current dir".
3. In the dialog click the checkbox "Add to submenu". When context menu appears, do not select any item but simply press Esc or click anywhere outside the menu (except for the checkbox "Add to submenu").
4. The context menu is closed, no submenu is selected, the checkbox title still says "Add to submenu" without the submenu name. The checkbox itself remains checked however!
5. Click OK -> the new directory will be added to the submenu.

I think, if the context menu is closed without selecting an item, the checkbox should clear automatically, and after clicking OK the item should be added to the root of DirHotlist.
Flint's Homepage: Full TC Russification Package, VirtualDisk, NTFS Links, NoClose Replacer, and other stuff!
 
Using TC 10.52 / Win10 x64
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 48093
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Post by *ghisler(Author) »

Yes, TC is adding the file to the first submenu if the option is checked, but no submenu is chosen. I can change it if you think that this is confusing.
Author of Total Commander
https://www.ghisler.com
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 48093
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Post by *ghisler(Author) »

I have changed this now in beta 18, please test it!
Author of Total Commander
https://www.ghisler.com
umbra
Power Member
Power Member
Posts: 871
Joined: 2012-01-14, 20:41 UTC

Post by *umbra »

The checkbox stays checked, even if no submenu is selected.
Windows 7 Pro x64, Windows 10 Pro x64
User avatar
Flint
Power Member
Power Member
Posts: 3487
Joined: 2003-10-27, 09:25 UTC
Location: Antalya, Turkey
Contact:

Post by *Flint »

ghisler(Author) wrote:I have changed this now in beta 18, please test it!
I confirm that if I don't select a submenu, the new item is created in the root, thanks. However, the checkbox remained checked, and it's confusing a bit.

(Actually, when I installed beta 18 I tried this, but when I saw that the checkbox remained checked I thought that the fix was postponed (especially since it was not mentioned in history), so I just pressed Cancel.)
Flint's Homepage: Full TC Russification Package, VirtualDisk, NTFS Links, NoClose Replacer, and other stuff!
 
Using TC 10.52 / Win10 x64
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 48093
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Post by *ghisler(Author) »

Unfortunately there is no notification when the menu is closed without choosing anything, so I have leave it checked.
Author of Total Commander
https://www.ghisler.com
User avatar
Flint
Power Member
Power Member
Posts: 3487
Joined: 2003-10-27, 09:25 UTC
Location: Antalya, Turkey
Contact:

Post by *Flint »

ghisler(Author)
Hm… How do you show the menu? Do you not use TrackPopupMenu? It allows to distinguish these situations:
MSDN wrote:Return value

If you specify TPM_RETURNCMD in the uFlags parameter, the return value is the menu-item identifier of the item that the user selected. If the user cancels the menu without making a selection, or if an error occurs, the return value is zero.
Flint's Homepage: Full TC Russification Package, VirtualDisk, NTFS Links, NoClose Replacer, and other stuff!
 
Using TC 10.52 / Win10 x64
User avatar
petermad
Power Member
Power Member
Posts: 14812
Joined: 2003-02-05, 20:24 UTC
Location: Denmark
Contact:

Post by *petermad »

Hasn't this thread ended up in the wrong forum section (TC7.56a confirmed bugs) ?
License #524 (1994)
Danish Total Commander Translator
TC 11.03 32+64bit on Win XP 32bit & Win 7, 8.1 & 10 (22H2) 64bit, 'Everything' 1.5.0.1371a
TC 3.50 on Android 6 & 13
Try: TC Extended Menus | TC Languagebar | TC Dark Help | PHSM-Calendar
User avatar
petermad
Power Member
Power Member
Posts: 14812
Joined: 2003-02-05, 20:24 UTC
Location: Denmark
Contact:

Post by *petermad »

* Bump - this thread still doesn't belong in this section.
License #524 (1994)
Danish Total Commander Translator
TC 11.03 32+64bit on Win XP 32bit & Win 7, 8.1 & 10 (22H2) 64bit, 'Everything' 1.5.0.1371a
TC 3.50 on Android 6 & 13
Try: TC Extended Menus | TC Languagebar | TC Dark Help | PHSM-Calendar
User avatar
Hacker
Moderator
Moderator
Posts: 13068
Joined: 2003-02-06, 14:56 UTC
Location: Bratislava, Slovakia

Post by *Hacker »

[mod]Moved to Bugs which should be fixed now for lack of better ideas.

Hacker (Moderator)[/mod]
Mal angenommen, du drückst Strg+F, wählst die FTP-Verbindung (mit gespeichertem Passwort), klickst aber nicht auf Verbinden, sondern fällst tot um.
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 48093
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Post by *ghisler(Author) »

The original bug has been fixed, so I'm moving this to fixed bugs. The checkbox behaviour will not be changed.
Author of Total Commander
https://www.ghisler.com
Post Reply