[TC 11.00b3] Problems with some "Commands with parameters" when used for keyboard remapping

[petermad]

I have testet all the commands in the "Choose Command" dialog in the section "Commands with parameters" used with Keyboard remapping

These command simply doesn't work:
OPENTABS with the L or R modifier
APPENDTABS with the L or R modifier
SELECTFILES with the D, B, U, L, R, T or S modifier
SAVESELECTION with the A or W modifier
SAVEDETAILS with the A, W or H modifier
ZIPFROMLIST with the 0 (zero) modifier


ZIPFROMLIST does not work with the -m, -o, -c0-3 and -0-9 parameters:

Code: Select all

C+W=ZIPFROMLIST
C+W_params=-o "%|COMMANDER_PATH|\test\test.zip" %UF

but this works:

Code: Select all

C+W=ZIPFROMLIST
C+W_params="%|COMMANDER_PATH|\test\test.zip" %UF

FTPOPEN does not work if the name of the FTP-session starts with some digits followed by a space, unless the name is double double-quoted.

This does not work:

Code: Select all

C+W=FTPOPEN
C+W_params="00 madsenworld"

I get the error message: Function not implemented! 12345678

This works:

Code: Select all

C+W=FTPOPEN
C+W_params=""00 madsenworld""

I seems to have to do with digits in the start, because if i use letters in the start it works even without quotes:

Code: Select all

C+W=FTPOPEN
C+W_params=aa madsenworld

Also if there is no space after the digits in the name it works:

Code: Select all

C+W=FTPOPEN
C+W_params=00madsenworld

[ghisler(Author)]

These command simply doesn't work:
OPENTABS with the L or R modifier
APPENDTABS with the L or R modifier
SELECTFILES with the D, B, U, L, R, T or S modifier
SAVESELECTION with the A or W modifier
SAVEDETAILS with the A, W or H modifier

You cannot choose these because they are not in the command choose dialog. I don't currently see a solution, sorry, there are just too many possible combinations.

ZIPFROMLIST does not work with the -m, -o, -c0-3 and -0-9 parameters:

Sorry, this is currently impossible because ZIPFROMLIST expects these parameters in the command field, and you can't set that in the hotkeys. See my other reply.

I will try to find out what's the problem with FTPOPEN.

[sa16]

You can not complicate the dialogue, but in this case (in the old fashioned way) use the user command (em_XYZ).

[petermad]

You cannot choose these because they are not in the command choose dialog

Maybe you could ad some of them to the choose dialog:
OPENTABSL
OPENTABSR
APPENDTABSL
APPENDTABSR
SAVESELECTIONA
SAVESELECTIONW
SAVEDETAILSA
SAVEDETAILSW
SAVEDETAILSH
LOADLIST0

That is not so many and you have already done similar to the SAVETABS commands.

I can see that SELECTFILES is problematic since all the parameters can more or less be combined:

Spoiler

D
B
U
L
R
T
S

DL
DR
DT
BL
BR
BT

DUL
DUR
DUT
BUL
BUR
BUT

DLS
DRS
DTS
BLS
BRS
BTS

DULS
DURS
DUTS
BULS
BURS
BUTS

DS
BS
US
LS
RS
TS

DU
BU
LU
RU
TU
SU

43 combinations, and maybe even more...

[ghisler(Author)]

I found a better solution. When the user chooses a command like OPENTABS, they can enter a parameter like this:
L filename
TC will detect the space and append the L to OPENTABS. It then checks whether OPENTABSL is a valid command too, and if yes, changes the command to OPENTABSL.

[Fla$her]

Smart move!

[petermad]

Clever

[petermad]

I found a better solution. When the user chooses a command like OPENTABS, they can enter a parameter like this:
L filename

What will happen if the filename i for example: L myfile.txt ?

Wouldn't it be better with /L instead of L or /BUS instead of BUS - to maintain that it currently is not required to quote paths with spaces for those commands.

[ghisler(Author)]

What will happen if the filename i for example: L myfile.txt ?

This is just in the main settings dialog. If you want to enter it there, enter "L myfile.txt".

[sa16]

[TC 11.00b4]
It works.
NUM1=SELECTFILEST
NUM1_params=History.txt

It stopped working.
NUM5=cm_Select
NUM5_params=5

[petermad]

19.05.23 Added: To set a hotkey for a command like SELECTFILEST, choose command SELECTFILES and then set the parameter to T <wildcards> and apply it (32/64)

19.05.23 Fixed: The following internal commands didn't work with hotkeys: SAVEDETAILS with modifiers A, W and H, SELECTFILES with D, B, U, L, R, T or S, OPENCUSTOMVIEW with L, R, S, T or B (32/64)

19.05.23 Fixed: The following internal commands didn't work with hotkeys: OPENTABSL, OPENTABSR, APPENDTABSL, APPENDTABSR, SAVESELECTIONA, SAVESELECTIONW, SAVESELECTIONA, SAVESELECTIONW, LOADLIST0 (32/64)

Confirmed fixed in TC 1.00b4

[ghisler(Author)]

It stopped working.
NUM5=cm_Select
NUM5_params=5

This probably affects all internal commands which expect a numeric parameter. At least it still works in the button bar, so I will try to use the code from there.

[petermad]

19.05.23 Fixed: Hotkey parameters didn't work in some cases when starting with a number, e.g. FTPOPEN 01 first connection (32/64)

Confirmed fixed in TC 11.00b4

[sa16]

25.05.23 Fixed: Commands with numeric parameters: The parameter was ignored when used in hotkeys, e.g. command=cm_Select, parameter=5 (32/64)

Confirmed fixed in TC 11.00b5.