[TC 11.01rc2] Wrong help page for Print File list with subdirs

The behaviour described in the bug report is either by design, or would be far too complex/time-consuming to be changed

Moderators: white, Hacker, petermad, Stefan2

Post Reply
User avatar
white
Power Member
Power Member
Posts: 4623
Joined: 2003-11-19, 08:16 UTC
Location: Netherlands

[TC 11.01rc2] Wrong help page for Print File list with subdirs

Post by *white »

* Select menu option File/Print/File list with subdirs
* Press F1
The Help page "File operations" is opened instead of "Print".
User avatar
petermad
Power Member
Power Member
Posts: 14809
Joined: 2003-02-05, 20:24 UTC
Location: Denmark
Contact:

Re: [TC 11.01rc2] Wrong help page for Print File list with subdirs

Post by *petermad »

Confirmed - but if you click OK in that dialog and press F1 in the bigger "Print directory" dialog, you do get the "Print dialog" Help.

The smaller pre-dialog where you choose directory levels and can exclude file types, is in a way a file operation dialog, so that is probably why F1 opens the "File operations" Help
License #524 (1994)
Danish Total Commander Translator
TC 11.03 32+64bit on Win XP 32bit & Win 7, 8.1 & 10 (22H2) 64bit, 'Everything' 1.5.0.1371a
TC 3.50 on Android 6 & 13
Try: TC Extended Menus | TC Languagebar | TC Dark Help | PHSM-Calendar
User avatar
white
Power Member
Power Member
Posts: 4623
Joined: 2003-11-19, 08:16 UTC
Location: Netherlands

Re: [TC 11.01rc2] Wrong help page for Print File list with subdirs

Post by *white »

petermad wrote: 2023-08-25, 21:13 UTC Confirmed - but if you click OK in that dialog and press F1 in the bigger "Print directory" dialog, you do get the "Print dialog" Help.

The smaller pre-dialog where you choose directory levels and can exclude file types, is in a way a file operation dialog, so that is probably why F1 opens the "File operations" Help
There is a relevant help page called "Print". That is what I was referring to.
User avatar
petermad
Power Member
Power Member
Posts: 14809
Joined: 2003-02-05, 20:24 UTC
Location: Denmark
Contact:

Re: [TC 11.01rc2] Wrong help page for Print File list with subdirs

Post by *petermad »

There is a relevant help page called "Print". That is what I was referring to.
You are right, that if you in the Help click "3. c. Menus" -> "Files" you get the help item "Menu: Files", and if you click on "Print (submenu)" you get the "Print" help item, that explains the 3 options for the Print submenu, so it is a help for the submenu items.

But I agree, that this help page would be better to show, than the current "File operations" page.
License #524 (1994)
Danish Total Commander Translator
TC 11.03 32+64bit on Win XP 32bit & Win 7, 8.1 & 10 (22H2) 64bit, 'Everything' 1.5.0.1371a
TC 3.50 on Android 6 & 13
Try: TC Extended Menus | TC Languagebar | TC Dark Help | PHSM-Calendar
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 48088
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Re: [TC 11.01rc2] Wrong help page for Print File list with subdirs

Post by *ghisler(Author) »

There is not help page for "File list with subdirs". I could add a link to the "Print" page to the "File operation" page.

But then I need to change the phrase "Opens a submenu with 3 commands:" on that page because it only applies to the menu item...
Author of Total Commander
https://www.ghisler.com
User avatar
white
Power Member
Power Member
Posts: 4623
Joined: 2003-11-19, 08:16 UTC
Location: Netherlands

Re: [TC 11.01rc2] Wrong help page for Print File list with subdirs

Post by *white »

ghisler(Author) wrote: 2023-08-27, 07:42 UTC There is not help page for "File list with subdirs". I could add a link to the "Print" page to the "File operation" page.
Why not link to the Print (submenu) help page? It's explained on that page isn't it?

I assume you are thinking of adding "Printing files" to the "File operation" help page, above or below "Selecting files". Seems like a good idea. Furthermore:
  • I wonder if it would be better to move "Selecting files", etc. downwards.
  • First letter capitalization is inconsistently used and should be fixed.
  • Buttons in TC were renamed to F3 View and F7 NewFolder, change the help accordingly.
  • "Alt+F4 Exit" is not a file operation, should be removed.
  • Displaying all operations in one column is probably clearer.
Here is a mockup screen.
ghisler(Author) wrote: 2023-08-27, 07:42 UTC But then I need to change the phrase "Opens a submenu with 3 commands:" on that page because it only applies to the menu item...
Perhaps simply change it to:
The menu option Files/Print opens a submenu with 3 commands:
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 48088
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Re: [TC 11.01rc2] Wrong help page for Print File list with subdirs

Post by *ghisler(Author) »

Why not link to the Print (submenu) help page? It's explained on that page isn't it?
Because it's a page for the "Print" submenu, not for that dialog box.

Unfortunately I'm out of time, I don't want to delay the release of TC 11.01 for weeks and months for such small issues when the unrar.dll problem needs immediate reaction.
Author of Total Commander
https://www.ghisler.com
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 48088
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Re: [TC 11.01rc2] Wrong help page for Print File list with subdirs

Post by *ghisler(Author) »

I have now added a "Print" link to the "File operations" page to RC3, so I didn't have to change the opened page - which could break third party help files which don't use the same index for that page.
Author of Total Commander
https://www.ghisler.com
User avatar
petermad
Power Member
Power Member
Posts: 14809
Joined: 2003-02-05, 20:24 UTC
Location: Denmark
Contact:

Re: [TC 11.01rc2] Wrong help page for Print File list with subdirs

Post by *petermad »

Confirmed link added to the Help page for "File operations" in TC 11.01rc3 :-)
License #524 (1994)
Danish Total Commander Translator
TC 11.03 32+64bit on Win XP 32bit & Win 7, 8.1 & 10 (22H2) 64bit, 'Everything' 1.5.0.1371a
TC 3.50 on Android 6 & 13
Try: TC Extended Menus | TC Languagebar | TC Dark Help | PHSM-Calendar
User avatar
white
Power Member
Power Member
Posts: 4623
Joined: 2003-11-19, 08:16 UTC
Location: Netherlands

Re: [TC 11.01rc2] Wrong help page for Print File list with subdirs

Post by *white »

ghisler(Author) wrote: 2023-08-29, 10:31 UTC I have now added a "Print" link to the "File operations" page to RC3..
Confirmed that "Print" ("Drucken" for German) is added at the bottom. It looks like crap though. If you didn't want to change the other things I mentioned, why not at least add it to the top, above Selecting files? And perhaps change the link text to "Print files or file list".


Confirmed that the help page Print now starts with:
The menu option Files - Print opens a submenu with 3 commands:
And the German help page Drucken with:
Der Menüpunkt Dateien - Drucken öffnet ein Untermenü mit 3 Befehlen:

ghisler(Author) wrote: 2023-08-29, 10:31 UTC ..so I didn't have to change the opened page - which could break third party help files which don't use the same index for that page.
I'm surprised by this reasoning to not provide context-sensitive help to accommodate third party help files.
User avatar
petermad
Power Member
Power Member
Posts: 14809
Joined: 2003-02-05, 20:24 UTC
Location: Denmark
Contact:

Re: [TC 11.01rc2] Wrong help page for Print File list with subdirs

Post by *petermad »

white wrote: why not at least add it to the top, above Selecting files?
Then it would be peculiar with Print at the top when accessed via for example: F5 -> F1

white wrote:And perhaps change the link text to "Print files or file list"
That could be a good idea.
License #524 (1994)
Danish Total Commander Translator
TC 11.03 32+64bit on Win XP 32bit & Win 7, 8.1 & 10 (22H2) 64bit, 'Everything' 1.5.0.1371a
TC 3.50 on Android 6 & 13
Try: TC Extended Menus | TC Languagebar | TC Dark Help | PHSM-Calendar
User avatar
white
Power Member
Power Member
Posts: 4623
Joined: 2003-11-19, 08:16 UTC
Location: Netherlands

Re: [TC 11.01rc2] Wrong help page for Print File list with subdirs

Post by *white »

petermad wrote: 2023-08-29, 12:52 UTC
white wrote: why not at least add it to the top, above Selecting files?
Then it would be peculiar with Print at the top when accessed via for example: F5 -> F1
Why? F5 is explained somewhere in the middle. That doesn't change.
User avatar
petermad
Power Member
Power Member
Posts: 14809
Joined: 2003-02-05, 20:24 UTC
Location: Denmark
Contact:

Re: [TC 11.01rc2] Wrong help page for Print File list with subdirs

Post by *petermad »

Why? F5 is explained somewhere in the middle. That doesn't change.

Well then at least below "Selecting files" - after all, selecting files is the most basic file operation we have, so I think it should still be first.
License #524 (1994)
Danish Total Commander Translator
TC 11.03 32+64bit on Win XP 32bit & Win 7, 8.1 & 10 (22H2) 64bit, 'Everything' 1.5.0.1371a
TC 3.50 on Android 6 & 13
Try: TC Extended Menus | TC Languagebar | TC Dark Help | PHSM-Calendar
User avatar
white
Power Member
Power Member
Posts: 4623
Joined: 2003-11-19, 08:16 UTC
Location: Netherlands

Re: [TC 11.01rc2] Wrong help page for Print File list with subdirs

Post by *white »

petermad wrote: 2023-08-29, 15:51 UTC Well then at least below "Selecting files" - after all, selecting files is the most basic file operation we have, so I think it should still be first.
That's a possibility. My idea was to sort other file operations (apart from the ones assigned to the function keys) alphabetically.
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 48088
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Re: [TC 11.01rc2] Wrong help page for Print File list with subdirs

Post by *ghisler(Author) »

Sorry, I will not change this any further.

Moderator message

Moved to will not be changed
Author of Total Commander
https://www.ghisler.com
Post Reply