This forum uses cookies. Click X button to hide this message. What is stored? 
Total Commander Forum Index Total Commander
Forum - Public Discussion and Support
 
 FAQFAQ   SearchSearch   MemberlistMemberlist   UsergroupsUsergroups   RegisterRegister 
 ProfileProfile   Log in to check your private messagesLog in to check your private messages   Log inLog in 

[9.10x64b1] Changing location of log file stops logging.

 
Post new topic   Reply to topic    Total Commander Forum Index -> TC Behaviour which will not be changed Printable version
View previous topic :: View next topic  
Author Message
wanderer
Power Member
Power Member


Joined: 28 Mar 2003
Posts: 1230
Location: Sol

PostPosted: Wed Sep 20, 2017 12:22 pm    Post subject: [9.10x64b1] Changing location of log file stops logging. Reply with quote

TC was set to create a log file in %TEMP%\totalcmd.log.

I changed that to %TEMP%\TC\Log\totalcmd.log but i noticed the log file was not created there. I also noticed that entries were not added in the original log file.

I tried manually creating the %TEMP%\TC\Log folder, but no luck.

EDIT: I had to delete the original log file for the new one to be created in the new folder.
_________________

- - - Wanderer - - -


ŻŻŻŻŻŻŻŻŻŻŻŻŻŻŻŻŻ

Latest TC / Win7x64 SP1 / WinXPx32 SP3
Back to top
View user's profile Send private message
ghisler(Author)
Site Admin
Site Admin


Joined: 04 Feb 2003
Posts: 34715
Location: Switzerland

PostPosted: Thu Sep 21, 2017 4:02 am    Post subject: Reply with quote

Maybe the permissions didn't allow to write to the directory/file?
_________________
Author of Total Commander
http://www.ghisler.com
Back to top
View user's profile Send private message Send e-mail Visit poster's website
wanderer
Power Member
Power Member


Joined: 28 Mar 2003
Posts: 1230
Location: Sol

PostPosted: Thu Sep 21, 2017 4:12 am    Post subject: Reply with quote

ghisler(Author) wrote:
Maybe the permissions didn't allow to write to the directory/file?


Nope, i'm full admin in the PC (Win7) with UAC disabled. And also i tried this in my account's %TEMP% folder.
_________________

- - - Wanderer - - -


ŻŻŻŻŻŻŻŻŻŻŻŻŻŻŻŻŻ

Latest TC / Win7x64 SP1 / WinXPx32 SP3
Back to top
View user's profile Send private message
ghisler(Author)
Site Admin
Site Admin


Joined: 04 Feb 2003
Posts: 34715
Location: Switzerland

PostPosted: Thu Sep 21, 2017 4:47 am    Post subject: Reply with quote

Sorry, no other ideas. Since it works now, I will not follow it any further.
_________________
Author of Total Commander
http://www.ghisler.com
Back to top
View user's profile Send private message Send e-mail Visit poster's website
wanderer
Power Member
Power Member


Joined: 28 Mar 2003
Posts: 1230
Location: Sol

PostPosted: Thu Sep 21, 2017 5:24 am    Post subject: Reply with quote

ghisler(Author) wrote:
Since it works now


Does it? The logging stopped (no new file was created and also log entries were not written in the old file) and the only way to resume was to manually delete the old log file.

I remembered now that i also played with the "log file rotation" setting (it was "Never" and i changed it to "Every day"). Let me do some more tests later today, i'll get back to you on that.
_________________

- - - Wanderer - - -


ŻŻŻŻŻŻŻŻŻŻŻŻŻŻŻŻŻ

Latest TC / Win7x64 SP1 / WinXPx32 SP3
Back to top
View user's profile Send private message
wanderer
Power Member
Power Member


Joined: 28 Mar 2003
Posts: 1230
Location: Sol

PostPosted: Thu Sep 21, 2017 11:53 am    Post subject: Reply with quote

OK, i have a more clear idea on what caused the problem.

1. TC is trying to create the log file only on an existing folder. If the folder does not exist, it does not automatically create it. IMO it would be more convenient if it did, or perhaps ask "Log folder does not exist, create it?", if you feel it would be better.

2. If you change the log file location to a folder that does not exist, the first time TC will try to write to the log (in the current TC session), it will try to write at the new location, will not be able to do so and then logging effectively stops. That's why i thought logging was disabled. Even if you create the folder afterwards, the log file is not created. You have to close and reopen TC (after creating the folder) for logging to resume.

In any case, all these are curable if:
1. The user creates the new folder before changing the log file location OR
2. TC just creates the new folder after pressing OK in Settings (no questions asked).

My vote would be on (2).
_________________

- - - Wanderer - - -


ŻŻŻŻŻŻŻŻŻŻŻŻŻŻŻŻŻ

Latest TC / Win7x64 SP1 / WinXPx32 SP3
Back to top
View user's profile Send private message
petermad
Power Member
Power Member


Joined: 05 Feb 2003
Posts: 7323
Location: Valsted, Denmark

PostPosted: Thu Sep 21, 2017 2:38 pm    Post subject: Reply with quote

Quote:
2. TC just creates the new folder after pressing OK in Settings (no questions asked).


I think TC should ask - it is more likely that the user mistyped an existing path, than it is that he actually wants a new path IMHO.
_________________
#524
Danish Total Commander Translator
TC 9.10b1 32+64bit on Win XP 32bit, Win 7, 8.1 & 10 64bit. TC 2.81b8 on Android 6.0

Get Extended Total Commander Menus
Back to top
View user's profile Send private message Send e-mail Visit poster's website
ghisler(Author)
Site Admin
Site Admin


Joined: 04 Feb 2003
Posts: 34715
Location: Switzerland

PostPosted: Wed Sep 27, 2017 10:13 am    Post subject: Reply with quote

I didn't change this in beta 2, I'm unsure how I should handle it. IMHO the user is responsible to use a correct path here.
_________________
Author of Total Commander
http://www.ghisler.com
Back to top
View user's profile Send private message Send e-mail Visit poster's website
wanderer
Power Member
Power Member


Joined: 28 Mar 2003
Posts: 1230
Location: Sol

PostPosted: Wed Sep 27, 2017 11:09 am    Post subject: Reply with quote

ghisler(Author) wrote:
I didn't change this in beta 2, I'm unsure how I should handle it. IMHO the user is responsible to use a correct path here.


Well, i won't argue that. The problem is that if he does enter something wrong (as petermad suggested), he will assume he has a log and when he tries to use it after 6 months, he will just realize he thought he had a log but apparently he didn't because of a typo.

If you do not think it's nice to auto-create the folder, i think that TC at least should warn the user that the log file will not be created because the destination path does not exist.
_________________

- - - Wanderer - - -


ŻŻŻŻŻŻŻŻŻŻŻŻŻŻŻŻŻ

Latest TC / Win7x64 SP1 / WinXPx32 SP3
Back to top
View user's profile Send private message
Flint
Power Member
Power Member


Joined: 27 Oct 2003
Posts: 3130
Location: Moscow, Russia

PostPosted: Wed Sep 27, 2017 11:18 am    Post subject: Reply with quote

ghisler(Author)
Some programs check the path immediately as user is typing it, and if there is something wrong highlight either the editbox, or text inside it with red. Maybe, worth implementing something like that?
_________________
Flint's Homepage: Full TC Russification Package, VirtualDisk, NTFS Links, NoClose Replacer, other stuff!
 
Using TC 9.12 / Win7 x32 & x64 SP1
Back to top
View user's profile Send private message Send e-mail Visit poster's website
wanderer
Power Member
Power Member


Joined: 28 Mar 2003
Posts: 1230
Location: Sol

PostPosted: Wed Sep 27, 2017 12:31 pm    Post subject: Reply with quote

Flint wrote:
ghisler(Author)
Some programs check the path immediately as user is typing it, and if there is something wrong highlight either the editbox, or text inside it with red. Maybe, worth implementing something like that?


Would be a nice solution IMO. If done properly (not intense red, a more pink-ish backcolor perhaps), would give a nice, modern touch to TC and could perhaps be used in other locations too.
_________________

- - - Wanderer - - -


ŻŻŻŻŻŻŻŻŻŻŻŻŻŻŻŻŻ

Latest TC / Win7x64 SP1 / WinXPx32 SP3
Back to top
View user's profile Send private message
Display posts from previous:   
Post new topic   Reply to topic    Total Commander Forum Index -> TC Behaviour which will not be changed All times are GMT - 6 Hours
Page 1 of 1

 
Jump to:  
You cannot post new topics in this forum
You cannot reply to topics in this forum
You cannot edit your posts in this forum
You cannot delete your posts in this forum
You cannot vote in polls in this forum


Impressum: This site is maintained by Ghisler Software GmbH

Using phpBB © 2001-2005 phpBB Group