[11.02rc1] SyncChangeDirMode with 2 added: no warning

[Fla$her]

Maybe I should completely disable SyncChangeDir when going into a nested archive?

No way! The user can always go back through the dir history and continue the synchronous change outside the Temp folder.

[ghisler(Author)]

Currently even if SyncChangeDir is NOT activated it suddenly gets activated when entering a nested archive

I cannot reproduce that. Maybe you enabled it with SyncChangeDirMode set to 5, so it turned itself off temporarily when you entered the archive because the archive didn't exist on the other side? Then it's only suspended and can be turned back on by various actions.

Add a button with command cm_SyncChangeDir, it will show up as pressed as long as the function is active (also while it's suspended).

[petermad]

It happen with SyncChangeDirMode 7, 5, 3 and 1

Add a button with command cm_SyncChangeDir, it will show up as pressed as long as the function is active (also while it's suspended)

That is what I showed in the video, it also shows a menu item without a checkmark next to the "Synchronize Directory Change Left & Right" https://tcmd.madsenworld.dk/SyncChangeDir_nestedarchive.mp4 - please look at it.

To test.

1. Set SyncChangeDirMode to 7, 5, 3 or 1
2. Make sure SyncChangeDir is not activated - no pressed button state (no menu item checkmark)
3. Open tc1102x64_rc2.exe with Ctrl+PgDn
4. Open the nested INSTALL.CAB
5. Notice that the button changes to the pressed state (and there is a checkmark at the menu item).
6. Go updir by double-clicking [..] the other panel goes updir too.

[ghisler(Author)]

Opening archives isn't yet supported with SyncChangeDirMode other than 0 or 2. It will be in RC3.

[petermad]

15.10.23 Fixed: cm_SyncChangeDir: Also handle SyncChangeDirMode values 1 and 4 when entering and leaving archives (32/64)

But the problem with unwanted activation of SyncChangeDir when entering nested archives as described 2 post above is still NOT fixed.


Here is a more elaborate list of how to reproduce it:

1. Start TC with a fresh .ini file only with this parameter added: SyncChangeDirMode=7
2. Make a button with the command: cm_SyncChangeDir
3. Open TC's program directory in the left side and the directory where you keep tc1102x64_rc3.exe in the right side.
4. Run cm_SyncChangeDir 2 from the command line to make sure SyncChangeDir is not activated.
5. Notice that the cm_SyncChangeDir button is not activated.
6. In the right side open tc1102x64_rc3.exe with Ctrl+PgDn.
7. Notice that the cm_SyncChangeDir button is still not activated.
8. Open the nested INSTALL.CAB inside tc1102x64_rc2.exe
9. Notice that the cm_SyncChangeDir button has now changed to the activated state.
10. Go updir by double-clicking [..] in the right panel - the left panel goes updir too, which it should NOT do.

[ghisler(Author)]

Thanks for the step by step description, I can reproduce it now.

How about the rest of the function (when not entering nested archives)? There have been a lot of improvements in RC3...

[AntonyD]

2petermad
btw can you easily open INSTALL.CAB inside tc1102x32_64_rc3.exe ?
I can't for example for unknown reasons...
I use Ctrl+PgDn key for sequential entrance inside this CAB archive inside the EXE "archive"

[petermad]

How about the rest of the function

15.10.23 Fixed: cm_SyncChangeDir: Also handle SyncChangeDirMode values 1 and 4 when entering and leaving archives (32/64)
15.10.23 Fixed: cm_SyncChangeDir: No warning when trying to enter an archive which didn't exist on the other side when using SyncChangeDirMode=2 (the default) (32/64)
13.10.23 Fixed: cm_SyncChangeDir, SyncChangeDirMode with 4 added: Backspace or click on ".." button wasn't treated the same as double clicking on [..] in the file list (32/64)

All fixes seem to work as described.

With SyncChangeDirMode 5 or 7, and SyncChangeDir activated and not suspended, would it be idea to make Alt+LefArrow and Alt+RightArrow also perform synchronous change (like Backespace and douleclick on [..] does.

[petermad]

2AntonyD

btw can you easily open INSTALL.CAB inside tc1102x32_64_rc3.exe ?
I can't for example for unknown reasons...
I use Ctrl+PgDn key for sequential entrance inside this CAB archive inside the EXE "archive"

I can open the INSTALL.CAB file with just Enter or double-click also with a clean wincmd.ini file.
Can you open a not-nested cab file directly located or the disk with Enter?
CAB files are registered as compressed files in my Windows' and I can open cab files in Explorer with double-click/Enter

In My TC's .cab files have the yellow box archive icon, just like zip files, also when nested.

You could try with this in the [Configuration] section of wincmd.ini:

Code: Select all

PreferOpenTypes=+|*.cab

Or you could make sure cab files are registered in Windows:

Code: Select all

Windows Registry Editor Version 5.00

[HKEY_CLASSES_ROOT\.cab]
"PerceivedType"="compressed"
@="CABFolder"

[HKEY_CLASSES_ROOT\.cab\OpenWithProgids]
"CABFolder"=""

[HKEY_CLASSES_ROOT\.cab\PersistentHandler]
@="{098f2470-bae0-11cd-b579-08002b30bfeb}"

Windows Registry Editor Version 5.00

[HKEY_CLASSES_ROOT\.cab]
"PerceivedType"="compressed"
@="CABFolder"

[HKEY_CLASSES_ROOT\.cab\OpenWithProgids]
"CABFolder"=""

[HKEY_CLASSES_ROOT\.cab\PersistentHandler]
@="{098f2470-bae0-11cd-b579-08002b30bfeb}"

[petermad]

2ghisler(Author)
When using SyncChangeDirMode=7 I find that I often forget that I have activated it, when it is in suspended state.

Maybe a wincmd.ini parameter for a timeout (in minutes) SyncChangeDirTimeout=5
The parameter should only be accommodated when SyncChangeDirMode is 1, 3, 5 or 7.

[ghisler(Author)]

Thanks for the suggestion. But what would that be? 5 seconds? That would be far too short, e.g. when you want to check something in the directory which doesn't exist on the other side. Or 5 minutes? That, on the other hand, may be far too long. Maybe it would be better to add more cases where the function gets turned off automatically?

[petermad]

2ghisler(Author)

As suggested it should be configurable with a new parameter: SyncChangeDirTimeout - and the unit should be in minutes.

If not configurable I suggest 5 minutes.

[ghisler(Author)]

I will consider it for a future version. Unfortunately it would cause all kinds of new bugs, so it would drag the beta test for a lot of time.

[ghisler(Author)]

The following bug should be fixed in RC4 now, please check it:

20.10.23 Fixed: cm_SyncChangeDir: The function was getting enabled by mistake when entering an archive within an archive with SyncChangeDirMode=1 (or 2 or 4 added to it) (32/64)

[petermad]

20.10.23 Fixed: cm_SyncChangeDir: The function was getting enabled by mistake when entering an archive within an archive with SyncChangeDirMode=1 (or 2 or 4 added to it) (32/64)

Confirmed fixed in TC 11.02rc4

24.10.23 Added: cm_SyncChangeDir: In button bar, show yellow pause icon overlayed over button while the function is suspended (32/64)

Works fine - but where does that overlay icon come from? - I cannot find it in the totalcmd(64)exe file - it is not very pretty - I suggest to use icon number 36 instead if possible.