[RC5] big drop down menu icons

Bug reports will be moved here when the described bug has been fixed

Moderators: white, Hacker, petermad, Stefan2

Fla$her
Power Member
Power Member
Posts: 2321
Joined: 2020-01-18, 04:03 UTC

Re: [RC5] big drop down menu icons

Post by *Fla$her »

ghisler(Author) wrote: 2023-11-08, 08:37 UTC I think it looks indeed better. Here are they with 5 icon sizes 16x16, 24x24, 32x32, 48x48 and 64x64:
Image: https://www.ghisler.ch/images/baroverlays.png
Yes, better. Only the pause position is slightly low shifted. It would be better design-wise for it not to be attached to the bottom border of the button, but to stand one/two/three pixels (depending on the button size) higher from it.
Overquoting is evil! 👎
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 48093
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Re: [RC5] big drop down menu icons

Post by *ghisler(Author) »

Both overlay icons start and end at the same height above the border.
Author of Total Commander
https://www.ghisler.com
Fla$her
Power Member
Power Member
Posts: 2321
Joined: 2020-01-18, 04:03 UTC

Re: [RC5] big drop down menu icons

Post by *Fla$her »

The problem is that this height is 0.
Overquoting is evil! 👎
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 48093
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Re: [RC5] big drop down menu icons

Post by *ghisler(Author) »

No, it's 1, there is still a lue border below the overlay.
Author of Total Commander
https://www.ghisler.com
Fla$her
Power Member
Power Member
Posts: 2321
Joined: 2020-01-18, 04:03 UTC

Re: [RC5] big drop down menu icons

Post by *Fla$her »

See how it looks on the classic XP/7-theme with the 3D button pressed.
There is no indent, there is an overlay on the bottom 3D border.
Overquoting is evil! 👎
User avatar
petermad
Power Member
Power Member
Posts: 14810
Joined: 2003-02-05, 20:24 UTC
Location: Denmark
Contact:

Re: [RC5] big drop down menu icons

Post by *petermad »

With my setting on Windows 7 the overlay icons either sits directly at the lower border or overlaps the border: See: https://tcmd.madsenworld.dk/overlaybuttonbaricons.png

Maybe it would be better to position the overlay to the icon and not to the button? And take into account that the icon is shifted 1 pixel down and 1 pixel to the right, when the button is in it's depressed state.
License #524 (1994)
Danish Total Commander Translator
TC 11.03 32+64bit on Win XP 32bit & Win 7, 8.1 & 10 (22H2) 64bit, 'Everything' 1.5.0.1371a
TC 3.50 on Android 6 & 13
Try: TC Extended Menus | TC Languagebar | TC Dark Help | PHSM-Calendar
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 48093
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Re: [RC5] big drop down menu icons

Post by *ghisler(Author) »

2Fla$her
Please uncheck "XP style" when using classic theme, this moves the overlays 1 pixel up. This is a bug, I will fix it.
2petermad
That's because the button doesn't by itself move down when you press it, but the icon itself moves down to indicate to the user that the button is down. The overlay has to move with the button.
Maybe it would be better to position the overlay to the icon and not to the button?
I tried that initially, but since the overlay is so small, it was hard to see. Therefore I prefer to display it as far away from the icon as possible.
Author of Total Commander
https://www.ghisler.com
Fla$her
Power Member
Power Member
Posts: 2321
Joined: 2020-01-18, 04:03 UTC

Re: [RC5] big drop down menu icons

Post by *Fla$her »

this moves the overlays 1 pixel up.
I see 1 pixel, but only through a magnifier. For the proportion with the right indentation, can be increase at least to two for the icons 24+?
Overquoting is evil! 👎
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 48093
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Re: [RC5] big drop down menu icons

Post by *ghisler(Author) »

Maybe in a later version - for now I will add one pixel for buttons 32x32 or larger.
Author of Total Commander
https://www.ghisler.com
Fla$her
Power Member
Power Member
Posts: 2321
Joined: 2020-01-18, 04:03 UTC

Re: [RC5] big drop down menu icons

Post by *Fla$her »

And in this sense, what can distinguish a later version from the current one?
For a square button, the bottom indent should match the right one. This is the norm.
Overquoting is evil! 👎
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 48093
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Re: [RC5] big drop down menu icons

Post by *ghisler(Author) »

And in this sense, what can distinguish a later version from the current one?
That it comes out later?
The beta test of TC 11.02 has already taken far too long, I can't stretch it out forever.
Anyway, Total Commander 11.02 final is out now!

I haven't implemented all the wishes here, otherwise the beta test would take even longer.
But I have added a new overlay icon size for 48x48 pixel buttons, and use the largest size only for 64x64.
Author of Total Commander
https://www.ghisler.com
Fla$her
Power Member
Power Member
Posts: 2321
Joined: 2020-01-18, 04:03 UTC

Re: [RC5] big drop down menu icons

Post by *Fla$her »

Anyway, Total Commander 11.02 final is out now!
I see. I wrote the message before the release announcement.

Fixed problem with XP style.
Unfortunately, the pause size for 24x24 is still small. :( I expected the size as in RC5.
Last edited by Fla$her on 2023-11-09, 15:34 UTC, edited 1 time in total.
Overquoting is evil! 👎
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 48093
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Re: [RC5] big drop down menu icons

Post by *ghisler(Author) »

Unfortunately, the pause size for 24x24 is still small.
I changed this back to small because 24x24 buttons with 16x16 is the default, so many people would be affected by a size change (and I actually got a complaint in this thread about it!).
Just change the buttons to 25x25 to get the larger overlay size.
Author of Total Commander
https://www.ghisler.com
Fla$her
Power Member
Power Member
Posts: 2321
Joined: 2020-01-18, 04:03 UTC

Re: [RC5] big drop down menu icons

Post by *Fla$her »

with 16x16 is the default
But you can also make the normal size of the overlay icon by checking the small icon size setting. If it's < 24, then use 1 size, if not used or ≥ 24, then 2 size. Is that a problem?

Changing to 25x25 is bad advice. Not only does this bring scaling, but also the size of the panel will increase by squeezing out a few buttons (it can reach up to 30), which will affect the increase in the number of rows.

I also found the following bug:
  • If you create 3 other buttons after the button with the pause icon, then when you hover the cursor over the third one, the pause icon will appear.
  • If you create 3 other buttons after two buttons with a pause icon, then when you hover the cursor over the second and third ones, a pause icon will appear.
  • If you create 3 other buttons after three buttons with a pause icon, then when you hover the cursor over any of the three, a pause icon will appear.
Overquoting is evil! 👎
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 48093
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Re: [RC5] big drop down menu icons

Post by *ghisler(Author) »

Changing to 25x25 is bad advice. Not only does this bring scaling
No, you need to set the button size to 25x25 and the icon size to 16x16 or 24x24.
Author of Total Commander
https://www.ghisler.com
Post Reply