TC7rc3 - Compare By Content, Edit mode and default button

The behaviour described in the bug report is either by design, or would be far too complex/time-consuming to be changed

Moderators: Hacker, petermad, Stefan2, white

Post Reply
User avatar
white
Power Member
Power Member
Posts: 5784
Joined: 2003-11-19, 08:16 UTC
Location: Netherlands

TC7rc3 - Compare By Content, Edit mode and default button

Post by *white »

Select two files and open the Compare contents dialog (menu Files/Compare By Content).
The Compare button is the default button, except while in Edit mode.
In my opinion it should be:
The Compare button is the default button, except while one of the listboxes containing the file contents has focus when in Edit mode (1). In other words the Compare button is the default button, except while editing the file contents of one of the two files. When in Edit mode while changing one of the file names (possible if no files are changed) or while changing the compare options (Case sensitive etc.) the Compare button should be the default button (activated when hitting the Enter key).

(1) This line is edited to be more clear. The changed part is in bold. Original line was: "The Compare button is the default button, except while one of the listboxes containing the file contents has focus and while in Edit mode."
Last edited by white on 2007-04-29, 19:25 UTC, edited 1 time in total.
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 50475
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Post by *ghisler(Author) »

I prefer to keep it as it is now, it's too complex to understand what you suggest for the user. Now it's clear, "Compare" is the default only when not in edit mode.
Author of Total Commander
https://www.ghisler.com
User avatar
white
Power Member
Power Member
Posts: 5784
Joined: 2003-11-19, 08:16 UTC
Location: Netherlands

Post by *white »

ghisler(Author) wrote:I prefer to keep it as it is now, it's too complex to understand what you suggest for the user. Now it's clear, "Compare" is the default only when not in edit mode.
I doubt that it is too complex. I think the situation now can be confusing for users. Users are used to be able to hit the Enter-key to apply changes to options. Suddenly this is not possible.

Examples

First
  • Select two files and open the Compare contents dialog (menu Files/Compare By Content).
  • Click at one of the file names at the top and edit it.
  • Hit the Enter key when done.
Then
  • Select two files and open the Compare contents dialog (menu Files/Compare By Content).
  • Click on the Edit mode button.
  • Click at one of the file names at the top and edit it.
  • Hitting the Enter key to apply the changes does not work.


First
  • Select two files and open the Compare contents dialog (menu Files/Compare By Content).
  • Press Alt-I to change the option "ignore repeated spaces".
  • Hit the Enter key when done.
Then
  • Select two files and open the Compare contents dialog (menu Files/Compare By Content).
  • Click on the Edit mode button
  • Optionally change the contents of the files
  • Press Alt-I to change the option "ignore repeated spaces".
  • Hitting the Enter key to apply the changes does not work.
User avatar
petermad
Power Member
Power Member
Posts: 16027
Joined: 2003-02-05, 20:24 UTC
Location: Denmark
Contact:

Post by *petermad »

2white

Both of your last examples confirmed - the issues ought to be fixed.
License #524 (1994)
Danish Total Commander Translator
TC 11.51 32+64bit on Win XP 32bit & Win 7, 8.1 & 10 (22H2) 64bit, 'Everything' 1.5.0.1391a
TC 3.60b4 on Android 6, 13, 14
TC Extended Menus | TC Languagebar | TC Dark Help | PHSM-Calendar
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 50475
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Post by *ghisler(Author) »

Sorry, but I cannot make the button the default while in edit mode. Why? If I did, the user could no longer add new lines to the text!
Author of Total Commander
https://www.ghisler.com
User avatar
white
Power Member
Power Member
Posts: 5784
Joined: 2003-11-19, 08:16 UTC
Location: Netherlands

Post by *white »

ghisler(Author) wrote:Sorry, but I cannot make the button the default while in edit mode. Why? If I did, the user could no longer add new lines to the text!
My suggestion was to let the Compare button be the default button while not editing text! While in Edit mode other fields than the edit fields can have focus. When the focus is not on the edit fields the user can not add new lines so there is no reason why the Compare button could not be the default button in that case.

Situtation now:
The Compare button is the default button except when the following condition is met:
* Edit mode is active.

Suggested situation:
The Compare button is the default button except when both the following conditions are met:
* Edit mode is active.
* One of the fields where the file contents can be edited has focus.
Post Reply