Tortoise overlay icons disappear on commit

Captain · Post by *Captain » 2007-09-15, 14:44 UTC

Hi

when I check in one file all the overlay icons for Tortoise subversion disappear for the other files in the folder and I have to navigate out of the folder and back in again for the icons to come back. This behaviour is also erratic and does not happen all the time.

Pete

PeaceMaker · Post by *PeaceMaker » 2007-09-15, 14:54 UTC

...I'll check it out

SanskritFritz · Post by *SanskritFritz » 2007-09-15, 17:24 UTC

Same problem here.

Post by *ghisler(Author) » 2007-09-16, 08:50 UTC

I'm requesting the overlay icons as usual. Maybe Tortoise is busy with the commit and doesn't return any icons?

Captain · Post by *Captain » 2007-09-17, 08:45 UTC

Hi

As far as I can tell the commit is over but the overlay icons are not refreshed.

Pete

SanskritFritz · Post by *SanskritFritz » 2007-09-17, 12:39 UTC

Does TC not refresh the overlay icons when I press Ctrl-R? Because 1 minute after the commit, the icons are still not shown.

Post by *ghisler(Author) » 2007-09-17, 16:35 UTC

The icons are not cleared on Ctrl+R if nothing else in the directory has changed...

tortoisesvn · Post by *tortoisesvn » 2007-09-19, 18:27 UTC

FYI:
TortoiseSVN really does return "no status" (i.e., no overlay) while the working copy is locked or if it takes too long to fetch the status for some other reason.

But the TSVN status cache will send shell notifications as soon as the working copy isn't locked anymore (a working copy gets locked every time an update/commit/... is done until the operation is finished).

SHChangeNotify(SHCNE_UPDATEITEM, SHCNF_PATH | SHCNF_FLUSHNOWAIT, path, NULL);

Maybe you can catch those messages and update the overlays for those paths? The explorer catches those and therefore updates the overlays.

SanskritFritz · Post by *SanskritFritz » 2007-09-20, 09:33 UTC

http://tortoisesvn.tigris.org/servlets/ReadMsg?list=users&msgNo=7718

Post by *ghisler(Author) » 2007-09-20, 19:03 UTC

So in principle, TC could react to refresh messages (when auto-refresh options are used by the user). But how to know that the overlay has to be re-read? If TC did this on every refresh message, this would become rather slow...

SanskritFritz · Post by *SanskritFritz » 2007-09-20, 19:15 UTC

2ghisler(Author)
Could you please reread the post by tortoisesvn? I think he aswers your question right there.

Ghisler wrote:But how to know that the overlay has to be re-read?

tortoisesvn wrote:the TSVN status cache will send shell notifications as soon as the working copy isn't locked anymore (a working copy gets locked every time an update/commit/... is done until the operation is finished).

SHChangeNotify(SHCNE_UPDATEITEM, SHCNF_PATH | SHCNF_FLUSHNOWAIT, path, NULL);

Maybe you can catch those messages and update the overlays for those paths?

Post by *ghisler(Author) » 2007-09-20, 19:33 UTC

Well, it's an update message as TC gets when a file changes size during a download. If TC requested a new overlay icon every time a file size changes, this would mean a huge slowdown of the download...

SanskritFritz · Post by *SanskritFritz » 2007-09-20, 19:43 UTC

Oh, I see! I didnt know that. How come Explorer doesnt have any problems? Interesting... Maybe explorer reacts only once a second to that message? How about this as an idea?

SanskritFritz · Post by *SanskritFritz » 2007-09-21, 08:45 UTC

Time for a new request then

Lefteous · Post by *Lefteous » 2007-09-21, 09:01 UTC

2SanskritFritz
The question is if there is way to know that only the overlay icon changed has to be redrawn. The SHChangeNotify function supports very detailed information but the ReadDirectoryChangesW used by TC only supports a quite limited set of of update information. I guess that the SHChangeNotify call is translated into FILE_ACTION_MODIFIED.

http://msdn2.microsoft.com/en-us/library/aa364391.aspx