[Fixed] WM_COPYDATA CD: T param sets focus to right panel

Bug reports will be moved here when the described bug has been fixed

Moderators: Hacker, petermad, Stefan2, white

Post Reply
icfu
Power Member
Power Member
Posts: 6052
Joined: 2003-09-10, 18:33 UTC

[Fixed] WM_COPYDATA CD: T param sets focus to right panel

Post by *icfu »

No matter if only T is used or ST, the focus is always set to the right panel if two directories are transfered.

Icfu
Last edited by icfu on 2008-04-24, 17:01 UTC, edited 2 times in total.
This account is for sale
User avatar
Lefteous
Power Member
Power Member
Posts: 9536
Joined: 2003-02-09, 01:18 UTC
Location: Germany
Contact:

Post by *Lefteous »

TC seems to activate the tabs after creating them.
icfu
Power Member
Power Member
Posts: 6052
Joined: 2003-09-10, 18:33 UTC

Post by *icfu »

Yep, but when both dirs are sent, TC seems to ignore S parameter, otherwise the focus would be on the oppposite panel afterwards.

When only the right dir is sent while using ST, afterwards focus is on the opposite panel.

I had already requested that focus changes should be removed from /T, because this is what /P should be used for. But, /P still ignores /S unfortunately. Still no consistency in the parameter jungle.

Icfu
This account is for sale
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 50390
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Post by *ghisler(Author) »

Yes, T sets the focus to the new tabs. Have you tried to reverse the /R and /L parameters?
Author of Total Commander
https://www.ghisler.com
icfu
Power Member
Power Member
Posts: 6052
Joined: 2003-09-10, 18:33 UTC

Post by *icfu »

Have you read the title and first posting? This is a bug report about WM_COPYDATA change directory feature!

Icfu
This account is for sale
icfu
Power Member
Power Member
Posts: 6052
Joined: 2003-09-10, 18:33 UTC

Post by *icfu »

Answer?

Icfu
This account is for sale
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 50390
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Post by *ghisler(Author) »

Sorry, you cannot reverse the parameters for WM_COPYDATA, but you can of course send two separate WM_COPYDATA commands, in reverse order.
Author of Total Commander
https://www.ghisler.com
icfu
Power Member
Power Member
Posts: 6052
Joined: 2003-09-10, 18:33 UTC

Post by *icfu »

If you don't wanna remove the focus redundancy from T parameter for whatever reason, can you at least add support for P parameter in WM_COPYDATA?

This would also mean that P parameter finally starts respecting S parameter.

By the way:
Help file 4a is wrong regarding /P, it not only works on TC startup but also with a running TC...

Icfu
This account is for sale
User avatar
Lefteous
Power Member
Power Member
Posts: 9536
Joined: 2003-02-09, 01:18 UTC
Location: Germany
Contact:

Post by *Lefteous »

2ghisler(Author)
Please create the tabs in the background.
icfu
Power Member
Power Member
Posts: 6052
Joined: 2003-09-10, 18:33 UTC

Post by *icfu »

@ghisler: Any news regarding that?

I have just created a new AHK script which can open target paths of junctions in same or oppposite panel, either in same or new tab. Switching focus back by sending a <TAB> cannot be the solution...

Icfu
This account is for sale
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 50390
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Post by *ghisler(Author) »

For now there are no plans to change this behaviour, sorry. It would be strange if T created the tabs in the foreground in one version, and in the background in another. I think that this could be only solved by accepting a completely new, different parameter...
Author of Total Commander
https://www.ghisler.com
icfu
Power Member
Power Member
Posts: 6052
Joined: 2003-09-10, 18:33 UTC

Post by *icfu »

For now there are no plans to change this behaviour, sorry.
The bug discussed here is NOT that T sets focus, but that TC activates the WRONG panel when two directories plus ST is sent:
1. When focus is in the LEFT panel first, the focus is on the RIGHT afterwards. This is correct and expected.
2. When focus is on the RIGHT panel first, the focus stays RIGHT. This is wrong and unexpected. It should be LEFT.
It would be strange if T created the tabs in the foreground in one version, and in the background in another. I think that this could be only solved by accepting a completely new, different parameter...
It's perfectly ok for me if you implement a new parameter which does NOT set focus if you want to keep backwards compatibility, but the already existing parameters should at least show consistent results.

Icfu
This account is for sale
icfu
Power Member
Power Member
Posts: 6052
Joined: 2003-09-10, 18:33 UTC

Post by *icfu »

Oh happy day! Thanks! ;)

Icfu
This account is for sale
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 50390
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Post by *ghisler(Author) »

Indeed I misunderstood your bug report at first. The idea to create the new tab(s) in the background as a new command will be in TC 7.5 - I have already implemented it, but not backported to TC 7.03 because it would require too many changes.

Anyway, thanks for reporting and describing this error!
Author of Total Commander
https://www.ghisler.com
Post Reply