TC crashes when unpacking too long filename with unrar.dll

[Hacker]

- Make sure Use internal un-RAR is checked
- download this file
- try to unpack it using Alt-F9 into some subdir in your directory structure [EDIT] on the same drive [/EDIT], doesn't work well near the root of the drive
- TC crashes with:

Code: Select all

---------------------------
Total Commander
---------------------------
Access violation at address 00407150. Write of address 17494949.
Please report this error to the Author,
with a description of what you were doing when this error occured!
Continue execution?
---------------------------
Yes   No   
---------------------------

HTH
Roman

[karlchen]

Hi, Hacker.

The archive.rar has got only 533 bytes?
T.C. says there is an error reading the archive when "Test archive" is selected.
Trying to extract archive.rar to a subfolder of "%userprofile%\My Documents" (including stored folders) extracts the folder structure properly, but not the file.
No crash.

What needs to be done?

Karl
--
P.S.:
WinXP Pro SP2, T.C. 7.04a, internal unrar used

[icfu]

Confirmed for subdirs and root.

Icfu

[Clo]

2Hacker

Hello Roman !

• I can confirm the bug, but with a damper here :
- I don't get any access violation, only an error message "Disk read errror" (or so, it's in French).
- Only the sub-dirs are unpacked, the file inside the deepest level of the archive is not
(the <another long dirname> is empty). Same as Karl…

• Win XP-Pro SP1 - TC 7.04a

 KR
Claude
Clo

[Hacker]

karlchen, Clo,
I also sometimes get just Disk read error, try to unpack deeper into the dir structure on your hard drive and also try selecting Unpack to separate subdir.

The archive.rar has got only 533 bytes?

Yup. You can counter-test the integrity using WinRAR. You can also rename the file inside WinRAR and extract it then. It should read "test".

TIA
Roman

[karlchen]

Hi, Roman.

No way of crashing my T.C. (Implemented some extra stabilizing screws to it.)

Proceeded like you said.

The worst error message I get back is "Error reading file", but the folder structure is extracted.

Right now the base target folder is this

%userprofile%\Lokale Einstellungen\Anwendungsdaten\GHISLER\archive\long test dir name abcd efgh ijkl\another long dirname\archive\long test dir name abcd efgh ijkl\another long dirname\archive\archive\

T.C. will no longer create any subfolder here when trying to extract archive.rar using the options
+ including subfolders
+ unpack to a separate folder.

So using the target folder to be seen above only the error message gets displayed, nothing gets extracted any more.

Karl

[Clo]

2Hacker

Again…

• I did, but that doesn't change anything, the path of the unpacked folder is :

C:\A7\Test_rar\Test_l2\test_l3\archive\long test dir name abcd efgh ijkl\

Just a thought :  In my daily jobs, I'ld never unpack any archive in a so deep structure…

 KR
Claude
Clo

[ghisler(Author)]

Unfortunately I get only a read error too, no crash.
2Hacker
Can you give me an example of a target dir which causes a crash?

[CoolWater]

Confirmed on WXP SP3, TC 7.04a.

Target dir was D:\Temp\48\test\ -> Access violation occures everytime.

Regards,
CoolWater

[ghisler(Author)]

Sorry, no problem here on XP. I tried to unpack both just the file name, and the file name with full path...

[Hacker]

Christian,
See http://thehacker.totalcmd.net/tc/unrar.dll_crash.sqx - so for instance c:\archive\.
I am using the newest unrar.dll from here.

Roman

[CoolWater]

I get the read error only when target drive is diffing from source drive. If both drives are the same, access violation occurs if the target dir is as mentioned and unpack full path checked.

Regards

[Hacker]

I get the read error only when target drive is diffing from source drive.

Indeed, that might be a factor.

Roman

[karlchen]

Source drive and target drive were different here during all tests.
Archive.rar was located on D:\Downloads.
%Userprofile%\<somefoldertree> is located on C:

--

Copied the archive.rar to C:\Temp. Repeated the steps specified by Roman. => Access violation on first attempt. Had to kill T.C., because the extraction progress bar would not go away (no progress of course).

T.C.7.04a with the unrar.dll 3.80.1.87 shipped with T.C. 7.04a, WinXP Pro SP2.

Karl

[Hacker]

karlchen,
And when you try with the source and target drives being the same, as suggested?

TIA
Roman