Search in selected folder / location in TC 7.5 PB1

PeaceMaker · Post by *PeaceMaker » 2009-04-23, 17:40 UTC

Hello!

Total Commander 7.50 Public Beta 1 doesn't search in selected folder(s), but always set the root drive (eg. "C:\" or "D:\"). The older TC versions always put the selected folder(s) into search patch in a search window...

StickyNomad · Post by *StickyNomad » 2009-04-23, 17:49 UTC

Hm, works as expected here and behaves exactly like in Versions prior to 7.5b1:

Only the selected Directories are searched and in the path field, the current directory (the father-directory of the selected directories) is displayed. Same behaviour as in 7.04...

PeaceMaker · Post by *PeaceMaker » 2009-04-23, 17:53 UTC

2StickyNomad

I'm afraid it's not the same behaviour!

In previous TC versions when user selected folder(s) and then selected search option (Hot-Key, Context Menu, Defined Button, etc.), the "search path" in search window always shows the selected folder(s). In the PB1 there is no effect...

StickyNomad · Post by *StickyNomad » 2009-04-23, 18:00 UTC

2PeaceMaker

Hm, strange. From which Version did you update to 7.5b1? maybe it was different in TC < 6.x?

Besides from the text shown in your path field, is the 'only search in selected directories/files' checkbox set automatically after you open the search with selected directories?

Samuel · Post by *Samuel » 2009-04-23, 18:02 UTC

Edited several times: Can confirm something else.
Mh wait. Perhaps its the same bug. Are you speaking of first level folders?

Select one subfolder and use the "search" context menu entry.

Current folder is used for search instead of the subfolder like in TC 7. (Tested with Windows Vista.)

StickyNomad · Post by *StickyNomad » 2009-04-23, 18:11 UTC

After using the context menu I can confirm this too.

Seems like there is a difference between using the context menu and ALT+F7 in 7.04a:

Invoking the search with ALT+F7 with one directory selected displays the current dir in the path field, but when using the context menu, the selcted directory is shown...

7.5b1 indeed shows the current directory in both cases.

PeaceMaker · Post by *PeaceMaker » 2009-04-23, 18:13 UTC

2StickyNomad

No, I was thinking about any older version than 7.50 (7.04a, 7.04,...).

2Samuel

Yes, mainly first level folder(s), but not only!

P.S. I would like Mr Ghisler to post here about this change/bug.

PeaceMaker · Post by *PeaceMaker » 2009-04-23, 18:19 UTC

StickyNomad wrote:After using the context menu I can confirm this too.
Invoking the search with ALT+F7 with one directory selected displays the current dir in the path field, but when using the context menu, the selcted directory is shown...

No, I cannot confirm that...

Earlier, when user selected the folder(s), and then requested the search window, TC always shows the path to the selected folder! Now TC always shows path to the current folder(s) - no matter which search method is used (Hot-Key, Context Menu, Defined Button, etc.)...

Post by *Hacker » 2009-04-23, 18:49 UTC

StickyNomad,

Seems like there is a difference between using the context menu and ALT+F7 in 7.04a:

Invoking the search with ALT+F7 with one directory selected displays the current dir in the path field, but when using the context menu, the selcted directory is shown...

7.5b1 indeed shows the current directory in both cases.

I confirm this one. 7.04a down to 6.03a.

PeaceMaker,

Earlier, when user selected the folder(s), and then requested the search window, TC always shows the path to the selected folder!

Although I hazily seem to remember that as well, I cannot reproduce this (down to 6.03a).

Roman

PeaceMaker · Post by *PeaceMaker » 2009-04-23, 19:04 UTC

Hacker wrote:StickyNomad,
Although I hazily seem to remember that as well, I cannot reproduce this (down to 6.03a).

As I remember, the path was shown only if the folder was selected before the search windows was opened (by using [Ins] or right mouse click)...

Samuel · Post by *Samuel » 2009-04-23, 19:52 UTC

Have you tried to use a fresh ini?
Can you provide screenshots?

PeaceMaker · Post by *PeaceMaker » 2009-04-23, 21:04 UTC

I've discovered one more thing: after the search option is selected over some folder and the "Search in" path shows only the root folder, when you maximize or minimize the search window, the path automatically shows...

Try it!

Post by *petermad » 2009-04-24, 00:12 UTC

I just tested TC 7.04a and TC 7.50b1

The only difference I find is when only ONE directory is selected (not just highlighted) - and the context menu (opened by right-click, Shift+F10 or special windows keyboard key) is used to open the Search dialog.

In this case both versions deselects the selected dir, but 7.04a inserts the name of the selected dir in the "Search in" field, whereas 7.50b1 inserts the current dir in that field.

With all other ways of opening the Search dialog (Alt+F7, Menu, Button, command line) with ONE selected dir, the current dir is shown in the "Search in" field, but the box "Only search in selected directories/files" is selected in stead - I find that to be OK.
Same behaviour when more than one dir is selected, using Alt+F7 or other non-context menu approaches.

If more than one dir is selected, and the Search dialog is opened with the context menu (NOT invoked with right-click, but fx Shift+F10), then there also is a difference between TC 7.04a and TC 7.50b1.
In 7.40a the highlighted dir is shown in the "Search in" field. This is confusing because the highlighted dir is actually not searched, unless it is also selected.
The behaviour is better in 7.50b1 - it shows the current dir in the "Search in" field and checks the "Only search in selected directories/files" box, just as if Alt+F7 or any other non-context menu method had been used to open the Search dialog

My suggestion is that when opening the context menu when only one dir is selected, TC should not deselect that selected dir, just as it doesn't deselect any selected dirs when more than one dir is selected.

fenix_productions · Post by *fenix_productions » 2009-04-24, 00:38 UTC

I've just finished my testing too and I've got not visual differences between calling methods.

TC down to 6.02 behaves the same for me (no matter if anything selected): current dir is shown only.

When I select something selection does not disappear but "Only search in selected" checkbox is switched ON.

The only thing I can't test is "search via context menu" because I don't have such option at all. I don't even remember if it was there.

Post by *petermad » 2009-04-24, 00:54 UTC

the only thing I can't test is "search via context menu"

The context menu approch is the only one where I find a difference between TC 7 and 7.5 as described above

Do you really not see a "Search..." item when you press Shift+F10?

Note it will be in your Windows locale, no matter what language you use in TC.