TC750b3 SyncDirs: Deleting from RAR no longer working

Bug reports will be moved here when the described bug has been fixed

Moderators: Hacker, petermad, Stefan2, white

Post Reply
StatusQuo
Power Member
Power Member
Posts: 1524
Joined: 2007-01-17, 21:36 UTC
Location: Germany

TC750b3 SyncDirs: Deleting from RAR no longer working

Post by *StatusQuo »

TC 7.50b3, WinRAR3.71, XP SP3 (already there in 7.50 priv.beta 1)

In Synchronize Dirs (cm_FileSync) deleting of files from RAR archives is no longer working -
neither using asymmetric mode nor using right-click context menu.
WinRAR.exe is called, but says: "No files to delete."

In TC 7.04a both was working without a problem.
Who the hell is General Failure, and why is he reading my disk?
-- TC starter menu: Fast yet descriptive command access!
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 50390
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Post by *ghisler(Author) »

I have just tried that here, no problems at all! I tried both with files in the root of the RAR archive, and in subdirs. There was a problem with rar.exe (not winrar.exe) in older betas.

Can you give me more details, please?
1. Name of directory where winrar is installed
2. Name of temp dir (cd %temp% on command line)
3. Does the RAR file name contain any spaces or special characters?
4. Do the files to be deleted contain any spaces or special characters?
Author of Total Commander
https://www.ghisler.com
StatusQuo
Power Member
Power Member
Posts: 1524
Joined: 2007-01-17, 21:36 UTC
Location: Germany

Post by *StatusQuo »

Some additions:
- in normal TC window deleting the file inside the RAR works fine, while cm_FileSync fails on the same file
- after trying to delete from the RAR using context menu in cm_FileSync, the file disappears in the list, but appears again after pressing "Compare".
- using a fresh WINCMD.INI does not help

The requested details:
1.) WinRAR is in %COMMANDER_PATH%\Tools\WinRAR\WinRAR.exe
TC 7.04a is in D:\Tools\WinCmd
TC 7.50b3 is in D:\Tools\WinCmd2 (renamed to this for testing, deleting still fails)

2.) %TEMP% is D:\TEMP

3./4.) Names are as simple as possible - complete path to the file inside the RAR, I try to delete:
c:\tmp\right\TC-test.rar\1\aa.txt

Not even the sub-dir is needed. Here is a minimal RAR file where the action fails, too
(mark both files in the archive, start cm_FileSync comparing to any other directory - deleting from the archive fails here):

Code: Select all

begin 644 TCtest_min.rar
M4F%R(1H'`)O7<T@`#0````````#U2G2`@"4`%`````T````"O7Y,;K>F6CH=
M,P4`(````&$N='AT"0R_$+^@TC7^$L$?*#"=VK(T:@`,FW20@"8``P```!(`
M```"!T(OW[RF6CH=,P8`(````&%A+G1X="[D0#40>@#`-@`"`@```@(```(;
M(P<<`````!TP`@``````4E)0<F]T96-T*P$````!`````````.R64F%R(1H'
M`)O7<T@`#0````````#U2G2`@"4`%`````T````"O7Y,;K>F6CH=,P4`(```
M`&$N='AT"0R_$+^@TC7^$L$?*#"=VK(T:@`,FW20@"8``P```!(````"!T(O
MW[RF6CH=,P8`(````&%A+G1X="[D0```````````````````````````````
M````````````````````````````````````````````````````````````
M````````````````````````````````````````````````````````````
M````````````````````````````````````````````````````````````
M````````````````````````````````````````````````````````````
M````````````````````````````````````````````````````````````
M````````````````````````````````````````````````````````````
M````````````````````````````````````````````````````````````
M````````````````````````````````````````````````````````````
2``````````````#$/7L`0`<`
`
end
sum -r/size 6230/693

Who the hell is General Failure, and why is he reading my disk?
-- TC starter menu: Fast yet descriptive command access!
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 50390
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Post by *ghisler(Author) »

Thanks for your sample rar file, but I had no problems to delete one or both files from within the sync tool. Here is what I tried:
1. Copied my Winrar (registered version 3.71) installation to
%COMMANDER_PATH%\Tools\WinRAR\WinRAR.exe
2. In TC configuration, set the RAR location to
%COMMANDER_PATH%\Tools\WinRAR\WinRAR.exe
including the environment variable
3. My TEMP dir is in c:\temp
4. Put empty dir on left side and opened your RAR on right
5. Synchronize dirs, compare
6. Right click on a file, choose "delete right"
-> the file was deleted
7. Left the sync tool to verify that the file was removed from the RAR -> it was

I tried the same also with non-empty dirs, with symmetric and asymmetric mode, with the RAR on the left side - the file was always deleted!

Some more questions:
1. Is your winrar.exe 3.71 also 936960 bytes large?
2. While Winrar.exe shows the error, please start a second copy of TC without closing Winrar, go to your temp dir and check the contents of the newest temporary file. It should contain the list of files to be deleted. Can you post its contents here? Is it Unicode or plain text?
Author of Total Commander
https://www.ghisler.com
StatusQuo
Power Member
Power Member
Posts: 1524
Joined: 2007-01-17, 21:36 UTC
Location: Germany

Post by *StatusQuo »

Yes, my winrar.exe is the same size, MD5 checksum:
72a47494eeb5936657bed3b036391209 *WinRAR.exe

The temp. file is Unicode, but with strange looking content (path):

Code: Select all

begin 644 CMD3CB.tmp
L__[`T!(`>64[?M0)(P'ZV!(`=$,6`"0`,0!<`&$`80`N`'0`>`!T``T`"@``
`
end
sum -r/size 8363/44
Who the hell is General Failure, and why is he reading my disk?
-- TC starter menu: Fast yet descriptive command access!
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 50390
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Post by *ghisler(Author) »

That bug was fixed after beta 3 pre1 (12.5.09 in about box), md5:
98292cb04b9a6de3f9cb8423e24f0a4e

but before the public release of beta 3 (14.5.09 in about box), md5:
c00724245ea7832bceca4365e40ac948

Since you are a private beta tester, I guess that you are still running the "pre1" version. Can you check this?
Author of Total Commander
https://www.ghisler.com
StatusQuo
Power Member
Power Member
Posts: 1524
Joined: 2007-01-17, 21:36 UTC
Location: Germany

Post by *StatusQuo »

Indeed, I missed to update one installation from pre1. :oops:
At least I have meanwhile checked a couple of other PC's and OS's, too - the fix is working on all of them. ;)

Sorry for the confusion - already fixed in beta 3.
Who the hell is General Failure, and why is he reading my disk?
-- TC starter menu: Fast yet descriptive command access!
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 50390
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Post by *ghisler(Author) »

Ah, nice to hear that it's working correctly now!
Author of Total Commander
https://www.ghisler.com
Post Reply