[Lister] Last line after disabling "Word wrap"

[DrShark]

Steps to reproduce:
1. get FullTCHistory_Commented.txt from pdavit's FullTCHistory
2. Open it with lister with Word wrap option enabled
3. Enable text cursor.
4. Disable Word wrap when viewing file, try to reach the end of the document:
- with down arrow key (↓)
or
- with PageDown key
If use down arrow, you cannot reach the line below the last text line

Code: Select all

|1.00d   25.9.93 first published (German version)

If use PageDown key, you can:

Code: Select all

 1.00d   25.9.93 first published (German version)
|

If Word wrap will be disabled when opening file, you can go below last text line in both cases...

Tested on TC 7.04a and 7.5pb1&pb2.

[Flint]

Confirm on 7.50pb2.

[ts4242]

Cannot confirm on 7.50pb2 / Vista

[ghisler(Author)]

Cannot confirm either, 7.50pb2 on XP SP2.

[Clo]

2ghisler(Author)

Good evening,

• I can reach the line below the last one following the DrShark's steps with XP-Pro SP1.
- That isn't obvious to spot, though… I assume that's a kind of rounding about the lines count per page
when using the PageDown key…
- Anyway, very minor issue.

 VG
Claude
Clo

[Flint]

ghisler(Author)
It is important to follow each step exactly. For instance, word wrapping must be disabled (when I first tried to reproduce it, I missed that step and failed to reproduce).

[DrShark]

For instance, word wrapping must be disabled (when I first tried to reproduce it, I missed that step and failed to reproduce).

If you mean step 2, it should be enabled.

[Flint]

If you mean step 2, it should be enabled.

No, I meant the step 4. Though it is in bold, I missed it when I was testing it the first time. (Probably, because I thought something like that: "it's telling something about the word wrapping, I have already read that wrapping should be enabled and I did enable it, so everything's fine now, I don't need to do anything more", and actually missed that this time I needed to disable it.) So, I wrote my previous post to point at a possible item which other testers could similarly miss and hence be unable to reproduce the bug.

[ts4242]

I managed to reproduce with the following steps:

1. View "FullTCHistory_Commented.txt" (or any file end with single empty line)
2. Maxmize Lister window if it is not. (important step)
3. Enable word wrap (skip this step if it is already enabled)
4. Disable word wrap
5. Now you cannot select the last line with Shift+Down
6. If you normalized the Lister window then maxmized it again, the last line can be selected with Shift+Down

[ghisler(Author)]

I can reproduce it now, but it's so minor that I will probably not fix it if it's too complex (because it could cause other bugs). You can simply resize the window a bit to correct it.

[DrShark]

I can reproduce it now, but it's so minor that I will probably not fix it if it's too complex (because it could cause other bugs).

Why not? If it will cause any bugs, you can return old code... It's still beta test anyway.

You can simply resize the window a bit to correct it.

It means if I want to the copy entire document (Ctrl+A->Ctrl+C) I always should remember to resize Lister window...

[ghisler(Author)]

Why? Ctrl+A should still select everything...

[DrShark]

Ctrl+A should still select everything...

Good, just checked it. Yes, Ctrl+A selects everything.

5. Now you cannot select the last line with Shift+Down

It's still possible to select it with Shift+Right arrow.

[ghisler(Author)]

This should work correctly now, please test!

[ts4242]

2ghisler(Author)

I can confirm the fix in TC 7.50 PB 5.