TC opens closes and reopens new tab on middle mousebutton

[Samuel]

TC opens closes and reopens new tab on a click with middle mousebutton when it is inactive.

Steps to reproduce:
1) open more than 1 tab (register) in one panel
2) activate another program (for example Notepad)
3) without explicitly activating TC click with the middle mouse button on the rightmost tab.

-> TC will close this tab (intended) but it will also clone the tab to the left.

[fenix_productions]

Confirmed with RC2 but I think it will be fixed in final version

[Samuel]

Btw: TC 7.04a has the same behavior.

[ghisler(Author)]

Sorry, cannot reproduce.
The tab closes and stays closed here.

[Samuel]

See movie here:
http://www.drivehq.com/file/df.aspx/publish/SamuelPlentz/Dateien/Middleclick.avi

More than 1 tab is important. Also closing the rightmost.

[petermad]

I cannot repruduce this bug either - not with my usual ini nor with a clean ini file.

I am using Windows standard HID mouse driver with a Microsoft wireless mouse,

[Boofo]

I cannoit reproduce it either. I have a Micorsoft scroll wheel mouse with the wheel set as double-click and it works like it is supposed to for me.

[Samuel]

I need to get ashamed now.

You need the current ButtonBar eXtended to reproduce. I wrote a "MouseTool.ahk" for it, which is causing that.
It is used to be able to use the middle mouse button to execute different commands in the Toolbar. (Toolbar eXtended still works with ctrl, alt, shift without the tool running.)

So its up to me to fix this bug. I will report here when I fixed it.
fenix_productions I assume you also use my Buttonbar eXtended with MouseTool.

PS: The only thing Christian can do here is to include multiple commands per button (upon different modifiers / mousebuttons) into TC.

[Samuel]

This is strange.

Normally MouseTool catches the MiddleMouseButton events and replaces them with other MiddleMouseButton events. (if the events are catched above the ButtonBar MouseTool sends LeftMouseButton events)

But AutoHotkey apparently can't replace a MiddleMouseButtonUp event, if it doesn't know of the according MiddleMouseButtonDown event. Instead both events (the one from the user and the one created by MouseTool) are seen by Total Commander.

As a workaround I removed this line:

Code: Select all

#ifWinActive ahk_class TTOTAL_CMD

Any comments or suggestions are welcome!

This is the new code of "MouseTool.ahk":

Code: Select all

; "MouseTool" for "ButtonBar eXtended" for Total Commander
; Version: 1.2
; Freeware by Samuel Plentz - www.SamuelPlentz.de.vu

#NoTrayIcon
#SingleInstance FORCE
SetBatchLines -1

; read values from ini
MB1=0
IniRead,MB2     ,ButtonBar eXtended.ini,MouseTool,UseMouseButton2,0
IniRead,MB3     ,ButtonBar eXtended.ini,MouseTool,UseMouseButton3,1
IniRead,MB4     ,ButtonBar eXtended.ini,MouseTool,UseMouseButton4,1
IniRead,MB5     ,ButtonBar eXtended.ini,MouseTool,UseMouseButton5,1
IniRead,ShowIcon,ButtonBar eXtended.ini,MouseTool,ShowIcon       ,1

if(ShowIcon!="0"){
 menu,tray,Icon
 menu,tray,Tip,"MouseTool" for "ButtonBar eXtended"
}

; create the redirect keys
#ifWinActive ahk_class TTOTAL_CMD 
$LButton:: RedirectClick(1)
$RButton:: RedirectClick(2)
$MButton:: RedirectClick(3)
$XButton1::RedirectClick(4)
$XButton2::RedirectClick(5)
#ifWinActive



; simulates a normal mouseclick on click with mouse2 - mouse5 on the buttonbar
RedirectClick(Number)
{
 global

 if((MB%Number%!="0") && (OverButtonBar())){
  ClearMutex() 
  SetMutex(Number)
  PressMouseButton(1,0)
  WaitForKey(Number)
  PressMouseButton(1,1)
 }else{
  ClearMutex()
  PressMouseButton(Number,0)
  WaitForKey(Number)
  PressMouseButton(Number,1)
 }
 return

}

; checks if the mouse actually is over the buttonbar or not
OverButtonBar()
{
 if(WinActive("ahk_class TTOTAL_CMD")){
  MouseGetPos,,,,Control
  if(Control=="TButtonBar1"){
   return 1
  }
 }
 return 0
}

; waits for mousekey release
WaitForKey(Number)
{
 if(Number==1){
  KeyWait,LButton
 }else if(Number==2){
  KeyWait,RButton
 }else if(Number==3){
  KeyWait,MButton
 }else if(Number==4){
  KeyWait,XButton1
 }else if(Number==5){
  KeyWait,XButton2 
 }
}
  
; simulates mouseclick
PressMouseButton(Number,up)
{
 if(Number==1 && up==0){
  Click down L
 }else if(Number==1 && up==1){
  Click up L
 }else if(Number==2 && up==0){
  Click down R
 }else if(Number==2 && up==1){
  Click up R
 }else if(Number==3 && up==0){
  Click down M
 }else if(Number==3 && up==1){
  Click up M
 }else if(Number==4 && up==0){
  Click down X1
 }else if(Number==4 && up==1){
  Click up X1
 }else if(Number==5 && up==0){
  Click down X2
 }else if(Number==5 && up==1){
  Click up X2
 }
}

; create a mutex to notify "ButtonBar eXtended.exe" what MouseButton has been pressed
SetMutex(Number)
{
 global

 Mutex%Number% := DllCall("kernel32\CreateMutexA",Long,"0&",Int,"1",Str,"BBX_" . Number)
}

; close previous mutexes
ClearMutex()
{
 global
 
 if(Mutex2!=""){
  DllCall("CloseHandle","UInt",Mutex2)
  Mutex2=
 }
 if(Mutex3!=""){
  DllCall("CloseHandle","UInt",Mutex3)
  Mutex3=
 }
 if(Mutex4!=""){
  DllCall("CloseHandle","UInt",Mutex4)
  Mutex4=
 }
 if(Mutex5!=""){
  DllCall("CloseHandle","UInt",Mutex5)
  Mutex5=
 }
}

[petermad]

Should be moved to "Total Commander (English)" or "TC7.5 Behaviour which will not be changed"

[Hacker]

[mod]Moved to the Plugins and Addons forum.

Hacker (Moderator)[/mod]

[Balderstrom]

Why don't you change the code before triggering?
I'm not sure if TButtonBar1 can have other numbers or not, thus the RegExMatch instead of a direct == comparison.

Code: Select all

#ifWinActive ahk_class TTOTAL_CMD
{
	MouseGetPos, ,,,aControl
	if( RegExMatch(aControl, "^TButtonBar") )
	{
		/* HotKeyDefinitions here */
	}
}
return

[Samuel]

Sorry this does not help.

1) I think you didnt understand the problem. Your suggestions are unrelated.

2) Currently there is only a TButtonBar1 control in TC. So no need for RegEx.

3) Hotkeys in AutoHotkey only work at top Level. You cant nest them into functions.

[Balderstrom]

Except ... you're wrong

Code: Select all

Do_WinFunction(key)
{
	MouseGetPos, ,,,aControl
	if( aControl == "TButtonBar1" )
	{
		MsgBox, Win+%key%
	}
	else
	{
		Send, #%key%
	}
	return
}

#ifWinActive ahk_class TTOTAL_CMD
{
	$#r::Do_WinFunction("r")
}
return

Or more relevant to your purposes:

Code: Select all

Do_MouseAction()
{
	MouseGetPos, ,,,aControl
	if( aControl == "TButtonBar1" )
	{
		if( GetKeyState("Shift") == 1 )
		{
			MsgBox, ExtendedButtonBar Shift
		}
		else
		if( GetKeyState("Ctrl") == 1 )
		{
			MsgBox, ExtendedButtonBar Ctrl
		}
		;etc
	}
	else
	{
		Click Down
		KeyWait LButton
		Click Up
	}
	return
}
#ifWinActive ahk_class TTOTAL_CMD
{
	$Lbutton::Do_MouseAction()
}

[Balderstrom]

This is strange.
But AutoHotkey apparently can't replace a MiddleMouseButtonUp event, if it doesn't know of the according MiddleMouseButtonDown event. Instead both events (the one from the user and the one created by MouseTool) are seen by Total Commander.

And this is incorrect too, here's my AHK script for MButton:

Code: Select all

$Mbutton:: 
{
	MinMaxClose := WM_NCHITTEST()
	if( RegExMatch(MinMaxClose, "^(MINBUTTON|MAXBUTTON|CLOSE)$" ))
	{
		Send, {MButton}
		return
	}

	ControlGetFocus, aControl, ahk_class TTOTAL_CMD
	if( RegExMatch(aControl, "TMyListBox(1|2)") 
	&& !GetKeyState("Shift") )
	{
		;; TC ALIAS: CTRL+DEL = em_recycle
		;; 	   em_recycle = recycle.exe %S
		Send, ^{Delete}		
/*
		Send, {Delete}
		WinWait, ahk_class #32770
		ControlClick, &Yes
*/
		return
	}
	else
	if( WinActive("ahk_class SDL_app") )
	{
		Click, Down Middle
		KeyWait, Mbutton
		Click, Up Middle
	}
	else
	if( WinActive("ahk_class OpWindow") )
	{
		if( GetKeyState("Ctrl") == 1 )
		{
			Send, {.}		; STOP & OpKey: ^{.}
			return
		}
		else
			Send, {Delete}
	}
	else
		Send, {Delete}
	return
}

Notice, "Click Down Middle", and "Click Up Middle"