Paste button to buttonbar: Icon is not shown

[MVV]

When I paste button that contains external icon, TC pastes button with blank icon, and only when I then open button's properties and click OK, TC shows icon on the button.

Example:

Code: Select all

TOTALCMD#BAR#DATA 
%ComSpec% /c
for /f "delims=" %%a in (%F) do move "%%a" ..
%windir%\system32\shell32.dll,146 
Move one level up

1 
-1

[petermad]

I cannot confirm this.

Pasted your code to my buttton bar, and an icon with a nice green arrow appeared immediately.

Maybe your .br2 file is corrupt - try and delete it to have it totally refreshed.

[MVV]

I tried this on another computer - and same trouble. Maybe you can't confirm it because of your Windows 7?

Both PCs have Windows XP installed, and on both given button pastes with blank icon.

I tried to paste button to different bars (including new one) - same result.

BTW, if I copy pasted button and paste it again, it pastes correctly!

I found where error appears! If line with icon contains trailing space, button being pasted with blank icon!!! So if you copy source button code, all will work fine, but if you copy button code from code block in the post, your browser will copy lines with trailing spaces, so button will be pasted with blank icon!

So easy solution is to ignore trailing spaces on every line of button code when uses pastes button to buttonbar.

BTW, I don't understand why TC cannot resolve icon index if it has trailing space. I always calculate strings to numbers from given character up to first non-digit, so I get right number anyway.

[Balderstrom]

Win2K:
The last icon (index) in shell32.dll is 107.
If I change the 146 (icon index) in your code to 107, then it pastes correctly.

What's the maximum icon index for Shell32.dll under WinXP?

[sqa_wizard]

What's the maximum icon index for Shell32.dll under WinXP?

It is 237 on WinXP

[ts4242]

I don't understand why TC cannot resolve icon index if it has trailing space.

I think the problem is caused by FindFirstFile because if you called it to check file existence, it is return False if the path starting with <Space>, so when TC call it to see if the icon file exist or not, it return False and therefore TC skip resolve the icon.

and only when I then open button's properties and click OK, TC shows icon on the button.

That's because trailing space are removed.

[MVV]

I think the problem is caused by FindFirstFile because if you called it to check file existence, it is return False if the path starting with <Space>, so when TC call it to see if the icon file exist or not, it return False and therefore TC skip resolve the icon.

I think it is not such case. Buggy line with icon looks like this: <path_to_icon>,<icon_index><buggy_space>. So this space can't be a part of filename anyway since filename ends at comma but buggy space is at the end of line after icon index that should be calculated correctly even if there is a space after it.

Win2K:
The last icon (index) in shell32.dll is 107.
If I change the 146 (icon index) in your code to 107, then it pastes correctly.

Just write space after number 107 and copy text with this space - and you will see that pasted button's icon is blank.

[ts4242]

2MVV

I see.

It seems that if there is any space before or after the icon index, TC cannot get it.

[petermad]

2MVV

Maybe you can't confirm it because of your Windows 7?

I am using Xp SP3.

But anyway, I can confirm the bug if I add a space either before and/or after the icon path.

[Balderstrom]

Confirmed, space before and/or after the 107 (under Win2K) and the Icon isn't shown.

[MVV]

Well, you've got it:) trailing space may be added just while copying button code from forum message, so it can be really buggy for user who don't know that there should be no trailing spaces (and he may not see this space at all like me when I copied button text from first post of this topic).

Maybe you can't confirm it because of your Windows 7?

I am using Xp SP3.

Ah, I'm sorry, it is not you, it is ts4242 wrote that he has W7.

[ghisler(Author)]

Indeed this seems to be a bug of certain browsers, which copy a space which just isn't there.

The TOTALCMD#BAR#DATA clipboard object isn't really meant to be posted online, it's just for internal copy+paste within TC...

[MVV]

I think it is not so hard to remove trailing spaces since you anyway need to split text to lines.
And, why not to exchange TC buttons online? It will be good for TC.

[Boofo]

2MVV,

What does that button do?

[MVV]

What does that button do?

Moves selected objects one level up according to hint.
But it is just an example on which I've noticed this bug.