Bug in FlashView plugin causes lister crash - solution

[StayAtHome]

2Boofo
The problem never existed!
PLEASE RENAME OR UNSTICK THIS TOPIC!

[Boofo]

It must have at one time or Christian would never have reported it.

[Maxwish]

PLEASE RENAME OR UNSTICK THIS TOPIC!

I agree
Christian writes:

In TC 6.01, I will show an error when this bug is detected.

As we now have 6.01, the crash shouldn't happen anymore...

Besides:
Flashview is not an 'official' plugin, so unless Christian is going to make a sticky about every unofficial plugin that might cause a crash, I don't think a 'sticky' is justified

2StayAthome
Maybe you should email Christian about wanting to unstick this topic.

[ghisler(Author)]

OK, I will unstick it now!

[deus-ex]

Is/was anybody able to download v1.2 or can provide a working downloadlink ?
Allthough it is listed on StayAtHome's Downloadsite http://www.stayathome.nm.ru/files/, i can only access previous release v1.1.
Tried with no success since days.

[Leif]

Is/was anybody able to download v1.2 or can provide a working downloadlink ?
Allthough it is listed on StayAtHome's Downloadsite http://www.stayathome.nm.ru/files/, i can only access previous release v1.1.
Tried with no success since days.

Just tried it. NP at all. So try again!

[deus-ex]

Just tried it. NP at all. So try again!

Yeah, now it worked. Greetings to Mr. Murphy .

Thank you, Leif.

[djk]

Once again problems with FlashView.

Installing FlashView it adds by default new lines to wincmd.ini:

Code: Select all

15=D:\totalcmd\Lister\Flashview\FlashView.wlx
15_detect="MULTIMEDIA | ext="SWF" |(([0]="F" & [1]="W" & [2]="S")|([0]="C" & [1]="W" & [2]="S") & force)"

If try to view text file, eg. myfile.txt which is <=2bytes (!) I get an error:

External exception EEDFADE. (...)

If I change the configuration line into:

Code: Select all

15=D:\totalcmd\Lister\Flashview\FlashView.wlx
15_detect="ext="SWF" |(([0]="F" & [1]="W" & [2]="S")|([0]="C" & [1]="W" & [2]="S") & force)"

everything works ok.
Can anyone confirm it?

(WinXp Pro, TC 6.01, FlashView 1.2)

[icfu]

Confirmed.

Icfu

[ghisler(Author)]

The problem is a bad detect string:

15_detect="MULTIMEDIA | ext="SWF" |(([0]="F" & [1]="W" & [2]="S")|([0]="C" & [1]="W" & [2]="S") & force)"

Since MULTIMEDIA always returns true, this detect string will always be true too. So the SWF plugin will also try to load 2 byte files, and crash in its startup code. The correct dectect string should be
15_detect="MULTIMEDIA & ext="SWF" |(([0]="F" & [1]="W" & [2]="S")|([0]="C" & [1]="W" & [2]="S") & force)"

Since MULTIMEDIA is always true, this will have the desired effect. TC uses the flag MULTIMEDIA just to find out whether this plugin should override internal multimedia viewers or not!

[djk]

2StayAtHome
So you must make the next step and change the default detect string in next version

[StayAtHome]

2ghisler(Author)
Thanks for explanation!
2 All
Bug was fixed:
FlashView 1.3

[icfu]

It's again a different detect string from the one ghisler proposed but it seems to work, thx.

13_detect="MULTIMEDIA | ext="SWF" &(([0]="F" & [1]="W" & [2]="S")|([0]="C" & [1]="W" & [2]="S") & force)"

Icfu

[StayAtHome]

Oops!
I have upload the wrong version! Try again.
Sorry

[icfu]

Correct now, thx.

Icfu