This forum uses cookies. Click X button to hide this message. What is stored? 
Total Commander Forum Index Total Commander
Forum - Public Discussion and Support
 
 FAQFAQ   SearchSearch   MemberlistMemberlist   UsergroupsUsergroups   RegisterRegister 
 ProfileProfile   Log in to check your private messagesLog in to check your private messages   Log inLog in 

When overwriting a file, TC forgets to delete it's comment

 
Post new topic   Reply to topic    Total Commander Forum Index -> TC7.5x(a) final bug reports (English) Printable version
View previous topic :: View next topic  
Author Message
m^2
Power Member
Power Member


Joined: 12 Jul 2006
Posts: 1413
Location: Poland

PostPosted: Tue Nov 09, 2010 11:31 am    Post subject: When overwriting a file, TC forgets to delete it's comment Reply with quote

1. Create files C:\1 and C:\2
2. Add some comment to C:\1
3. Rename C:\2 to C:\1
Result: The new C:\1 has a comment from the old one.

I'm not sure if it's an omission or was it designed this way, but nontheless it was unexpected and certainly not natural for me. I feel that a comment is bound to a file, not to it's name. And actually renaming the other way (C:\1 to C:\2) keeps the comment with file.
_________________
Image: http://img201.imageshack.us/img201/2110/pcbsdec7.jpg
Back to top
View user's profile Send private message Visit poster's website AIM Address Yahoo Messenger
ghisler(Author)
Site Admin
Site Admin


Joined: 04 Feb 2003
Posts: 34294
Location: Switzerland

PostPosted: Thu Nov 11, 2010 10:15 am    Post subject: Reply with quote

By default, comments are not copied with files, except when you enable it in Configuration - Options - Operation - Copy comments with files.

Even then it only works when you don't use the Explorer copy or delete methods...
_________________
Author of Total Commander
http://www.ghisler.com
Back to top
View user's profile Send private message Send e-mail Visit poster's website
m^2
Power Member
Power Member


Joined: 12 Jul 2006
Posts: 1413
Location: Poland

PostPosted: Thu Nov 11, 2010 11:14 am    Post subject: Reply with quote

I should have mentioned it - I have TC configured this way.
_________________
Image: http://img201.imageshack.us/img201/2110/pcbsdec7.jpg
Back to top
View user's profile Send private message Visit poster's website AIM Address Yahoo Messenger
Balderstrom
Power Member
Power Member


Joined: 11 Oct 2005
Posts: 2146

PostPosted: Thu Nov 11, 2010 1:31 pm    Post subject: Reply with quote

When file 1 exists, and file 2 overwrites it -- and file 2 has a comment as well as file 1.
I'd think the best/optimal behaviour would to provide the user a dialog to find out which comment is correct.

But the above is how it's always worked afaik, the comment is bound to the fileName, normally it would update the comment to match what the new fileName is.

Apparently that part of the comment-change code doesn't get triggered when the new-file-name overwrites an old file, and the old-file has a comment.

It also occurs, if you have Explorer mode enabled for delete. (the descript.ion doesn't update after delete)

Copy01.txt -> Comment: Copy01
Copy02.txt -> Comment: Copy02

Delete Copy01.txt
Now uncheck Explorer delete method, just in case.

Rename, Copy02.txt to Copy01.txt

Copy02.txt -> Comment: Copy01
_________________
*BLINK* TC9 Added WM_COPYDATA and WM_USER queries for scripting.
Back to top
View user's profile Send private message Send e-mail
Display posts from previous:   
Post new topic   Reply to topic    Total Commander Forum Index -> TC7.5x(a) final bug reports (English) All times are GMT - 6 Hours
Page 1 of 1

 
Jump to:  
You cannot post new topics in this forum
You cannot reply to topics in this forum
You cannot edit your posts in this forum
You cannot delete your posts in this forum
You cannot vote in polls in this forum


Impressum: This site is maintained by Ghisler Software GmbH

Using phpBB © 2001-2005 phpBB Group