[x64] Gap at Bottom of File Display

romulous · Post by *romulous » 2011-09-19, 09:12 UTC

Using TC 8.0 x64 on Win 7 64bit, there is now a gap at the bottom of a file display (when you have scrolled all the way down to the bottom of a folder):
http://img829.imageshack.us/img829/8498/bug4y.png

Regards.

karlchen · Post by *karlchen » 2011-09-19, 09:53 UTC

Hello, Romulous.

Behaviour confirmed.

The question really is whether is happens by accident / mistake or by design?
In case it is by design, then the gap tells us, "We have really reached the end of the list, no more items to be displayed."
So it may be a bug as well as a feature.

Cheers,
Karl
--
Windows 7 Home Premium SP1, 64-bit
Total Commander 8.0 beta1 64-bit
Total Commander 8.0 beta1 32-bit

romulous · Post by *romulous » 2011-09-19, 10:50 UTC

That's true - it could be by design I suppose. Isn't that what the scrollbar is for though? At least the scrollbar is the way I tell that I am at the bottom of the file list, I don't need a visually distracting gap to tell me that.

Regards,

romulous

Post by *ghisler(Author) » 2011-09-20, 16:38 UTC

There is no gap - the window is size is just slightly different. If you resize the window a bit, there should again be no more gap (but there will then be one in 32-bit). I'm trying to figure out why the size is different...

romulous · Post by *romulous » 2011-09-21, 08:15 UTC

Hm - I have the window maximised though. So I have to 'un-maximise' it to get rid of the gap?

Sob · Post by *Sob » 2011-09-21, 14:25 UTC

The gap comes from the fact, that file list always shows the first item whole, i.e. the scrolling is not per-pixel, but per-item. It looks best when height of the file list is whole-number multiple of list item's height.

E.g. my list item's height is 16px. If file list height is 320px, then I have space for exactly 20 items and there's no gap at all. But if the file list height is 330px then what? Either 6px of last item must be cut or the list must be moved one item up and it creates 10px gap. Or there would have to be free per-pixel scrolling without aligning the first visible item. But I don't think it would be good.

And btw, it's exactly the same in 7.56a too.

romulous · Post by *romulous » 2011-09-22, 09:13 UTC

Sob wrote:And btw, it's exactly the same in 7.56a too.

On my system, v8 has the gap while v7.56a doesn't.

romulous

Post by *ghisler(Author) » 2011-09-22, 14:18 UTC

I don't get any gap as you describe it, just a partially visible last line in the listbox. What theme do you use?

Sob · Post by *Sob » 2011-09-22, 14:35 UTC

A little visual aid: http://web.hisoftware.cz/sob/img/tc80b1x64-file-list-gap.avi (0.4MB)

For line height X there's always gap from 0 to X-1, depending on list control height. And for me it's feature, not bug.

romulous · Post by *romulous » 2011-09-23, 09:30 UTC

ghisler(Author) wrote:I don't get any gap as you describe it, just a partially visible last line in the listbox. What theme do you use?

I might just be slow in trying to understand this - but how is it not a gap? My screenshot shows quite clearly there is nothing there, partially drawn or not.

I just use the normal Win 7 theme that you get upon install.

@sob: As I mentioned above, the window is maximised, I cannot resize it like you do in that video. Maximised TC 7.56a: no gap. Maximised TC v8 open right beside the 7.56a window for comparison (showing the same folder as 7.56a): gap.

romulous

Post by *ghisler(Author) » 2011-09-23, 10:18 UTC

I might just be slow in trying to understand this - but how is it not a gap? My screenshot shows quite clearly there is nothing there, partially drawn or not.

To me, a gap is a completely empty space (background color). I don't get this here in full view, I get a half-visible last line. However, in brief view I get such a gap because the window is scrolled horizontally.

Sob · Post by *Sob » 2011-09-23, 13:47 UTC

@romulous: And does the file list have exactly the same height in both TC7 and TC8? And the original report is about 64-bit TC8. Did you also try 32-bit TC8?

romulous · Post by *romulous » 2011-09-24, 02:23 UTC

@Christian: Right. It is a gap on my system, there is nothing there in Full view. There is nothing half visible, it is just the background colour.

@Sob: It should - both windows are fullscreen, and both commander instances have exactly the same settings in the ini file. I don't know how else I could make them the same size in this case - though if you have any suggestions for settings I can change or whatever, I can do that. I haven't tried 32bit TC8, no - only 64bit.

Sob · Post by *Sob » 2011-09-24, 12:34 UTC

Right, it should and it does here. I tried with different Windows themes, different list fonts, the results are exactly the same for both TC7 and TC8x64. So I don't have any idea why it's different for you.

Maybe try to make and pixel-compare fullscreen screenshots? Because in that screenshot you posted, you're missing only one pixel. If the list was just one pixel higher, the whole line would fit and there would be no gap.

romulous · Post by *romulous » 2011-09-24, 14:10 UTC

This is interesting. With the Command Line and the Function Keys Buttons both disabled (my normal configuration), I cannot produce the problem. With both of those enabled (just for testing), I cannot produce the problem. However, soon as I enable the Function Keys Buttons and disable the Command Line, the problem happens. The same thing happens (the problem occurs) if I enable the Command Line and disable the Function Keys Buttons.

So it would seem that having either of those two enabled - but not both at the same time - does something to the TC window?

Edit: And now having said that, I've just tried the same test in 7.56a - and the gap is there too. Despite what I thought previously, I obviously hadn't tried that exact test on 7.56a