Packer Dialog: Filename field and " "

Here you can propose new features, make suggestions etc.

Moderators: Hacker, petermad, Stefan2, white

Post Reply
Biozynotiker
Member
Member
Posts: 164
Joined: 2011-03-22, 09:57 UTC
Location: Germany

Packer Dialog: Filename field and " "

Post by *Biozynotiker »

TC currently adds automaticly " " between the packerstring and the suggested path/filename,
when there was a whitespace somewhere in the path or the selected folders to archive.
Example: rar:"C:\Dir\File with whitespace.rar"

And there is no " " set, when the suggested path/filename has no whitespace in it.
Example: rar:C:\Dir\File_without_whitespace.rar

Whats about to add these " " everytime to the string, after the "ok" button is pressed?
So you have not to look for whitespaces, everytime you edit the suggested path/filename.

Sure there must be a check, in the case the user has added " " manually before pressing ok, to avoid double " ".
Setting the " " everytime should not be a problem, even there is no whitespace.
#92832
User avatar
MVV
Power Member
Power Member
Posts: 8711
Joined: 2008-08-03, 12:51 UTC
Location: Russian Federation

Post by *MVV »

I would prefer adding " " before dialog is shown. So, user will see and edit quoted path. After closing dialog quotes are absolutely senseless since quotes are used only in user interface and never passed with names internally.
Biozynotiker
Member
Member
Posts: 164
Joined: 2011-03-22, 09:57 UTC
Location: Germany

Post by *Biozynotiker »

... since quotes are used only in user interface and never passed with names internally.
In this case (if I understand you right), quotes are in general senseless.

Adding quotes before or after the dialog should be never mind.
But looking for whitespace everytime and add quotes manually is not that comfortable.
#92832
User avatar
MVV
Power Member
Power Member
Posts: 8711
Joined: 2008-08-03, 12:51 UTC
Location: Russian Federation

Post by *MVV »

Seems it was done for external packers that are called by TC - in such case quotes are necessary because parameters with spaces must be quoted.
But it is correctly to quote filenames always.
Also TC may automatically quote all names before passing to external packer...
Post Reply