[8.0ß8-x64] Click on autocomplete element launches operation

[Flint]

1. Start TC with empty INI.
2. Navigate to any file, press F5.
3. In the destination editbox start typing something like c:\ — autocomplete dropdown list appears.
4. In the autocomplete list click on any subdirectory element with the left mouse button.
5. The file is immediately copied into the directory we clicked instead of just pasting the path into the editbox.

[karlchen]

Reported faulty behaviour reproduced. So: confirmed.

Server2008 R2
Total Commander 8.0ß8 64-bit

Karl

[ghisler(Author)]

Unfortunately you will have to live with that - I have seen it too, but couldn't find a way to prevent it. The click is forwarded to the edit control.

[Flint]

Unfortunately you will have to live with that - I have seen it too, but couldn't find a way to prevent it. The click is forwarded to the edit control.

I don't get it. How forwarding a click into the edit control could start the copying operation?

[ghisler(Author)]

The problem is that Windows itself sends a VK_RETURN key message when you click on such an entry. It's very difficult to distinguish that from a real ENTER pressed in that edit box. I have tried something now in beta 9, but it's not sure that it will work in all cases...

[Flint]

I see. Thanks for the fix.

I tested the version 8.0β9: Copy/Move and command line work fine now. Probably, it's worth searching through code where autocomplete is used and implementing the same solution.
Quick check revealed the following places where this problem is still present: Split file, Combine file, Edit buttonbar, Edit Starter menu, File encode.

[ghisler(Author)]

Thanks for confirming the fix. Since it's quite complex, I don't want to spread it to many other dialogs yet until I know that it works correctly in all situations.

[Flint]

OK, I'll keep an eye on it and try to test it thoroughly. For now, single left-button click and selecting an element by pressing Enter with different keyboard modifiers work correctly.

I found a couple of different problems though, I'll report them separately.

[ghisler(Author)]

Thanks!

[ghisler(Author)]

Please check this with beta 10!

[Flint]

Tested in β11 (sorry, could not find enough time for β10, was very busy at my work), so here's what is still not fixed:
1) cm_EditPath
2) Encode file
3) SyncDirs (when entering path in any of the two path fields)

Everything else seems to work correctly now.

[ghisler(Author)]

OK, I will check it.

[Flint]

Confirm fixed in 8.0β12.

[ghisler(Author)]

Thanks!