[x64] Compare by content and big files

Bug reports will be moved here when the described bug has been fixed

Moderators: Hacker, petermad, Stefan2, white

User avatar
HolgerK
Power Member
Power Member
Posts: 5409
Joined: 2006-01-26, 22:15 UTC
Location: Europe, Aachen

Post by *HolgerK »

ghisler(Author) wrote:Hmm, cannot reproduce. What are you comparing, binary or text? And how big are the files?
Two [x] Binary compares of different sized files, both > 3GB.
Just tested again with two ~1.3GB files. Here the magic limit is about 31-37%
And it's absolute reproducible, even from cache, by just clicking the [Compare] button again.

Text compare mode is ok:
HolgerK wrote:If i switch (after the first binary compare) to [_] binary and press [Compare] again, the dialog is always responding(even dialog resize was possible).
Regards
Holger
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 50532
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Post by *ghisler(Author) »

OK, I could reproduce it now by clicking on the compare window during binary compare. Windows erroneously thinks that TC is not responding because I'm not calling message loop functions, but checking the ESC key state myself. I will change that.
Author of Total Commander
https://www.ghisler.com
User avatar
HolgerK
Power Member
Power Member
Posts: 5409
Joined: 2006-01-26, 22:15 UTC
Location: Europe, Aachen

Post by *HolgerK »

History.txt wrote:27.11.11 Fixed: Compare by content of large binary files: Avoid that the window freezes after a few seconds, causing the progress bar to stop. Note that binary compare only counts the differences! (32/64)
Seems to be fixed with TC8.0ß11 (even resize is possible while compare is in progress).

Thanks
Holger
Sob
Power Member
Power Member
Posts: 945
Joined: 2005-01-19, 17:33 UTC

Post by *Sob »

Yes, it's fixed, but I found few other problems:

- have two larger files (I tried with ~700MB), completely same except for different first and last bytes
- compare them and let TC find the difference
- different first byte will be shown
- press Next difference
- it takes several seconds before TC finds the next difference and although the window is responsive, for the whole time I don't know what exactly is going on -> problem 1
- different last byte is shown now
- press Previous difference
- TC becomes unresponsive until the previous difference is found -> problem 2

Problem 2 seems to be same kind of bug that was just fixed. Problem 1 could be easily solved e.g. by showing current offset being searched in status bar. The numbers would change and it would be clear that something is happening and also how fast.

Plus one cosmetic problem, the progress bar in bottom right corner flickers (Win7 x64, Classic theme).

And btw, what does "Note that binary compare only counts the differences!" mean exactly? I just can't figure out if it says something that I didn't know before or not. :)
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 50532
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Post by *ghisler(Author) »

Currently I don't plan to make TC responsive during next/previous difference, sorry. Why? The user could try to start other functions.

So the original problem is fixed.
Author of Total Commander
https://www.ghisler.com
Sob
Power Member
Power Member
Posts: 945
Joined: 2005-01-19, 17:33 UTC

Post by *Sob »

ghisler(Author) wrote:Currently I don't plan to make TC responsive during next/previous difference, sorry. Why? The user could try to start other functions.
I wouldn't complain, I'm happy enough with fix for original problem. :) But you already did, at least partially. Compare window is not responsive only during backward searches (previous difference), but during forward searches (next difference) it is responsive. I can play with checkboxes, switch panels arrangement, open font dialog, even press Compare again (it seems to cancel the search) and also do anything else in main TC window.
Post Reply