[TC8ß10]: InplaceOkButton missing from the helpfile

Bug reports will be moved here when the described bug has been fixed

Moderators: white, Hacker, petermad, Stefan2

Post Reply
User avatar
karlchen
Power Member
Power Member
Posts: 4603
Joined: 2003-02-06, 22:23 UTC
Location: Germany

[TC8ß10]: InplaceOkButton missing from the helpfile

Post by *karlchen »

Hello, Christian.

Thank you for adding the new InplaceOkButton.
history.txt wrote:21.11.11 Added: wincmd.ini [Configuration] InplaceOkButton=0 turns off the button to confirm the inplace rename (32/64)
Nevertheless, I would like to complain that neither the English helpfile, nor the German helpfile explain about the new parameter InplaceOkButton. (4.b wincmd.ini).

Kind regards,
Karl
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 48232
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Post by *ghisler(Author) »

This wasn't documented yet because I wanted to hear your feedback about it first.
Author of Total Commander
https://www.ghisler.com
User avatar
Samuel
Power Member
Power Member
Posts: 1930
Joined: 2003-08-29, 15:44 UTC
Location: Germany, Brandenburg an der Havel
Contact:

Post by *Samuel »

Perhaps an additional InplaceCancelButton could improve the difference between TC and Explorer:

TC:
  • "Return" renames the file
  • click on another file in the panel cancels renaming
  • "ESC" cancels renaming
Explorer
  • "Return" renames the file
  • click on another file in the panel renames the file
  • "ESC" cancels renaming
Then "click on another file" could either rename the file like explorer does or ask the user to rename it. We would not need it as "cancel-action" anymore. (IMO the current way is a little bit strange.)
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 48232
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Post by *ghisler(Author) »

Sorry, interpreting a click outside is so illogical that I will not add it. Try clicking outside a dialog box, or outside a menu, it's NEVER interpreted as OK!
Author of Total Commander
https://www.ghisler.com
User avatar
MVV
Power Member
Power Member
Posts: 8704
Joined: 2008-08-03, 12:51 UTC
Location: Russian Federation

Post by *MVV »

I think additional flag may be added to confirm rename operation if name was changed and user has clicked outside rename window.
User avatar
Samuel
Power Member
Power Member
Posts: 1930
Joined: 2003-08-29, 15:44 UTC
Location: Germany, Brandenburg an der Havel
Contact:

Post by *Samuel »

ghisler(Author) wrote:Try clicking outside a dialog box, or outside a menu, it's NEVER interpreted as OK!
It is: in Explorer > rename ;-)
IIRC also CDex accepts this method when renaming tracks.

I for myself would prefer that TC would ask me in this case. (of course only if I changed the name)
It happened several times to me that I had to retype the name. (it is data loss, even when it is only some bytes)

Or TC could remember the typed in name. If I try to rename this file again, it could show the last name I tried to give to the file. (and aborted)

Or just an ini option like MVV suggested.
User avatar
Dalai
Power Member
Power Member
Posts: 9461
Joined: 2005-01-28, 22:17 UTC
Location: Meiningen (Südthüringen)

Post by *Dalai »

Samuel wrote:It is: in Explorer > rename
In Explorer you can undo the rename, TC doesn't have such a feature. So, clicking outside the input field should only rename a file if you can undo that. Otherwise it's data loss.

Regards Dalai
#101164 Personal licence
Ryzen 5 2600, 16 GiB RAM, ASUS Prime X370-A, Win7 x64

Plugins: Services2, Startups, CertificateInfo, SignatureInfo, LineBreakInfo - Download-Mirror
User avatar
ts4242
Power Member
Power Member
Posts: 2081
Joined: 2004-02-02, 20:08 UTC
Contact:

Post by *ts4242 »

It is documented in beta 11 but with wrong description
InplaceOkButton=1 Show button to confirm inplace rename:
1: to the left should be right
2: to the right should be left
0 do not show
User avatar
Sir_SiLvA
Power Member
Power Member
Posts: 3311
Joined: 2003-05-06, 11:46 UTC

Post by *Sir_SiLvA »

Its stated correct in the german helpfile
Hoecker sie sind raus!
User avatar
karlchen
Power Member
Power Member
Posts: 4603
Joined: 2003-02-06, 22:23 UTC
Location: Germany

Post by *karlchen »

Confirmations:
  1. The parameter has been added to section 4.b of the T.C. helpfile. Great. Thanks. :)
  2. The German help text is correct as stated by Sir_SiLvA:
    InplaceOkButton=1 Umbenennen: Button zum Bestätigen 1=rechts vom Namen, 2=links, 0=aus
  3. The English text explains the values 1 and 2 the wrong way round as illustrated by ts4242:
    InplaceOkButton=1 Show button to confirm inplace rename:
    1: to the left
    2: to the right
    0 do not show
  4. We have got 3 choices now where in the beginning we had none: right, left, off. :D
I'm confident the small helpfile error will be corrected in the next beta.

Karl
User avatar
petermad
Power Member
Power Member
Posts: 14914
Joined: 2003-02-05, 20:24 UTC
Location: Denmark
Contact:

Post by *petermad »

As I have stated in another thread:

IMHO the help file should be kept as it is, and TC's behaviour should be changed accordingly - e.g. InplaceOkButton=1 should be default and should mean to the left.
License #524 (1994)
Danish Total Commander Translator
TC 11.03 32+64bit on Win XP 32bit & Win 7, 8.1 & 10 (22H2) 64bit, 'Everything' 1.5.0.1371a
TC 3.50 on Android 6 & 13
Try: TC Extended Menus | TC Languagebar | TC Dark Help | PHSM-Calendar
User avatar
Sir_SiLvA
Power Member
Power Member
Posts: 3311
Joined: 2003-05-06, 11:46 UTC

Post by *Sir_SiLvA »

I beg to differ - default = right side this is how one would expect it.
Hoecker sie sind raus!
User avatar
petermad
Power Member
Power Member
Posts: 14914
Joined: 2003-02-05, 20:24 UTC
Location: Denmark
Contact:

Post by *petermad »

Fixed in TC 8.0b12 :-) - Helpfile and actual behaviour is now in sync.
License #524 (1994)
Danish Total Commander Translator
TC 11.03 32+64bit on Win XP 32bit & Win 7, 8.1 & 10 (22H2) 64bit, 'Everything' 1.5.0.1371a
TC 3.50 on Android 6 & 13
Try: TC Extended Menus | TC Languagebar | TC Dark Help | PHSM-Calendar
User avatar
karlchen
Power Member
Power Member
Posts: 4603
Joined: 2003-02-06, 22:23 UTC
Location: Germany

Post by *karlchen »

petermad wrote:Fixed in TC 8.0b12. Helpfile and actual behaviour is now in sync.
Correct. Reviewed the English and the German helpfile. Both explain InplaceOkButton correctly.

Karl
Post Reply