[8.0ß14] 64bit Rename with Hotkeys bug

Tuffi · Post by *Tuffi » 2011-12-27, 17:25 UTC

Hallo.

I activated the Operation option: "Select only the file name when renaming (not the extension)"

I select the file i want to rename -> type the Menu key and select "U" (german keyboard layout".
Now is the hole file name selected with the extension.
When i try to right-click with my mouse on the file and make a click on the rename option in the drop down menu, everything is ok. only the file name and not the extension is selected.

Kind regards,
Tuffi

Post by *petermad » 2011-12-28, 01:04 UTC

I connot reproduce this.

Here, pressing Menu key and then "m" (Danish Windows Loacale) works the same way as if I right-click and press "m" or if I click on the Rename entry (Omdøb) in the menu with the mouse.

Anyway, I prefer to use Shift+F6 for this task.

Flint · Post by *Flint » 2011-12-30, 11:12 UTC

I cannot reproduce it by pressing the "м" hotkey (Russian Windows 7) after the ContextMenu key, but I reproduced it by the following steps:
1. Press ContextMenu key.
2. The "Rename" command is last but one, so I press Up, Up, Enter.
3. The file name with extension is selected.

Besides, I can see that actually, only the file name is selected, but very quickly changes to "name+ext" selection.

Post by *ghisler(Author) » 2011-12-30, 11:26 UTC

Confirmed for the 64-bit version, thanks.

Post by *petermad » 2011-12-30, 21:51 UTC

I can confirm Flint's report too, with Danish Windows 7.

Post by *petermad » 2012-01-06, 20:25 UTC

I can still reproduce Flints description in TC 8.0b15, but only occasionally - most of the time the file name + extension gets selected, but immediately afterwards only the name is selected.

The full filename seems to get selected if I hold the Enter key down for about 0.2 seconds before I release it.

Post by *ghisler(Author) » 2012-01-08, 15:51 UTC

Sorry, this is the best I could do. Something is re-selecting the entire name, and I couldn't find out what is doing it. I spent half a day with the debugger trying to find the reason for this odd behaviour, no chance.

Flint · Post by *Flint » 2012-01-13, 13:23 UTC

10.01.12 Fixed: Inplace rename: option "Select only the file name when renaming" still not working when user pressed ENTER to invoke it (e.g. command line, context menu or button bar with keyboard) (64)

Seems to be completely fixed in 8.0β16. At least, I cannot reproduce it anymore.

Christian, could you tell us what it was?

Post by *petermad » 2012-01-13, 16:27 UTC

Seems to be completely fixed in 8.0β16. At least, I cannot reproduce it anymore.

Same here

Post by *ghisler(Author) » 2012-01-13, 21:43 UTC

Christian, could you tell us what it was?

I spent another half day on this problem because there were not too many bugs to fix this week. I finally found out that this is caused by the ENTER "key up" event sent to the rename box! It happens only when you invoke cm_renameonly by pressing ENTER: Either when you start it from the command line, or the context menu, or the main menu. The ENTER key up event is received only once the rename box is already visible. Using any other method to invoke the command (mouse, 'u' hotkey etc) doesn't trigger the problem.

So to fix it, all I had to do was to filter out this ENTER key up event when the rename box is visible...