TC reloads quick view after Tabbing back to VP filelist

MVV · Post by *MVV » 2012-01-04, 13:54 UTC

Tested with Virtual Panel.

1. Add some large JPG file to VP (at least 10-14 MPx, bigger is better), open quick view.
2. Use Tab to jump to quick view panel.
3. Fit image to window and zoom image in (I'm using Imagine).
4. Use Tab to return back to VP panel. You will notice that quick view panel shows image that is fit to window again - TC reloaded an image.

It can't be reproduced with regular file panel. Also it can't be reproduced with old Temporary Panel plugin (which doesn't support FsLinksToLocalFiles).

Post by *ghisler(Author) » 2012-01-05, 15:22 UTC

I think that it's done because the link target may have changed - changing that may have some unwanted side effects...

MVV · Post by *MVV » 2012-01-05, 20:25 UTC

Christian,

TC doesn't reload panel contents (doesn't ask for file attributes) - so it doesn't check if time/date/size changes. Is it really necessary to update file only on the off-chance?

Maybe you should check if file date/time/size have changed?.. Also you may check if link's target (or its attributes) have changed and reload file if it is so (but not always). Or maybe it is better to allow user to update it manually? I think such cases are really rare.

Also I think there is no reason to reread the file if VP tells that all is OK - it is a VP problem to report file change.

Post by *ghisler(Author) » 2012-01-06, 11:16 UTC

It's unfortunately not so easy to change, so for now I will leave it as it is, sorry.

MVV · Post by *MVV » 2012-01-06, 11:59 UTC

But you may disable it, it's quite easy, right?

I think most people who use Tab in QV window just want to finish viewing this file, not to update QV.

Post by *ghisler(Author) » 2012-01-08, 15:59 UTC

I would do it if it were that easy, but I get an OnChange event (or is it OnClick) when changing panels even if the file doesn't change. I would pobably introduce 20 new bugs if I just checked for changed line number...

radeknews · Post by *radeknews » 2012-01-09, 11:03 UTC

Gents,

the file in the quick-view seems to reload upon just about any keystroke, (e.g. space or even num-lock and caps-lock), as well as upon a mouse-click in the source panel (below, with a short file list), so this is not just at changing panels.

I appreciate you both taking a look into this.

Best regards
Radek

MVV · Post by *MVV » 2012-01-13, 13:17 UTC

Wow, it is fixed in TC8b16.

11.01.12 Fixed: Quick view (Ctrl+Q) in temporary panel: Only reload preview if the link target actually changed (32/64)

Thanks, Christian!

Post by *ghisler(Author) » 2012-01-13, 21:58 UTC

Thanks for checking! I didn't have too many bugfixes to do this week, so I found the time to test this in detail.