"File(s) modified, recompare?" dialog appears twic

[MarcinW]

"File(s) modified, recompare?" dialog appears twice

In some cases the "File(s) modified, recompare?" dialog appears twice. Steps to reproduce:

1. Compare files "a.txt" and "b.txt". "Compare contents" window appears.
2. Switch to the main window of TCMD and modify "a.txt".
3. Switch to the "Compare contents" window. The "File(s) modified, recompare?" dialog appears. DON'T CLOSE this dialog.
2. Switch to the main window of TCMD and modify "a.txt" again or "b.txt" (EDITED HERE).
4. Switch to the "Compare contents" window. After closing the "File(s) modified, recompare?" dialog, it appears again.

Regards!

[umbra]

Confirmed in TC8.0 beta 17a (both 32 and 64b versions).

[petermad]

Well, you modify twice - its seems reasonable to get a warning twice

[umbra]

2petermad
Well, you get two warnings regardless of how many times you modify the file (more than once of course), so it is unintuitive at least. And if you click in both warnings on Yes, those files are re-compared twice - after one comparison finishes the next one starts. This is unnecessary and with big files also rather slow. My point is there shouldn't be two warnings in the first place.

[MarcinW]

Petermad, you are of course right, however, there are two aspects:

- it may be simply annoying
- it's potentially dangerous from a programmer's point of view - it's called "orphan instance" - a programmer is expecting to have only one dialog instance at a time, so he declares some kind of a global variable for it. Doing so, he may unintentionally overwrite a handle (pointer) to the first dialog object during creation of the second dialog object - so the first object will never be released.

[petermad]

it's potentially dangerous from a programmer's point of view - it's called "orphan instance"

Sure, but maybe that is the downside of the Compare by Content window being non-modal.

[ghisler(Author)]

Hmm, not really a bug, but I will suppress the second dialog anyway.

[umbra]

Fixed in beta 18.

[MarcinW]

Fixed in beta 18.

[ghisler(Author)]

Thanks!