InternalAssociations - no items overlaping filters.

[fenix_productions]

Steps to reproduce:
1. start "find files" tool (Alt+F7)
2. define two filters as:

Code: Select all

first_SearchFor=*.png *.bmp
second_SearchFor=*.jpg *.png

3. launch "Internal Associations",
4. add two associations for these filters:

Code: Select all

[Associations]
Filter1=>first
Filter1_open=**
Filter1_XnView=D:\totalcmd\tools\media\XnView\xnview.exe "%1"
Filter2=>second
Filter2_open=**
Filter2_irfan=D:\totalcmd\tools\media\IrfanView\I_VIEW32.EXE "%1"

5. navigate through OK buttons
6. find any *.png file and open RMB context menu or call for cm_ContextMenuInternal.

Only the first item will be shown! When file matches two different filters only the first one is applied what is wrong IMHO.

Notes:
It makes assigning applications harder than expected.

There are two possible ways of defining what should happen with given extension:
- define one extension as rule and choose various applications for it,
- define set of extensions and call one application for it only.

Although first way seems to be more logical, the second one is a lot easier for the most of the software. I.e. XnView handles 400 files formats so it would be better to create few filters (due to filter length limit) for it first instead of browsing through all of file types. First approach is good for rare extensions only (or if you have small number of tools).

P.S. I know we are in RC stage and nothing new should be added but wouldn't it be better to indicate associations somehow (i.e. by implementing tc->IsAssociated field)?

[Lefteous]

2fenix_productions
Ghisler has already confirmed to add such a functionality. Maybe it has been forgotten.

[fenix_productions]

2Lefteous
Really? Then I missed (or forgot) that

[Lefteous]

2fenix_productions

Really

Really! Other place, large thread on this topic, page 16, 6th post.

[ghisler(Author)]

Sorry, it hasn't made it into TC 7.5. There are too many problems, like duplicate command names (e.g. "Edit" defined in multiple filters), and also possible speed problems when all filters have to be checked for all files. It needs considerable work, so I had to postpone it to TC 8.

[fenix_productions]

2Lefteous
Thanks. I've got it know.

2ghisler(Author)
Thank you for explanation. I hope TC 8 related threads will start to appear soon

[bfu]

Yes, these "overlapping filters" would be very handy for me too, for example when I have some actions applicable for all files (extensions).

#208434

[MVV]

Christian, maybe it is time for such feature? You can disable it by default and add wincmd.ini parameter to enable it. Let user solve problem with multiple items with same names (one can rename some items for multiple extensions to distinguish them).

[ghisler(Author)]

The question is how this should be presented to the user - it could be very confusing, especially when getting multiple identically named menu items from different filters.

[MVV]

As I said, this mode should be disabled by default, also user can rename identical labels himself. Anyway it is better than not to have such useful feature at all.

[white]

As I said, this mode should be disabled by default...

Instead of a global mode, maybe it is a good idea to make it configurable per filter or per verb.

[MVV]

Nice idea. I think it should be per-filter feature in order to continue filters processing.

[Juergen]

I would like this feature to stay as it is: the first matching filter applies. That's fine.
Any change should be only implemented as an option, please.

Regards, Juergen

[MVV]

Any change should be only implemented as an option, please.

Of course, no one will set new behaviour by default.


BTW it would be great to have such through filters for user-defined tooltip lines too. I'm sure it is easy to implement - just do not break filter searching loop in case of through filters.