MD5 bug

[mortendb]

I have found a bug in the SFV: MD5 creator

I added sfv/md5 checksum for the following 2 files

20040303.bak & 20040301

It gives me:
--
29131245B6FD99A319A7B4838544E579 20040303.bak
7BEE99DA42A52EB49DC5F75EDC7C47D4 20040301
--

When checking the MD5 sum it fails on the file 20040301
to get the check to work i have to add a "." to the filename 20040301
--
29131245B6FD99A319A7B4838544E579 20040303.bak
7BEE99DA42A52EB49DC5F75EDC7C47D4 20040301.
--

[IGL]

I confirm that - it looks like this problem exists for only some filenames being 8 chars long (?with numbers or repeated characters?), eg if filename is a2004030, a2014030, 2043abcd, aaaaabcd.

But NOT for filename: abcdefgh nor aaaaabc (7chars).
Weird

[Seikatsu]

I think I *might* know what the problem is. The internal Total Commander md5 checksum generator has an asterisk missing in the .md5 file. I really don't know anything about how it is checked, but I have seen an asterisk before the filename but after the checksum in all the other programs I have used to generate md5 checksums.

An example would be:
D41D8CD98F00B204E9800998ECF8427E a56c7777 (This one fails.)
D41D8CD98F00B204E9800998ECF8427E *a56c7777 (This one has the asterisk and checks out fine and it is like this in all the other programs.)

Maybe the TC author forgot to add that asterisk???

[Clo]

2Seikatsu
 Hello!
• Excep my mistake, *.SFV / *.md5 are checksum-files to control archives especially.
• I tested a md5 for this:

Code: Select all

1EBD72145F539E6E09C9185E0B8191ED  icones.rar

• That works just fine at home...


  Kind regards,
Clo

[mortendb]

Try to rename the file to 20040301 and make an MD5 sum again.

Please read the posts before responding to them

The md5 generator seems to have some flaws with 8 letters with one repeating and a missing "."

[Clo]

2mortendb
Hi,
• I have read this post for a while.
- renaming the same archive 12345678.rar works
- the same still, without extension 12345678 isn't found.
• Is it what you mean ?
K R
Clo

[mortendb]

Yes, that is the problem, some files are without extension, and if it is 8 chars with a repeating char the MD5 generator forgets the last .

[:)][:)][:)]

[IGL]

It looks like files beginning with number or containing at the end three or more the same characters. At least that is what I found out for now.
If I add * before the name - it is OK! But it may not be the best solution.
eg. Some FTP sites provide files and MD5 signature file. It may contain no "*" char - expecting that MD5 veryfying program will read it correctly.

These files cause error:
12345678 87654321 aaaaaaaa abcccccc abcddddd abcdeeee abcdefff

And these do not (they are verified correctly): aaaaaaag aaaaaafg aaaaaefg aaaadefg aaacdefg aabcdefg abbbbbbb abcdefgg abcdefgh z7654321 zaaaaaaz zb654321 zbc54321 zbcd4321 zbcde321 zbcdef21 zbcdefg1

[ghisler(Author)]

The 8 digits number of that file name looks like a CRC checksum so TC assumes that the long number is the file name and the short number is its CRC32...