+Crash on copy after closing connection

[MrCricket]

8.50b2 32b, clean INI

1) configure CIFS share on NAS server
2) copy some big dir to the share
3) start to duplicate it inplace by "shift-f5" (give another name)
4) press "Background" on copy dialog
5) close connection on the server
6) on taskbar: click the main TC window and the copy dialog, few times, alternately

Code: Select all

---------------------------
Total Commander 8.50b1
---------------------------
Fatal error in copy thread, aborting!
Access violation at address 006AAE5C. Read of address 00000034
Windows 7 SP1 6.1 (Build 7601)

Please report this error to the Author, with a description
of what you were doing when this error occurred!

Windows exception: C0000005
Stack trace:
006AAE5C
69437C  694599  694599  694599  694599  694599
6952E0  696E98  >417928  40362C  
Raw:
69437C  41CD6D  41D4DE  5F005F  6E0070  41E247
41E250  680071  4023EF  402249  4033D0  4021C8
6F476D  6F45C8  67D762  6F488F  67F06D  5C002C
5C002C  6E0070  57005A  5C002C  6E0070  6F47D3
41D1C1  5F006A  402249  4033D0  4021C8  680071
5F005F  57005A  6E006D  6C005F  6C006E  5F005F
44004E  6ABC95  4167BE  694599  41CD6D  41D4DE
6E0070  5F005F  41E247  41E250  680071  5F005F
4020A2  402249  6F476D  6F45C8  67D762  6F488F
67F06D  5C002C  5F005F  57005A  6F47D3  41D1C1

Press Ctrl+C to copy this report!
---------------------------
OK   
---------------------------

Code: Select all

---------------------------
Total Commander 8.50b1
---------------------------
Fatal error in copy thread, aborting!
Access violation at address 006AAE5C. Read of address 00000034
Windows Server 2008 SP1 6.0 (Build 6001)

Please report this error to the Author, with a description
of what you were doing when this error occurred!

Windows exception: C0000005
Stack trace:
006AAE5C
4023EF  402249  6F45C8  67D762  67F06D  41CD6D
41E247  41CD6D  41E247  6952E0  696E98  >417928
40362C  
Raw:
69437C  41CD6D  41D4DE  6E006D  6E006D  6C005F
41E247  41E250  680071  4023EF  402249  4033D0
4021C8  6F476D  6F45C8  67D762  6F488F  67F06D
5C002C  5C002C  6E0070  4F003F  5C002C  5C002C
6E0070  6F47D3  41D1C1  5F006A  6E006D  4020A2
680071  5F005F  57005A  6E006D  6C005F  6C006E
6E006D  6ABC95  4167BE  694599  41CD6D  41D4DE
6E0070  57005A  41E247  41E250  680071  5F005F
4F003F  4020A2  402249  6F476D  6F45C8  67D762
6F488F  67F06D  5C002C  5F005F  57005A  6F47D3

Press Ctrl+C to copy this report!
---------------------------
OK   
---------------------------

The crash retraced on W7(SMB2) and srv2008(SMB1)

[ghisler(Author)]

It seems to be an infinite loop in one of the directories. Is there any symbolic link on the server pointing to a parent directory or so?

[MrCricket]

Is there any symbolic link on the server pointing to a parent directory or so?

- no, the test directory is an unpacked NVIDIA driver: http://www.nvidia.com/object/win8-win7-winvista-64bit-310.90-whql-driver.html

BTW, TC8.01 handles it properly: mbox "Cannot write/Remove write protection" is displayed.

[MrCricket]

Same scenario on recent betas:

b3: same crash as in b2

b4: no crash, copy fails with strange error "You cannot copy a file to itself!": http://s16.postimg.org/txhbr8e2t/Untitled.png

[ghisler(Author)]

This error means that you specified a name which is the same as the source, e.g. when you copy to *.txt and one of the files already has extension .txt.

[MrCricket]

Yes, I understand a meaning of the error. I called it strange because it should be "Cannot write/Remove write protection" as in TC8.01, IMO

[ghisler(Author)]

But the name seems to be the same, according to your screenshot - are you sure you didn't try to copy a file to itself?

[MrCricket]

I'm duplicating existing dir by giving it another name, on same share, i.e.

\\IP\share1\dir1 -> \\IP\share1\dir2

while closing CIFS connection.

[MrCricket]

Christian, you can try to reproduce "copy a file to itself" bug just with a USB flash drive:

1) in the root of the USB dirve: create dir with file of 100M within

2) duplicate that dir by <shift>+<F5> and giving it another name

3) after few seconds - remove the USB drive from computer

4) mbox "Error: Can't read file" will raise: click "Retry"

5) mbox "You cannot copy a file to itself" appears

[ghisler(Author)]

OK, I could reproduce the flash drive problem! Please try with beta 5.

[MrCricket]

TC8.50b5 32b:

Both issues (crash and "copy a file to itself") are fixed - getting standard "Skip/Retry/Abort" dialog.

[ghisler(Author)]

Thanks for checking!