+exclamation mark

Bug reports will be moved here when the described bug has been fixed

Moderators: Hacker, petermad, Stefan2, white

Post Reply
User avatar
eugensyl
Power Member
Power Member
Posts: 564
Joined: 2004-06-03, 18:27 UTC
Location: România
Contact:

+exclamation mark

Post by *eugensyl »

I don't know if it's a really bug or is by design.
It's about the exclamation mark as alerter in front of some dangerous checkboxes.

For example, at Uncompress an archive.

When is double check the overwrite existing files checkbox, the exclamation mark is not shown again.

I expect to see the exclamation mark every time when I check the invoked checkboxes.
My Best Wishes,

Eugen
Sob
Power Member
Power Member
Posts: 945
Joined: 2005-01-19, 17:33 UTC

Post by *Sob »

If you just selected the option, you don't need an exclamation mark, because you know about it. But when it stays selected from previous use (which might have been long time ago, so you no longer remember that you selected it), TC notifies you about that.
User avatar
eugensyl
Power Member
Power Member
Posts: 564
Joined: 2004-06-03, 18:27 UTC
Location: România
Contact:

Post by *eugensyl »

Sob wrote:If you just selected the option, you don't need an exclamation mark, because you know about it. But when it stays selected from previous use (which might have been long time ago, so you no longer remember that you selected it), TC notifies you about that.
Yes, It's alright. This is why I said first that it can be by design.
Because it's about a beta version, it's very good to discuss about every aspect that can be improved. Many times (always in fact) Mr. Ghisler make the right decisions based on good idea from this forum.

Maybe this is the reason why Total Commander has a long life, more than 20 years and other orthodox commander not.

ShowWarningIcons=1 turn off this feature. I know that.
But my suppose is based on help file which said at New functions and fixes in Total Commander 8.50 beta 1:
"- Show exclamation mark to the left of some options as a warning, e.g. that files may not go where the user expects them to go, like during copying from branch view, or when packing and unpacking"

Show it's mean "always" in my opinion.

Thank you for your answer.
My Best Wishes,

Eugen
User avatar
eugensyl
Power Member
Power Member
Posts: 564
Joined: 2004-06-03, 18:27 UTC
Location: România
Contact:

Post by *eugensyl »

Also I think The exclamation mark can be extended in few others places:
- COPY: Verify
- MOVE: Verify

Both increase the time for copy/move.


Maybe somebody have more ideas...
My Best Wishes,

Eugen
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 50541
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Post by *ghisler(Author) »

Yes, it's by design - it should alert the user only when he doesn't expect it, when returning to a dialog where he set that option previously.

I have considered to add it to "Verify" too, but it would be strange to warn when the user wants to check his files, which is slower but better for the file data...
Author of Total Commander
https://www.ghisler.com
User avatar
eugensyl
Power Member
Power Member
Posts: 564
Joined: 2004-06-03, 18:27 UTC
Location: România
Contact:

Post by *eugensyl »

ghisler(Author) wrote:Yes, it's by design - it should alert the user only when he doesn't expect it, when returning to a dialog where he set that option previously.
Thank you for your answer.
ghisler(Author) wrote:I have considered to add it to "Verify" too, but it would be strange to warn when the user wants to check his files, which is slower but better for the file data...
With exclamation mark the feature will be better perceived and will cannot be ignored. Warning is about increasing of time, you may explain in help file. It's not necessary dangerous, but as you said, exclamation mark is by design a warning about settings set by default through configuration file, not when user check them self the check-box. And that is ok.
My Best Wishes,

Eugen
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 50541
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Post by *ghisler(Author) »

Hmm, what do other users think about exclamation near "Verify"? Should I add it or not?
Author of Total Commander
https://www.ghisler.com
User avatar
white
Power Member
Power Member
Posts: 5815
Joined: 2003-11-19, 08:16 UTC
Location: Netherlands

Post by *white »

ghisler(Author) wrote:Hmm, what do other users think about exclamation near "Verify"? Should I add it or not?
Yep, add it.

BTW. I hope the exclamation mark image will be replaced by one that is a bit more pretty.
User avatar
MarcinW
Power Member
Power Member
Posts: 852
Joined: 2012-01-23, 15:58 UTC
Location: Poland

Post by *MarcinW »

In my opinion, exclamation mark should be added for "verify" option - because:
1) verification is not used by default in everyday life,
2) verification slows down the operation.

Regards
Sob
Power Member
Power Member
Posts: 945
Joined: 2005-01-19, 17:33 UTC

Post by *Sob »

If I understand it right, there's one global Verify checkbox in options (#1) and then Verify checkbox in copy dialog (#2), which is only per-session. So #2 starts with the same state as #1 and if changed, it is kept for future uses of copy dialog. But it does not change #1. When TC is restarted, it again uses what was set in options. I hope it's intentional, because I like it very much.

TC should show exclamation mark near Verify if it differs from global option. So for both "global OFF, current ON" (default) and "global ON, current OFF" too. Because unnecessary slowdown is bad, but "unsafe operation" (for paranoid ones :) is bad too.
User avatar
MarcinW
Power Member
Power Member
Posts: 852
Joined: 2012-01-23, 15:58 UTC
Location: Poland

Post by *MarcinW »

I agree with Sob.
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 50541
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Post by *ghisler(Author) »

That's a nice idea, I will add it this way.
Author of Total Commander
https://www.ghisler.com
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 50541
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Post by *ghisler(Author) »

The Verify exclamation mark has been added exactly as requested (when the verify option is different from what is set in the main configuration). Can you try it, please?
Author of Total Commander
https://www.ghisler.com
User avatar
MarcinW
Power Member
Power Member
Posts: 852
Joined: 2012-01-23, 15:58 UTC
Location: Poland

Post by *MarcinW »

I confirm that now 32-bit version works as Sob suggested.
User avatar
white
Power Member
Power Member
Posts: 5815
Joined: 2003-11-19, 08:16 UTC
Location: Netherlands

Post by *white »

MarcinW wrote:I confirm that now 32-bit version works as Sob suggested.
Also confirmed for 32-bit version.
Post Reply