+[8.5b9] Ignore list not recursive

Bug reports will be moved here when the described bug has been fixed

Moderators: Hacker, petermad, Stefan2, white

Post Reply
User avatar
MVV
Power Member
Power Member
Posts: 8711
Joined: 2008-08-03, 12:51 UTC
Location: Russian Federation

+[8.5b9] Ignore list not recursive

Post by *MVV »

0. Add F:\TEMP\hhh\* to ignore list.
1. Put a file into F:\TEMP\hhh and then delete hhh. TC warns that you deleting hidden file.
2. Put subfolder with a file into F:\TEMP\hhh and then delete hhh. TC doesn't warn that you deleting hidden file.
3. Furthermore, if you enter a subfolder of hhh, you'll see all its contents so ignore list is not applied to subfolders of ignored folder.
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 50541
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Post by *ghisler(Author) »

Yes, you only tell TC to hide the folder. The user may want to go to a subdir of the folder directly (e.g. via a button), so the files inside the subfolder must not be hidden!
Author of Total Commander
https://www.ghisler.com
User avatar
MVV
Power Member
Power Member
Posts: 8711
Joined: 2008-08-03, 12:51 UTC
Location: Russian Federation

Post by *MVV »

What about adding special mask to ignore all inner dirs? E.g. F:\TEMP\hhh\*\* as it was in some old programs.
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 50541
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Post by *ghisler(Author) »

That's one solution, but it doesn't solve the problem you have. Other ideas would be
- treat the * differently depending on what you do (delete vs. list)
or
- warn about hidden folders too - but just hidden using this method, not when they have the real "hidden" attribute.

What do you think?
Author of Total Commander
https://www.ghisler.com
User avatar
MVV
Power Member
Power Member
Posts: 8711
Joined: 2008-08-03, 12:51 UTC
Location: Russian Federation

Post by *MVV »

I think first idea must be expanded to subfolders of ignored folders w/o * too (if I ignore C:\Test\Data but delete C:\Test, TC should warn before deleting something inside of C:\Test\Data). In other words, TC should warn before deleting every file which path contains ignored part.

Second idea should be almost the same but warning is for folder itself (difference is mostly in message text: folder path or file path). This way But this way will also touch ignored empty folders and it may be useful sometimes.

After some discussion on Russian board I can say that second case is preferred. However maybe it is a good idea to mix both: you show warnings for ignored items (BOTH files and folders recursively) until user answers 'All'.
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 50541
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Post by *ghisler(Author) »

I have chosen to use the first approach - but only when deleting a folder which contains the invisible folder, not when entering the subfolder and deleting the visible files there.
Author of Total Commander
https://www.ghisler.com
User avatar
MVV
Power Member
Power Member
Posts: 8711
Joined: 2008-08-03, 12:51 UTC
Location: Russian Federation

Post by *MVV »

Thanks, works OK in 8.50b10!
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 50541
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Post by *ghisler(Author) »

Thanks!
Author of Total Commander
https://www.ghisler.com
Post Reply