+[8.50ß11] Invalid auto-complete for path with '..'
Moderators: Hacker, petermad, Stefan2, white
+[8.50ß11] Invalid auto-complete for path with '..'
0. Make sure the auto-complete feature is turned on.
1. Press F5 for some file or files.
2. In the Copy dialog delete the file name or *.* and replace it with ..\ to copy to a parent directory, e.g. if there was C:\Temp\dir\*.* now should be C:\Temp\dir\..\
3. The auto-complete list is displayed incorrectly: not for C:\Temp\ as expected, but for the current directory's parent dir.
1. Press F5 for some file or files.
2. In the Copy dialog delete the file name or *.* and replace it with ..\ to copy to a parent directory, e.g. if there was C:\Temp\dir\*.* now should be C:\Temp\dir\..\
3. The auto-complete list is displayed incorrectly: not for C:\Temp\ as expected, but for the current directory's parent dir.
Flint's Homepage: Full TC Russification Package, VirtualDisk, NTFS Links, NoClose Replacer, and other stuff!
Using TC 11.03 / Win10 x64
Using TC 11.03 / Win10 x64
Re: [8.50ß11] Invalid auto-complete for path with '..'
Confirmed. Also when you hit F5 three times and enter ".". It seems everything before ".." or "." is ignored for the autocomplete function.Flint wrote:2. In the Copy dialog delete the file name or *.* and replace it with ..\ to copy to a parent directory, e.g. if there was C:\Temp\dir\*.* now should be C:\Temp\dir\..\
3. The auto-complete list is displayed incorrectly: not for C:\Temp\ as expected, but for the current directory's parent dir.
- ghisler(Author)
- Site Admin
- Posts: 50541
- Joined: 2003-02-04, 09:46 UTC
- Location: Switzerland
- Contact:
I will check it, but I fear that I can't do much about it because this is handled in a different location (via Windows callbacks) than the rest of the dialog.
Author of Total Commander
https://www.ghisler.com
https://www.ghisler.com
- ghisler(Author)
- Site Admin
- Posts: 50541
- Joined: 2003-02-04, 09:46 UTC
- Location: Switzerland
- Contact:
OK, I found a solution. ..\ was treated in a special way mainly for the command line, where users could enter something like
notepad ..\
and expect to get some suggestions for the parent dir.
notepad ..\
and expect to get some suggestions for the parent dir.
Author of Total Commander
https://www.ghisler.com
https://www.ghisler.com
Tested OK using TC 8.50b12 32bit.HISTORY.TXT wrote:04.12.13 Fixed: Auto-complete: \..\ within path not handled correctly (32/64)
Still not fixed for "."white wrote:Confirmed. Also when you hit F5 three times and enter ".". It seems everything before ".." or "." is ignored for the autocomplete function.
- ghisler(Author)
- Site Admin
- Posts: 50541
- Joined: 2003-02-04, 09:46 UTC
- Location: Switzerland
- Contact:
Not a bug, this is intentional. This is mainly meant for the command line to look for files in the current directory. Since there is no use to append just .\ to a path, I will not add special treatment for it.
Author of Total Commander
https://www.ghisler.com
https://www.ghisler.com
I confirm fix for ..\ in 8.50β12, both 32 and 64-bit.
The problem is, when such path is typed in (e.g. when user mistyped one dot) TC will suggest incorrect paths, and user might not notice that these specific subdirectories are not really present in the target path. So he/she will select the invalid subdirectories without even knowing they don't exist on the target side, and after copying the result will be unintentinal creating all those subdirs.ghisler(Author) wrote:Since there is no use to append just .\ to a path, I will not add special treatment for it.
Flint's Homepage: Full TC Russification Package, VirtualDisk, NTFS Links, NoClose Replacer, and other stuff!
Using TC 11.03 / Win10 x64
Using TC 11.03 / Win10 x64
- ghisler(Author)
- Site Admin
- Posts: 50541
- Joined: 2003-02-04, 09:46 UTC
- Location: Switzerland
- Contact:
Why do you expect that anyone would enter path\.\ in this field?
Author of Total Commander
https://www.ghisler.com
https://www.ghisler.com
ghisler(Author)
1. Typed ..\ but did not press the key hard enough, and one dot did not appear. With small fonts it's not easy to notice a difference between a dot and two dots from one glance.
2. For example, when I entered ..\ for parent dir, then thought better of it and decided to remove it. I know that .\ inside a path means nothing, so I may wish to save 2 keypresses by removing only 1 dot — resultant path will effectively be the same, but (surprisingly for user) not the auto-complete.
1. Typed ..\ but did not press the key hard enough, and one dot did not appear. With small fonts it's not easy to notice a difference between a dot and two dots from one glance.
2. For example, when I entered ..\ for parent dir, then thought better of it and decided to remove it. I know that .\ inside a path means nothing, so I may wish to save 2 keypresses by removing only 1 dot — resultant path will effectively be the same, but (surprisingly for user) not the auto-complete.
Flint's Homepage: Full TC Russification Package, VirtualDisk, NTFS Links, NoClose Replacer, and other stuff!
Using TC 11.03 / Win10 x64
Using TC 11.03 / Win10 x64
Anyone expects a valid path to be treated normally. No matter whether or not it is a useful path. The abnormal behavior will confuse the user and anyone will think this is a bug.ghisler(Author) wrote:Why do you expect that anyone would enter path\.\ in this field?
Same for "c:\path."and "c:\path.."
- ghisler(Author)
- Site Admin
- Posts: 50541
- Joined: 2003-02-04, 09:46 UTC
- Location: Switzerland
- Contact:
Sorry, there are just too many combination. Not worth the loss of time.
Author of Total Commander
https://www.ghisler.com
https://www.ghisler.com