+Starting/stopping folder sharing - no icon change

Bug reports will be moved here when the described bug has been fixed

Moderators: Hacker, petermad, Stefan2, white

User avatar
MarcinW
Power Member
Power Member
Posts: 852
Joined: 2012-01-23, 15:58 UTC
Location: Poland

+Starting/stopping folder sharing - no icon change

Post by *MarcinW »

Tested with Windows 2000 and Windows XP.

Proper behavior (TC 8.01 32-bit with clean ini file):
1) Display "C:\" in both panels.
2) Select some folder, for example "Windows", press Alt+Enter and enable sharing.
3) Icon of this folder changes in both panels (and shows that the folder is being shared now).

Improper behavior (TC 8.50 RC1 32-bit with clean ini file):
1) As above.
2) As above.
3) Nothing happens. Ctrl+R doesn't help. Entering into some folder and returning updates one panel, but the second still doesn't change.

Same problem when disabling a network share.
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 50541
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Post by *ghisler(Author) »

Sorry, this icon is cached because it takes a lot of time to retreive. There are no plans to change this behaviour. If this bothers you, you can turn on overlay icons.
Author of Total Commander
https://www.ghisler.com
User avatar
MarcinW
Power Member
Power Member
Posts: 852
Joined: 2012-01-23, 15:58 UTC
Location: Poland

Post by *MarcinW »

Ok.

What about implementing refreshing the icon after Ctrl+R? When we go into some folder and back, the icon will be refreshed, so I think that there would be no significant delay when adding this functionality also to Ctrl+R.
User avatar
petermad
Power Member
Power Member
Posts: 16032
Joined: 2003-02-05, 20:24 UTC
Location: Denmark
Contact:

Post by *petermad »

What about implementing refreshing the icon after Ctrl+R? When we go into some folder and back, the icon will be refreshed, so I think that there would be no significant delay when adding this functionality also to Ctrl+R.
I agree - this is what you would expect Ctrl+R to do.
License #524 (1994)
Danish Total Commander Translator
TC 11.51 32+64bit on Win XP 32bit & Win 7, 8.1 & 10 (22H2) 64bit, 'Everything' 1.5.0.1391a
TC 3.60b4 on Android 6, 13, 14
TC Extended Menus | TC Languagebar | TC Dark Help | PHSM-Calendar
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 50541
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Post by *ghisler(Author) »

Actually I have this in the code, but it's commented out with the note "Share test removed for speed reasons". I don't want to add this now, it would have unpredictable results.
Author of Total Commander
https://www.ghisler.com
User avatar
MarcinW
Power Member
Power Member
Posts: 852
Joined: 2012-01-23, 15:58 UTC
Location: Poland

Post by *MarcinW »

Ok, you may not want to change this just before the release.

In my opinion, Ctrl+R is a stronger feature than just browsing a directory tree. So if simple browsing refreshes the icon, Ctrl+R should to this all the more. When the user presses Ctr+R, he says "something has gone wrong and I want to see what I really have in this directory".
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 50541
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Post by *ghisler(Author) »

OK, I will add it for Ctrl+R only (and only the active panel), not for every directory refresh.
Author of Total Commander
https://www.ghisler.com
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 50541
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Post by *ghisler(Author) »

RC2: Ctrl+R should now also refresh the "shared" icons in the current panel - please test!
Author of Total Commander
https://www.ghisler.com
User avatar
petermad
Power Member
Power Member
Posts: 16032
Joined: 2003-02-05, 20:24 UTC
Location: Denmark
Contact:

Post by *petermad »

Confirmed fixed in TC 8.50 RC2 - but only for enabled sharing. If I un-share a folder and press Ctrl+R it still shows up as shared (under Win 7 or 8.1) - it should work both ways!

Another observation: In 32bit TC 8.50 RC2 under Windows XP if IconOverlays=1 then the shared folder icons are always shown also if TestIfSharedDir=0 - this is not the case under Windows 7 and 8.1 - here IconOverlays has no effect on the display of shared icons
Last edited by petermad on 2014-01-30, 16:47 UTC, edited 1 time in total.
License #524 (1994)
Danish Total Commander Translator
TC 11.51 32+64bit on Win XP 32bit & Win 7, 8.1 & 10 (22H2) 64bit, 'Everything' 1.5.0.1391a
TC 3.60b4 on Android 6, 13, 14
TC Extended Menus | TC Languagebar | TC Dark Help | PHSM-Calendar
User avatar
MarcinW
Power Member
Power Member
Posts: 852
Joined: 2012-01-23, 15:58 UTC
Location: Poland

Post by *MarcinW »

I just tested TC RC2 32-bit with Windows 2000 and Windows XP (themes off).

After pressing Ctrl+R, the behavior is strange. In order to see the actual folder sharing status, Ctrl+R must be pressed AND ALSO something must be done to redraw area of the icon. So the internal status of the folder is refreshed, but its icon isn't redrawn automatically.


Steps to reproduce (case 1):
1) Select, let's say, "Windows" folder.
2) Press Alt+Enter and enable/disable sharing.
3) Now press Ctrl+R.
4) To refresh the icon, you must:
- move selection with up/down arrow,
- click on any folder or file with mouse,
- switch to another application with Alt+Tab or mouse.


Steps to reproduce (case 2):
1) Select, let's say, "Windows" folder.
2) Press Alt+Enter and enable/disable sharing.
3) Select some other folder or file.
4) Now press Ctrl+R.
5) To refresh the icon, you must:
- move with up/down arrow until you select "Windows" folder,
- click on "Windows" folder with mouse and then click on another folder or file.
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 50541
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Post by *ghisler(Author) »

Strange, I will check it.
Author of Total Commander
https://www.ghisler.com
User avatar
petermad
Power Member
Power Member
Posts: 16032
Joined: 2003-02-05, 20:24 UTC
Location: Denmark
Contact:

Post by *petermad »

Steps to reproduce (case 1):
1) Select, let's say, "Windows" folder.
2) Press Alt+Enter and enable/disable sharing.
3) Now press Ctrl+R.
4) To refresh the icon, you must:
- move selection with up/down arrow,
- click on any folder or file with mouse,
- switch to another application with Alt+Tab or mouse.


Steps to reproduce (case 2):
1) Select, let's say, "Windows" folder.
2) Press Alt+Enter and enable/disable sharing.
3) Select some other folder or file.
4) Now press Ctrl+R.
5) To refresh the icon, you must:
- move with up/down arrow until you select "Windows" folder,
- click on "Windows" folder with mouse and then click on another folder or file.
I cannot reproduce this neither with Win XP nor with Win 7 or 8.1
License #524 (1994)
Danish Total Commander Translator
TC 11.51 32+64bit on Win XP 32bit & Win 7, 8.1 & 10 (22H2) 64bit, 'Everything' 1.5.0.1391a
TC 3.60b4 on Android 6, 13, 14
TC Extended Menus | TC Languagebar | TC Dark Help | PHSM-Calendar
User avatar
MarcinW
Power Member
Power Member
Posts: 852
Joined: 2012-01-23, 15:58 UTC
Location: Poland

Post by *MarcinW »

I just tested this with fully updated, virtualized Windows XP (with themes on, clean TC ini), and I could reproduce this behavior reliably.
User avatar
petermad
Power Member
Power Member
Posts: 16032
Joined: 2003-02-05, 20:24 UTC
Location: Denmark
Contact:

Post by *petermad »

Confirmed fixed in TC 8.50 RC3 32 and 64bit under Windows XP, 7 and 8.1 :-)
License #524 (1994)
Danish Total Commander Translator
TC 11.51 32+64bit on Win XP 32bit & Win 7, 8.1 & 10 (22H2) 64bit, 'Everything' 1.5.0.1391a
TC 3.60b4 on Android 6, 13, 14
TC Extended Menus | TC Languagebar | TC Dark Help | PHSM-Calendar
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 50541
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Post by *ghisler(Author) »

Thanks!
Author of Total Commander
https://www.ghisler.com
Post Reply