+Bug with making new directory with WCX plugins

Bug reports will be moved here when the described bug has been fixed

Moderators: Hacker, petermad, Stefan2, white

Post Reply
Eugene
Junior Member
Junior Member
Posts: 17
Joined: 2009-11-17, 20:59 UTC

+Bug with making new directory with WCX plugins

Post by *Eugene »

When making new directory using F7 key in some archive supported by external plugin, TC creates directory in windows TEMP, then calls PackFiles function to pack it to archive. The problem is that directory remains in TEMP, because TC neither deletes it itself, nor asks plugin to delete it by specifying PK_FLAG_MOVE_FILES flag. If I ask again to make directory with the same name (in the same or in another archive), the operation fails because directory with such name already exists in TEMP.

You can repeat it with any archive type, not supported by TC natively. Say, this one.
User avatar
karlchen
Power Member
Power Member
Posts: 4605
Joined: 2003-02-06, 22:23 UTC
Location: Germany

Post by *karlchen »

Hello, Eugene.

I can reproduce the reported behaviour.

Testing Environment:
+ Linux Mint 13, 32-bit, Wine 1.4.1
+ Total Commander 8.50 (final)
+ Packer Plugin: 7zip Plugin for Total Commander, 0.7.6.5a: 2011-10-24, Christian Ghisler, Recompiled for 64-bit Windows

Steps:
  1. Created temp.7z file holding some random files.
  2. copied temp.7z as temp2.7z
  3. opened temp.7z, pressed <F7> and created folder New1
  4. opened temp2.7z, pressed <F7> and created folder New1.
    This frequently would fail on first try: "error while packing".
    This would succeed on second try, however.
  5. opened temp.7z, pressed <F7> and created folder New2
  6. opened temp2.7z, pressed <F7> and created folder New2.
    This frequently would fail on first try: "error while packing".
    This would succeed on second try, however.
  7. repeated the steps 3-4, 5-6 with more folders.
    Always the same result:
    Creating folder NewX will succeed on first try in temp.7z, but will always fail on first try in temp2.7z.
    Second try will always succeed.
So far I have not been able to locate the offending NewX folder which you tell us will be left behind in %windir%\temp. Nothing left behind in %windir%\temp here.
OK, I found the foldernames which each <F7> inside a 7z-archive will leave behind:

Code: Select all

C:\users\karl\Temp\_tc\New1\
C:\users\karl\Temp\_tc\New2\
C:\users\karl\Temp\_tc\New3\
C:\users\karl\Temp\_tc\New4\
C:\users\karl\Temp\_tc\New5\
Hm, I guess this means I have fully reproduced your problem report.

Kind regards,
Karl
MX Linux 21.3 64-bit xfce, Total Commander 11.50 64-bit
The people of Alderaan keep on bravely fighting back the clone warriors sent out by the unscrupulous Sith Lord Palpatine.
The Prophet's Song
Eugene
Junior Member
Junior Member
Posts: 17
Joined: 2009-11-17, 20:59 UTC

Post by *Eugene »

I suppose this means the bug is confirmed?
Second try will always succeed.
To be precise, on first, third, fifth, etc tries it succeeds;
on second, fourth, sixth, etc tries it fails.
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 50541
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Post by *ghisler(Author) »

This is intentional because TC cannot know when that directory is no longer needed.
Author of Total Commander
https://www.ghisler.com
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 50541
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Post by *ghisler(Author) »

Actually it was a bug, so please test the fix in 8.51 beta 1!
Author of Total Commander
https://www.ghisler.com
User avatar
karlchen
Power Member
Power Member
Posts: 4605
Joined: 2003-02-06, 22:23 UTC
Location: Germany

Post by *karlchen »

Hello, Christian.

Summary:
The reported problem is no longer reproducible in Total Commander 8.51ß1.

Environment:
Testing Environment:
+ Linux Mint 13, 32-bit, Wine 1.4.1
+ Total Commander 8.51ß1
+ Packer Plugin: 7zip Plugin for Total Commander, 0.7.6.5a: 2011-10-24, Christian Ghisler, Recompiled for 64-bit Windows

Tests performed:
Same as explained above

Thanks for resolving the problem.
Karl
MX Linux 21.3 64-bit xfce, Total Commander 11.50 64-bit
The people of Alderaan keep on bravely fighting back the clone warriors sent out by the unscrupulous Sith Lord Palpatine.
The Prophet's Song
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 50541
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Post by *ghisler(Author) »

Thanks for checking it!
Author of Total Commander
https://www.ghisler.com
Eugene
Junior Member
Junior Member
Posts: 17
Joined: 2009-11-17, 20:59 UTC

Post by *Eugene »

Did a quick test in 8.51b1, looks like it is fixed in this version.
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 50541
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Post by *ghisler(Author) »

Thanks!
Author of Total Commander
https://www.ghisler.com
Post Reply