+Regexp don't works in some dialogs

Bug reports will be moved here when the described bug has been fixed

Moderators: Hacker, petermad, Stefan2, white

User avatar
Ovg
Power Member
Power Member
Posts: 755
Joined: 2014-01-06, 16:26 UTC

+Regexp don't works in some dialogs

Post by *Ovg »

TC 850 & 851b1 x32/x64 Win 7 x32/x64

Regexp don't works in some dialogs (set color for files or add custom columns from file overwrite dialog).

The bug is either in the caption text or the bug is that regexp is not working in those dialogs.

Pictures

Discussion here
It's impossible to lead us astray for we don't care even to choose the way.
#259941, TC 11.01 x64, Windows 7 SP1 x64
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 50541
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Post by *ghisler(Author) »

I will check it.
Author of Total Commander
https://www.ghisler.com
User avatar
Ovg
Power Member
Power Member
Posts: 755
Joined: 2014-01-06, 16:26 UTC

Post by *Ovg »

2ghisler(Author)
Thank you, mr. Ghisler
It's impossible to lead us astray for we don't care even to choose the way.
#259941, TC 11.01 x64, Windows 7 SP1 x64
User avatar
Ovg
Power Member
Power Member
Posts: 755
Joined: 2014-01-06, 16:26 UTC

Post by *Ovg »

2ghisler(Author)
It is working now! Thanks! 8.51β2 x86/x64
It's impossible to lead us astray for we don't care even to choose the way.
#259941, TC 11.01 x64, Windows 7 SP1 x64
User avatar
white
Power Member
Power Member
Posts: 5815
Joined: 2003-11-19, 08:16 UTC
Location: Netherlands

Post by *white »

HISTORY.TXT wrote:02.03.14 Fixed: Various dialogs didn't support regular expressions (with '<' prefix) although the dialog text suggested it: Colors by file type, help texts (hints) by file type, overwrite dialog custom fields, synchronize compare filters, and thumbnail texts by file type (32/64)
Tested OK except "synchronize compare filters". Is this the filter at the top middle in the Synchronize directories dialog?
User avatar
Ovg
Power Member
Power Member
Posts: 755
Joined: 2014-01-06, 16:26 UTC

Post by *Ovg »

2white
In this top middle field regexp is not working for me, only wildcards and filenames. When I try use regexp here error window "Function not supported" appears. Seems bug stilll here.
It's impossible to lead us astray for we don't care even to choose the way.
#259941, TC 11.01 x64, Windows 7 SP1 x64
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 50541
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Post by *ghisler(Author) »

Is this the filter at the top middle in the Synchronize directories dialog?
No, that one doesn't support regular expressions. It's the following:
In the sync dialog, enable "By content". Then click on small ">>" or "++" button to the right of "By content".

This can be used to compare certain file types with different compare plugins, e.g. a text comparer which ignores the line break type (Windows/Unix) in the internal "tc" plugin.
Author of Total Commander
https://www.ghisler.com
User avatar
white
Power Member
Power Member
Posts: 5815
Joined: 2003-11-19, 08:16 UTC
Location: Netherlands

Post by *white »

ghisler(Author) wrote:
Is this the filter at the top middle in the Synchronize directories dialog?
No, that one doesn't support regular expressions. It's the following:
In the sync dialog, enable "By content". Then click on small ">>" or "++" button to the right of "By content".
Tried it using TC 8.51b2 32bit. Does NOT work!
User avatar
Ovg
Power Member
Power Member
Posts: 755
Joined: 2014-01-06, 16:26 UTC

Post by *Ovg »

2ghisler(Author)
Ok, but may be you'll have to correct help:

"Dialog box: Synchronize directories

.... and (if necessary) the file types (wildcards), using the middle combobox. See Select Files how to include/exclude files by wildcards ...."

Open link Select files and we can see:

"Selecting files

...you can now also use regular expressions. They need to be started with a "<" character, to distinguish them from normal search strings...."
It's impossible to lead us astray for we don't care even to choose the way.
#259941, TC 11.01 x64, Windows 7 SP1 x64
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 50541
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Post by *ghisler(Author) »

2white
Please describe what you tried to do.
Author of Total Commander
https://www.ghisler.com
User avatar
white
Power Member
Power Member
Posts: 5815
Joined: 2003-11-19, 08:16 UTC
Location: Netherlands

Post by *white »

ghisler(Author) wrote:2white
Please describe what you tried to do.
Decode and unzip:

Code: Select all

MIME-Version: 1.0
Content-Type: application/octet-stream; name="Regex in synchr test.zip"
Content-Transfer-Encoding: base64
Content-Disposition: attachment; filename="Regex in synchr test.zip"

UEsDBBQAAgAAAGa7Z0QAAAAAAAAAAAAAAAAVAAAAUmVnZXggaW4gc3luY2hyIHRlc3QvUEsDBBQA
AgAAAHO7Z0QAAAAAAAAAAAAAAAAaAAAAUmVnZXggaW4gc3luY2hyIHRlc3QvVW5peC9QSwMEFAAC
AAgANYRmRNhUX3cIAAAABgAAACEAAABSZWdleCBpbiBzeW5jaHIgdGVzdC9Vbml4LzEyMy50eHQz
5DLiMuYCAFBLAwQUAAIAAADMu2dEAAAAAAAAAAAAAAAAIQAAAFJlZ2V4IGluIHN5bmNociB0ZXN0
L1dpbmRvd3NfRE9TL1BLAwQUAAIACAA1hGZEScT/TQsAAAAJAAAAKAAAAFJlZ2V4IGluIHN5bmNo
ciB0ZXN0L1dpbmRvd3NfRE9TLzEyMy50eHQz5OUy4uUy5uUCAFBLAQIUABQAAgAAAGa7Z0QAAAAA
AAAAAAAAAAAVAAAAAAAAAAAAEAAAAAAAAABSZWdleCBpbiBzeW5jaHIgdGVzdC9QSwECFAAUAAIA
AABzu2dEAAAAAAAAAAAAAAAAGgAAAAAAAAAAABAAAAAzAAAAUmVnZXggaW4gc3luY2hyIHRlc3Qv
VW5peC9QSwECFAAUAAIACAA1hGZE2FRfdwgAAAAGAAAAIQAAAAAAAAABACAAAABrAAAAUmVnZXgg
aW4gc3luY2hyIHRlc3QvVW5peC8xMjMudHh0UEsBAhQAFAACAAAAzLtnRAAAAAAAAAAAAAAAACEA
AAAAAAAAAAAQAAAAsgAAAFJlZ2V4IGluIHN5bmNociB0ZXN0L1dpbmRvd3NfRE9TL1BLAQIUABQA
AgAIADWEZkRJxP9NCwAAAAkAAAAoAAAAAAAAAAEAIAAAAPEAAABSZWdleCBpbiBzeW5jaHIgdGVz
dC9XaW5kb3dzX0RPUy8xMjMudHh0UEsFBgAAAAAFAAUAfwEAAEIBAAAAAA==
* Synchronize directories Unix and Windows_DOS
* Enable "by content" and click Compare
Files are displayed as different.
* Click ++ button located after "by content"
* Enable Use plugin compare functions
* Click Add
* Enter file type "*"
* Enter custom field: [=tc.Compare as text]
* Click OK to close the window and click Compare in synchronize window
Files are now displayed as equal using text compare (equal sign "=" with "TXT" on top of it).
* Click ++ button located after "by content"
* Select definition created above and click Edit
* Change file type to "<.*"
* Click OK to close the window and return to synchronize window
* Click Compare
Files are displayed as different.
User avatar
white
Power Member
Power Member
Posts: 5815
Joined: 2003-11-19, 08:16 UTC
Location: Netherlands

Post by *white »

white wrote:
ghisler(Author) wrote:
Is this the filter at the top middle in the Synchronize directories dialog?
No, that one doesn't support regular expressions. It's the following:
In the sync dialog, enable "By content". Then click on small ">>" or "++" button to the right of "By content".
Tried it using TC 8.51b2 32bit. Does NOT work!
Tested OK using TC 8.51b3 32bit.
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 50541
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Post by *ghisler(Author) »

Thanks!

Btw, I wanted to implement RegEx also in the main sync function (the edit box between the two paths), but i can't. The reason: Users can make case-sensitive searches with RegEx. This could have the bad effect that a file is only found on one side when it has different case on the other side...
Author of Total Commander
https://www.ghisler.com
User avatar
Ovg
Power Member
Power Member
Posts: 755
Joined: 2014-01-06, 16:26 UTC

Post by *Ovg »

white wrote:Tested OK using TC 8.51b3 32bit.
Tested OK using TC 8.51b3 64 bit.
It's impossible to lead us astray for we don't care even to choose the way.
#259941, TC 11.01 x64, Windows 7 SP1 x64
User avatar
MarcinW
Power Member
Power Member
Posts: 852
Joined: 2012-01-23, 15:58 UTC
Location: Poland

Post by *MarcinW »

ghisler(Author) wrote:Users can make case-sensitive searches with RegEx. This could have the bad effect that a file is only found on one side when it has different case on the other side...
What about converting all filenames (internally) to lowercase, and also converting RegEx expression to lowercase?
Post Reply