[Small Bug] Bug on Cursor Font Color.

[islogged]

Windows 10 - Tc 64bit

The "Cursor Font" color change the "Mark Font" color and not the "Cursor Font" color as promised !
Capture of the bug : http://imgur.com/Kq3Pdib.jpg

Edit 01:
For those who don't like to read this boring and crazy thread my solution is given here (by image retouching): http://i.imgur.com/Tc9XrCy.jpg

Edit 02:
And the complementary solution of HolgerK to add a [Mark Font] color option more than the actual [Mark Color]: http://ghisler.ch/board/viewtopic.php?p=306564#306564

[petermad]

That is because you have selected "Use Inverted Selection" - If you select "Use inverted cursor" it works as expected

[islogged]

That is because you have selected "Use Inverted Selection" - If you select "Use inverted cursor" it works as expected

lol (sorry), it's the definition of a Bug ... work in one case but not in all the cases ...
Agree?

[HolgerK]

--- Edit---
For those who are interest in other opinions than the one and only point of view of islogged, read this: http://ghisler.ch/board/viewtopic.php?p=306564#306564
--- End edit---

Cursor font: Allows to change the color of the text inside the cursor bar. This option is only available if the inverted cursor is used.

But it's also available if inverted selection is active and has than a different different meaning -> Mark font.
It may be by design, to give the user a better control over background vs. foreground contrast of inverted cursor/selection(mark) bars but it's neither mention in UI-Help nor wincmd.ini

CursorText=16777215 Cursor text color (only for solid cursor)

One may argument that the definition of cursor (a cursor is an indicator used to show the current position for user interaction ) may fit to both kinds of inverted bars, but it's not so clear, and can lead to misunderstandings.

A simple UI-change like a different order and text:

Mark color:
Inverted font:
Cursor color:

can clarify that this may be by design.

Regards
Holger

[petermad]

If you notice there are 3 diffrent states (not just 2):
1. No inversion
2 "Use inverted cursor"
3. "Use Inverted Selection"

As I see it, the field "Cursor font" (which is disabled in state 1) only applies to inverted elements = either the cursor text in state 2 or the selected text in state 3.

But I give you that it is confusing - maybe if the field "Cursor font" was called "Font color for inverted elements" it would be more understandable - or just "Inverted font color" (in line with HolgerK's suggestion)

[islogged]

Sorry, but more i read you (both), more i get a confused mind !

To Clarify the Situation:
- There is no bug in State 1
- There is no bug in State 2
- The Bug i reported here is only on the State 3

If you look in the Example Panel here: http://i.imgur.com/79HGtcf.jpg
- Font of [Mark] must be Blue and not Green as it is. <= The Bug
- Font of [Cursor] must be Green and not Blue as it is. <= The Bug
- Font of [Mark + Cursor] is Ok !

It's just only a Color State Bug between Mark Font and Cursor Font Color inside the code of TC.
No less, no more ...

Can someone confirm about that ?
Thank you

[HolgerK]

It's just only a Color State Bug between Mark Font and Cursor Font Color inside the code of TC

The problem is that there is no difference between a mark font and a cursor font -color.
Wincmd.ini has only one variable CursorText which is used for the text color of inverted bars.
ATM there is only one inverted bar possible (either "inverted cursor" or "inverted selection").
I guess your suggestion

I think this suggestions is not a Code big work ...

isn't as easy as you think.

Regards
Holger

[islogged]

The problem is that there is no difference between a mark font and a cursor font -color ... ATM there is only one inverted bar possible (either "inverted cursor" or "inverted selection").

There is ... as you can see here: http://i.imgur.com/kxP6VpK.jpg
[Cursor] font is green
[Mark + Cursor] font is brown
... and both are Inverted !


It's not my job because TC is not an openSouce project, then i can not act on this Bug ...
Anyway in State 3 the code just need to be changed as something like that :

example.[Mark].Font == user.Font_Color
example.[Cursor].Font == user.Cusor_Font
example.[Mark+Cursor].Font == user.Cusor_Font


Where is the difficulty with that ?

[HolgerK]

[Cursor] font is green
[Mark + Cursor] font is brown
... and both are Inverted !

There is only one inverted Cursor bar.
The picture shows two different states (which can not happen inside a file panel together!) just for demonstration how the colors match.
- Inverted cursor on a file entry which is selected/marked
and
- Inverted cursor on a file entry which is not selected.

...
example.[Cursor].Font == user.Cusor.Font
example.[Mark+Cursor].Font == user.Cusor.Font

Where is the difficulty with that ?

You will not be able to see any difference between selected or not for the file under the inverted cursor bar.

Regards
Holger

[islogged]

Sorry, but i really don't understand what you tell me !
You see complex things where simple ones ...

You will not be able to see any difference between selected or not for the file under the inverted cursor bar.

In State 3, files Inverted are also files Selected.

And as you can see here (if no bug) : http://i.imgur.com/79HGtcf.jpg

Files : Blue on White
Cursor on a File : Green on White (with red border here)

Selected Files : Blue on Brown
Cursor on a Selected File : Green on Brown

No cases with No differences !

[HolgerK]

Sigh...

Text Color = Blue
Backgroundcolor(2) = White
MarkColor = Brown
Cursor Color = Red
Cursor Font = Green
[x] Use inverted cursor
[_] Use inverted selection

Cursor on File : Green on White (with red border here)

Inverted Cursor!!!-> Green Text on Red Background!!!

Selected Files : Blue on Brown

corrected: Brown Text on White Background! (Non inverting selection!)

Cursor on a Selected File : Green on Brown

Where do you see definition of a Brown Background?

Seems you are mixing your wish with reality.

Regards
Holger

Edit: Sorry this was an answer to your first picture http://i.imgur.com/kxP6VpK.jpg

[HolgerK]

In State 3, files Inverted are also files Selected.

And as you can see here (if no bug) : http://i.imgur.com/79HGtcf.jpg

Files : Blue on White
Cursor on a File : Green on White (with red border here)

Selected Files : Blue on Brown
Cursor on a Selected File : Green on Brown

No cases with No differences !

Please don't change the settings you are talking about from one post to another
The above picture shows an Inverted Selection
My comment about no difference between "cursor" or "mark + cursor" was about your first setup with Inverted Cursor.

Thanks
Holger

[islogged]

To Clarify the Situation:
- There is no bug in State 1
- There is no bug in State 2
- The Bug i reported here is only on the State 3

In State 3, files Inverted are also files Selected.
And as you can see here (if no bug) : http://i.imgur.com/79HGtcf.jpg

Edit: Sorry this was an answer to your first picture http://i.imgur.com/kxP6VpK.jpg

> No since the begin i speak about the state of the Bug !

Seems you are mixing your wish with reality.

> Now i think it's you who mix all the cases ^^

[islogged]

Please don't change the settings you are talking about from one post to another
The above picture shows an Inverted Selection
My comment about no difference between "cursor" or "mark + cursor" was about your first setup with Inverted Cursor

I don't change, this picture was just an answer for you to that :

The problem is that there is no difference between a mark font and a cursor font -color.
Wincmd.ini has only one variable CursorText which is used for the text color of inverted bars.
ATM there is only one inverted bar possible (either "inverted cursor" or "inverted selection").

Then now ... we are Done ?
All is Ok ?

[HolgerK]

Okay lets again explain my point of view:
The bug is the label "Cursor Font" (which should be called "Inverted Font") because it's only available if one of the use inverted ... options is active.
TC uses this color as font color for either inverted cursor (State2) or inverted selection (State3) to give the user more possibilities for the color of inverted bars.
Without this trick the range of colors for inverted bars are limited to lighter colors if the normal black text color is used (darker background colors with black text colors will give nearly unreadable contrast).

Another solution can be to introduce an additional "Mark Font" color which would add more complexity to the user interface.

Regards
Holger