themes conflict: Use Windows theme for cursor

[SailorMax]

I think this is not correct take system theme only for cursor. System theme of cursor and system theme - this is solid thing. Or use system theme colors for list+cursor, or do not at all.

Otherwise we have situation when system theme based on white background (=> cursor is dark), but Total Commander theme based on black background (=> cursor is bright) (or vice versa) -> "Use Windows theme for cursor" made cursor invisible...

[ghisler(Author)]

???
I'm already using system theme in most places, the cursor was the last thing where I didn't use it yet...

[SailorMax]

With my configuration cursor start to be "invisible" after upgrade TC.
I have manually setup background color to black (Windows has white) and you setup "Use Windows theme for cursor" = on, by default.

[ghisler(Author)]

Then you need to disable themed cursor in Configuration - Options - Colors. TC uses standard list background color unless you change it yourself in "Colors" too.

[SailorMax]

Ok. Then can you check on upgrading - if background color is custom => setup "Use Windows theme for cursor" = off? Reduce invisible cursor cases after upgrade.

[Lefteous]

2ghisler(Author)

the cursor was the last thing where I didn't use it yet...

Thank you for using the system cursor here. I agree that providing the system selection could be considered. Unfortunately it doesn't feature a flexible coloring.

[Samuel]

I would appreciate if the windows cursor would also be used for the other selected files. (in windows the cursor for the current file is slightly darker than the other selected files) Also cursor gets grey if the window is deactivated.

https://abload.de/img/selectiongxset.png

[Lefteous]

What about improving the internal selection which is basically just another text color by custom-drawing a frame that is similar to the Windows selection frame?

Here are some examples - of course only one would be displayed at once (unless this is also used for colors by filetype)
http://lefteous.totalcmd.net/tc/ideas/explorer_style_selection_colored.png

What do you think?

[SailorMax]

Thoughts about the solution:

We don't have "Use Windows theme for files list". We use it as default colors for each element: Font color, Background, Background 2,..

But we have "Use Windows theme for cursor". Why it is not equal to "Default" color for "Cursor color"?

Current solution doesn't looks like it use Windows theme colors - only "Windows theme for cursor".

About inverted cursor:
"Use inverted cursor" + "Use Windows theme for cursor" = inverted all, except cursor.
I have light blue cursor (windows theme) + black background + white font color.
When I turn on "inverted cursor" I've got: blue cursor (windows theme) + white background + black font color.

[Samuel]

Code: Select all

13.06.16 Fixed: Draw themed text cursor with style LVGH_CLOSESELECTEDHOT instead of LVGH_OPENSELECTEDHOT, better visible (32/64)

Thank you.

I would appreciate if the windows cursor would also be used for the other selected files. (in windows the cursor for the current file is slightly darker than the other selected files) Also cursor gets grey if the window is deactivated.

https://abload.de/img/selectiongxset.png

Could you consider this one? Especially the greyed out cursor in the passive panel / deactivated window.

[Lefteous]

Code: Select all

13.06.16 Fixed: Draw themed text cursor with style LVGH_CLOSESELECTEDHOT instead of LVGH_OPENSELECTEDHOT, better visible (32/64)

Well when you are used to Explorer (e.g. open/save dialogs) this could be confusing. The color used in beta 2 looks like a selection not a cursor!

[ghisler(Author)]

Actually Explorer uses this too! It uses selected+cursor together.

[Lefteous]

2ghisler(Author)
Sorry you are right.


I was confused by the lighter cursor in beta 1 which is actually used as just as hover indicator in Explorer. I wonder why it's not used in TC when SingleClickStart is activated though.

[ghisler(Author)]

Because TC doesn't know when hovering ends. It just sets the focus immediately.