Different Icons in Drive Buttons and Drive Combobox

Post by *ghisler(Author) » 2016-08-02, 12:57 UTC

Thanks for the steps. It seems to happen only when you first connect the two drives and THEN start Total Commander. I always tried the opposite, so I never saw the problem. I could reproduce it now with your testing order.

Do you get this problem also when connecting the drives AFTER starting Total Commander?

Dalai · Post by *Dalai » 2016-08-02, 14:07 UTC

ghisler(Author) wrote:Do you get this problem also when connecting the drives AFTER starting Total Commander?

On my systems it doesn't matter whether I start TC before connecting the drive or after doing so. If CheckUsbHdd=1 (default) TC shows the drive as removable in the drive bar but as fixed in the drive list.

Regards
Dalai

Post by *petermad » 2016-08-02, 14:28 UTC

On my systems it doesn't matter whether I start TC before connecting the drive or after doing so. If CheckUsbHdd=1 (default) TC shows the drive as removable in the drive bar but as fixed in the drive list.

Same here.

milo1012 · Post by *milo1012 » 2016-08-02, 14:55 UTC

Dalai wrote:On my systems it doesn't matter whether I start TC before connecting the drive or after doing so.

Same for me.

p.eter · Post by *p.eter » 2016-08-03, 14:43 UTC

the same for me, no matter in which order

Post by *ghisler(Author) » 2016-08-03, 16:37 UTC

Strange, I cannot reproduce the problem when connecting them afterwards.

Anyway, please check whether my fix in beta 8 works for you or not.

Post by *petermad » 2016-08-03, 17:19 UTC

In TC9B8 it now works as expected with CheckUsbHdd=1 and OldDriveIcons>0 - my external USB harddisk is now show as removable in both drive buttonbar and drive combobox.

But with OldDriveIcons=0 the external USB harddisk is always shown as a fixed drive in both places despite the setting of CheckUsbHdd=1.

If it is not possible to make CheckUsbHdd=1 apply to system drive icons (OldDriveIcons=0) I suggest to change the Help from:

CheckUsbHdd=1 Check whether a harddisk is connected via USB (uses removable disk icon)[/b]

to:

CheckUsbHdd=1 Check whether a harddisk is connected via USB (uses removable disk icon) - Works only with OldDriveIcons > 0.

p.eter · Post by *p.eter » 2016-08-04, 11:14 UTC

For TC9 b8, I can confirm the statements of petermad

If OlddriveIcons=0, CheckUsbHdd has no influence on it, which Icon is displayed.

And furthermore, if you use your own DriveLib with CheckUsbHdd=0, there is no difference between the Icon for Systemdrive and fixed Drives (whether in Buttonbar or Combo-Box), because there's no separate icon provided in the Drives.dll. Is it possible to add a seperate Icon for fixed and Sytem Drives?

Post by *ghisler(Author) » 2016-08-05, 10:26 UTC

If OlddriveIcons=0, CheckUsbHdd has no influence on it, which Icon is displayed.

Indeed TC then asks Windows for the icon, and it returns normal harddisk icons for removable harddisks.

And furthermore, if you use your own DriveLib with CheckUsbHdd=0, there is no difference between the Icon for Systemdrive and fixed Drives (whether in Buttonbar or Combo-Box), because there's no separate icon provided in the Drives.dll. Is it possible to add a seperate Icon for fixed and Sytem Drives?

It could be done, but currently it's not planned because I don't have any such icons internally either.