WCICONEX not used when WCMICON2 is active

Mikefield · Post by *Mikefield » 2016-11-20, 01:03 UTC

Today I changed something in the Total Commander 9.0 RC 6 MainMmenu and was wondering,
that the icons not shown in em_UserMenu command entries. I found out, that, when I switch
back to the WCMICONS, then they are shown, so the WCICONEX is correct.
The problem is only if I use the new WCMICON2. It occurs in 32 and 64-bit TC. Is that known?

mf

Post by *petermad » 2016-11-20, 02:44 UTC

wciconex.inc is only used when wcmicons.dll is chosen,

But you can copy wciconex.inc to wcmicon2.inc - then it will work as from TC9rc4

Mikefield · Post by *Mikefield » 2016-11-20, 06:56 UTC

Thanks for reply petermad. So you mean it works as designed? For me it is a bug.
To copy wciconex.inc to wcmicon2.inc is not enough, also the icons must be copied.
This make no sense, the next update will overwrite the wcmicon2.dll.

mf

Post by *petermad » 2016-11-20, 09:25 UTC

For me it is a bug

Not really - wciconex i still supported the way it has always been - it silently replaces wcmicons if it is found.

To copy wciconex.inc to wcmicon2.inc is not enough, also the icons must be copied

I don't understand - if you want to use the icons in wcmicon2.dll, but to use them with the indexing that you have in wciconex.inc all you have to do is to copy wciconex.inc to wcmicon2.inc - NOT to copy any .dll's. By default wcmicons2.dll uses wcmicons.inc if no wcmicon2.inc is present.

Mikefield · Post by *Mikefield » 2016-11-20, 10:55 UTC

petermad wrote:I don't understand - if you want to use the icons in wcmicon2.dll, but to use them with the indexing that you have in wciconex.inc all you have to do is to copy wciconex.inc to wcmicon2.inc - NOT to copy any .dll's. By default wcmicons2.dll uses wcmicons.inc if no wcmicon2.inc is present.

I've add additional icons in wciconex.dll. When I add them to wcmicon2.dll,
then they are lost with the next update and I have to add them again.

That's the reason why it is a bug if wciconex.dll not be used.

mf

Post by *ghisler(Author) » 2016-11-20, 11:01 UTC

Yes, it is working as designed - wciconex is only used when wcmicons.dll is chosen. Otherwise the dll chosen in the icon choose dialog takes precedence over wciconex.

Mikefield · Post by *Mikefield » 2016-11-20, 11:11 UTC

So I can't use the new icon library in wcmicons2l when I want to use additional wciconex icon library?
Then it is a step backwards. Why can't it use as before? Also over the choose dialog?

mf

Post by *petermad » 2016-11-20, 11:12 UTC

I've add additional icons in wciconex.dll.

Then just choose (1) wcmicon.dll as your default iconlib - and wciconex.dll will be used as always.

Or rename your wciconex.dll and wciconex.inc to for example wcmicon3.dll/inc and provide the wcmicon3.dll file with a VersionInfo - then you can pick wcmicon3.dll as your default iconlib.

wcmicon2.dll is NOT a replacement for the wciconex.dll - it is an ALTERNATIVE addition (out of many).

Mikefield · Post by *Mikefield » 2016-11-20, 11:41 UTC

petermad wrote:wcmicon2.dll is NOT a replacement for the wciconex.dll - it is an ALTERNATIVE addition (out of many).

But the wcmicon2.dll "replaces" the wcmicons.dll with the function to use the wciconex.dll.
So I can rename the wcmicon2.dll/inc to wcmicons.dll/in (after backup of them),
then I've the new icons with the additional wciconex.dll. It's a litte bit strange but it should work.
Again, my expectation is to use both, the wcmicon2.dll and the wciconex.dll.
With wcmicon3.dll/inc I still have only one icon library.

I don't understand what you mean with

provide the wcmicon3.dll file with a VersionInfo

Is the "3" on the end the VersionInfo?

mf

Post by *petermad » 2016-11-20, 11:57 UTC

But the wcmicon2.dll "replaces" the wcmicons.dll with the function to use the wciconex.dll.

No, wciconex.dll is only used as replacement when wcmicons.dll is chosen.

Is the "3" on the end the VersionInfo?

No the versioninfo is inside the file - you have to use tools like GoRC to create it and ResHacker to put it in the file - I can do it for you if you send me the .dll file

Mikefield · Post by *Mikefield » 2016-11-20, 12:18 UTC

petermad wrote:No, wciconex.dll is only used as replacement when wcmicons.dll is chosen.

Oh-kai, I understand, thought that both are used. Thanks for clarifying.
Conclusion: It is not possible to use an additional icon library and i've to add the icons to the one dll I choose.

mf

Post by *petermad » 2016-11-20, 15:23 UTC

It is not possible to use an additional icon library and i've to add the icons to the one dll I choose.

Yep, and make an accompanying .inc file.

Mikefield · Post by *Mikefield » 2016-11-20, 20:54 UTC

petermad wrote:Yep, and make an accompanying .inc file.

Indeed.

mf