TC9.20B3: Change attr. dlg: wrong fallback to build in lang.

Bug reports will be moved here when the described bug has been fixed

Moderators: Hacker, Stefan2, white, sheep

Post Reply
User avatar
HolgerK
Power Member
Power Member
Posts: 4937
Joined: 2006-01-26, 22:15 UTC
Location: Europe, Aachen

TC9.20B3: Change attr. dlg: wrong fallback to build in lang.

Post by *HolgerK » 2018-05-16, 19:30 UTC

I'm using a reduced language file with some adaptions to certain strings:
WCMD_ENG.lng wrote:English
677="<_dir_>"
678="<=LNK=>"
1147="®emove current dir"
1653="h|min|s"
Normally the missing strings should be taken from the build in english resource.
But this does not happen for the "Change Attributes" dialog.

Instead of "From active panel (source)" and "From target" , the strings "LEFT" and "RIGHT" are shown in the dialog if "English (WCMD_ENG.lng)" is selected as language file.

TC9.20 b3 x64 and x86

Regards
Holger
Make our planet great again

User avatar
petermad
Power Member
Power Member
Posts: 8007
Joined: 2003-02-05, 20:24 UTC
Location: Valsted, Denmark
Contact:

Post by *petermad » 2018-05-16, 23:26 UTC

2HolgerK

Confirmed!

See: https://ghisler.ch/board/viewtopic.php?p=341142#341142

It is probably due to this:
After some more tests, I will now use source/target as suggested by MarcinW, if the translations exist. Otherwise, I will use LEFT/RIGHT.
But of course the internal English should be used in this case.
License #524
Danish Total Commander Translator
TC 9.21a 32+64bit on Win XP 32bit, Win 7, 8.1 & 10 64bit and TC 2.91b4 on Android 6.0
Get Extended Total Commander Menus | PHSM-Calendar

User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 36354
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Post by *ghisler(Author) » 2018-05-17, 09:57 UTC

Yes, that's why TC will use LEFT/RIGHT in this case, because TC cannot "know" whether an external translation is in English or some other language.
Author of Total Commander
http://www.ghisler.com

User avatar
petermad
Power Member
Power Member
Posts: 8007
Joined: 2003-02-05, 20:24 UTC
Location: Valsted, Denmark
Contact:

Post by *petermad » 2018-05-17, 14:05 UTC

TC cannot "know" whether an external translation is in English or some other language.
If the language file name has the pattern wcmd_*eng.lng the language should be English and the internal English dialog should be used wherever there is a missing string in the wcmd_*eng.lng file.

If the file name pattern is NOT wcmd_*eng.lng - and it indeed is English, then it is the author of the .lng file that is to blame for labeling it wrong.


So said in another way:

If a .lng file is being used and both strings 1394 / 1395 AND strings 1331 / 1332 are missing in the file, the Internal English strings for strings 1394 / 1395 should be used.

If only strings 1394 / 1395 are missing but strings 1331 / 1332 are present, then strings 1331 / 1332 from the file should be used.

Internal English strings strings 1331 / 1332 should never be used to substitute anything.
License #524
Danish Total Commander Translator
TC 9.21a 32+64bit on Win XP 32bit, Win 7, 8.1 & 10 64bit and TC 2.91b4 on Android 6.0
Get Extended Total Commander Menus | PHSM-Calendar

User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 36354
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Post by *ghisler(Author) » 2018-05-18, 10:31 UTC

Sorry, I prefer to keep it this way.
Author of Total Commander
http://www.ghisler.com

User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 36354
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Post by *ghisler(Author) » 2018-05-23, 15:35 UTC

This should be partially fixed in Total Commander 9.20 beta 4, please check!
Author of Total Commander
http://www.ghisler.com

User avatar
petermad
Power Member
Power Member
Posts: 8007
Joined: 2003-02-05, 20:24 UTC
Location: Valsted, Denmark
Contact:

Post by *petermad » 2018-05-24, 02:02 UTC

Confirmed that it is partly fixed in TC 9.20b4 :-)

It is now possible to use a partially wcmd_*eng.lng file where neither strings 1394 / 1395 nor strings 1331 / 1332 ar present - then internal English strings 1394 / 1395 are used as expected.

If a non-English language file (like wcmd_*dan.lng) is used and both strings 1394 / 1395 AND strings 1331 / 1332 are missing in the file, the Internal English strings for strings 1331 / 1332 are substituting strings 1394 / 1395 - In this case I think that the internal English strings 1394 / 1395 should be used - better with non-translated correct strings, than non-translated substituted strings.

The only case where substituting should take place is with non-English language files where strings 1394 / 1395 are missing but strings 1331 / 1332 are present in the language file.
License #524
Danish Total Commander Translator
TC 9.21a 32+64bit on Win XP 32bit, Win 7, 8.1 & 10 64bit and TC 2.91b4 on Android 6.0
Get Extended Total Commander Menus | PHSM-Calendar

User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 36354
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Post by *ghisler(Author) » 2018-05-24, 09:53 UTC

The idea is that people who prefer left/right can remove the strings for source/target.
Author of Total Commander
http://www.ghisler.com

User avatar
petermad
Power Member
Power Member
Posts: 8007
Joined: 2003-02-05, 20:24 UTC
Location: Valsted, Denmark
Contact:

Post by *petermad » 2018-05-24, 10:56 UTC

The idea is that people who prefer left/right can remove the strings for source/target.
Aha, then it is perfect, the way it is now :-)
License #524
Danish Total Commander Translator
TC 9.21a 32+64bit on Win XP 32bit, Win 7, 8.1 & 10 64bit and TC 2.91b4 on Android 6.0
Get Extended Total Commander Menus | PHSM-Calendar

User avatar
HolgerK
Power Member
Power Member
Posts: 4937
Joined: 2006-01-26, 22:15 UTC
Location: Europe, Aachen

Post by *HolgerK » 2018-05-27, 08:58 UTC

ghisler(Author) wrote:This should be partially fixed in Total Commander 9.20 beta 4, please check!
I can confirm the fix.

Thanks
Holger
Make our planet great again

Post Reply