This forum uses cookies. Click X button to hide this message. What is stored? / Privacy
Total Commander Forum Index Total Commander
Forum - Public Discussion and Support
 
 FAQFAQ   SearchSearch   MemberlistMemberlist   UsergroupsUsergroups   RegisterRegister 
 ProfileProfile   Log in to check your private messagesLog in to check your private messages   Log inLog in 

TC9.20B3: Change attr. dlg: wrong fallback to build in lang.

 
Post new topic   Reply to topic    Total Commander Forum Index -> TC Fixed bugs Printable version
View previous topic :: View next topic  
Author Message
HolgerK
Power Member
Power Member


Joined: 26 Jan 2006
Posts: 4822
Location: Europe, Aachen

PostPosted: Wed May 16, 2018 1:30 pm    Post subject: TC9.20B3: Change attr. dlg: wrong fallback to build in lang. Reply with quote

I'm using a reduced language file with some adaptions to certain strings:
WCMD_ENG.lng wrote:
English
677="<_dir_>"
678="<=LNK=>"
1147="®emove current dir"
1653="h|min|s"

Normally the missing strings should be taken from the build in english resource.
But this does not happen for the "Change Attributes" dialog.

Instead of "From active panel (source)" and "From target" , the strings "LEFT" and "RIGHT" are shown in the dialog if "English (WCMD_ENG.lng)" is selected as language file.

TC9.20 b3 x64 and x86

Regards
Holger
_________________
Make our planet great again
Back to top
View user's profile Send private message Send e-mail
petermad
Power Member
Power Member


Joined: 05 Feb 2003
Posts: 7851
Location: Valsted, Denmark

PostPosted: Wed May 16, 2018 5:26 pm    Post subject: Reply with quote

2HolgerK

Confirmed!

See: https://ghisler.ch/board/viewtopic.php?p=341142#341142

It is probably due to this:
Quote:
After some more tests, I will now use source/target as suggested by MarcinW, if the translations exist. Otherwise, I will use LEFT/RIGHT.


But of course the internal English should be used in this case.
_________________
#524
Danish Total Commander Translator
TC 9.20 32+64bit on Win XP 32bit, Win 7, 8.1 & 10 64bit. TC 2.91b3 on Android 6.0

Get Extended Total Commander Menus
Back to top
View user's profile Send private message Send e-mail Visit poster's website
ghisler(Author)
Site Admin
Site Admin


Joined: 04 Feb 2003
Posts: 35943
Location: Switzerland

PostPosted: Thu May 17, 2018 3:57 am    Post subject: Reply with quote

Yes, that's why TC will use LEFT/RIGHT in this case, because TC cannot "know" whether an external translation is in English or some other language.
_________________
Author of Total Commander
http://www.ghisler.com
Back to top
View user's profile Send private message Send e-mail Visit poster's website
petermad
Power Member
Power Member


Joined: 05 Feb 2003
Posts: 7851
Location: Valsted, Denmark

PostPosted: Thu May 17, 2018 8:05 am    Post subject: Reply with quote

Quote:
TC cannot "know" whether an external translation is in English or some other language.

If the language file name has the pattern wcmd_*eng.lng the language should be English and the internal English dialog should be used wherever there is a missing string in the wcmd_*eng.lng file.

If the file name pattern is NOT wcmd_*eng.lng - and it indeed is English, then it is the author of the .lng file that is to blame for labeling it wrong.


So said in another way:

If a .lng file is being used and both strings 1394 / 1395 AND strings 1331 / 1332 are missing in the file, the Internal English strings for strings 1394 / 1395 should be used.

If only strings 1394 / 1395 are missing but strings 1331 / 1332 are present, then strings 1331 / 1332 from the file should be used.

Internal English strings strings 1331 / 1332 should never be used to substitute anything.
_________________
#524
Danish Total Commander Translator
TC 9.20 32+64bit on Win XP 32bit, Win 7, 8.1 & 10 64bit. TC 2.91b3 on Android 6.0

Get Extended Total Commander Menus
Back to top
View user's profile Send private message Send e-mail Visit poster's website
ghisler(Author)
Site Admin
Site Admin


Joined: 04 Feb 2003
Posts: 35943
Location: Switzerland

PostPosted: Fri May 18, 2018 4:31 am    Post subject: Reply with quote

Sorry, I prefer to keep it this way.
_________________
Author of Total Commander
http://www.ghisler.com
Back to top
View user's profile Send private message Send e-mail Visit poster's website
ghisler(Author)
Site Admin
Site Admin


Joined: 04 Feb 2003
Posts: 35943
Location: Switzerland

PostPosted: Wed May 23, 2018 9:35 am    Post subject: Reply with quote

This should be partially fixed in Total Commander 9.20 beta 4, please check!
_________________
Author of Total Commander
http://www.ghisler.com
Back to top
View user's profile Send private message Send e-mail Visit poster's website
petermad
Power Member
Power Member


Joined: 05 Feb 2003
Posts: 7851
Location: Valsted, Denmark

PostPosted: Wed May 23, 2018 8:02 pm    Post subject: Reply with quote

Confirmed that it is partly fixed in TC 9.20b4 Smile

It is now possible to use a partially wcmd_*eng.lng file where neither strings 1394 / 1395 nor strings 1331 / 1332 ar present - then internal English strings 1394 / 1395 are used as expected.

If a non-English language file (like wcmd_*dan.lng) is used and both strings 1394 / 1395 AND strings 1331 / 1332 are missing in the file, the Internal English strings for strings 1331 / 1332 are substituting strings 1394 / 1395 - In this case I think that the internal English strings 1394 / 1395 should be used - better with non-translated correct strings, than non-translated substituted strings.

The only case where substituting should take place is with non-English language files where strings 1394 / 1395 are missing but strings 1331 / 1332 are present in the language file.
_________________
#524
Danish Total Commander Translator
TC 9.20 32+64bit on Win XP 32bit, Win 7, 8.1 & 10 64bit. TC 2.91b3 on Android 6.0

Get Extended Total Commander Menus
Back to top
View user's profile Send private message Send e-mail Visit poster's website
ghisler(Author)
Site Admin
Site Admin


Joined: 04 Feb 2003
Posts: 35943
Location: Switzerland

PostPosted: Thu May 24, 2018 3:53 am    Post subject: Reply with quote

The idea is that people who prefer left/right can remove the strings for source/target.
_________________
Author of Total Commander
http://www.ghisler.com
Back to top
View user's profile Send private message Send e-mail Visit poster's website
petermad
Power Member
Power Member


Joined: 05 Feb 2003
Posts: 7851
Location: Valsted, Denmark

PostPosted: Thu May 24, 2018 4:56 am    Post subject: Reply with quote

Quote:
The idea is that people who prefer left/right can remove the strings for source/target.

Aha, then it is perfect, the way it is now Smile
_________________
#524
Danish Total Commander Translator
TC 9.20 32+64bit on Win XP 32bit, Win 7, 8.1 & 10 64bit. TC 2.91b3 on Android 6.0

Get Extended Total Commander Menus
Back to top
View user's profile Send private message Send e-mail Visit poster's website
HolgerK
Power Member
Power Member


Joined: 26 Jan 2006
Posts: 4822
Location: Europe, Aachen

PostPosted: Sun May 27, 2018 2:58 am    Post subject: Reply with quote

ghisler(Author) wrote:
This should be partially fixed in Total Commander 9.20 beta 4, please check!

I can confirm the fix.

Thanks
Holger
_________________
Make our planet great again
Back to top
View user's profile Send private message Send e-mail
Display posts from previous:   
Post new topic   Reply to topic    Total Commander Forum Index -> TC Fixed bugs All times are GMT - 6 Hours
Page 1 of 1

 
Jump to:  
You cannot post new topics in this forum
You cannot reply to topics in this forum
You cannot edit your posts in this forum
You cannot delete your posts in this forum
You cannot vote in polls in this forum


Imprint/Impressum: This site is maintained by Ghisler Software GmbH
Privacy Policy | Datenschutzerklärung | Politique de Confidentialité

Using phpBB © phpBB Group