[9.20b4] CtrlArrowOpenArchive=4 tries to analyze archive

[MVV]

When CtrlArrowOpenArchive=4 is set (never open archives on Ctrl+Arrow, always focus), TC still tries to find a packer plugin for an archive on Ctrl+Arrow.
It is easy to notice with Total7zip plugin: create an empty file.7z and use Ctrl+Arrow on it, and you will see an error message. Some plugins cause hangs (e.g. lsop sometimes).

[Horst.Epp]

Confirmed

[ghisler(Author)]

This should be fixed in beta 5, please test it!

[MVV]

I still do a Ctrl+Arrow on empty file and get a error message "Error in packed file D:\Stuff\1.7z!"...

[ghisler(Author)]

NOT confirmed. Which 7zip plugin do you use?

[MVV]

I use Total7zip 0.8.5.6. I've tried with clean wincmd.ini (only associated 7z extension with plugin and added CtrlArrowOpenArchive=4 to INI) and the message still appears.

Detailed test with clean installation:
1. Extract TC installer to some dir.
2. Copy Total7zip.wcx to test TC dir (just this one file).
3. Create wincmd.ini:

Code: Select all

[Configuration]
UseIniInProgramDir=7
CtrlArrowOpenArchive=4
[PackerPlugins]
7z=%COMMANDER_PATH%\Total7zip.wcx

4. Start TOTALCMD.exe, close first-time windows.
5. Focus empty .7z file and press Ctrl+Arrow.
6. Total7zip error appears:

Total7zip
---------------------------
7-zip library is not found.
Download 7-Zip
http://www.7-zip.org/
---------------------------
ОК

7. Click OK, another error appears:

Total Commander
---------------------------
Error in packed file d:\Stuff\1.7z!
---------------------------
ОК

[Horst.Epp]

I still do a Ctrl+Arrow on empty file and get a error message "Error in packed file D:\Stuff\1.7z!"...

Confirmed
Still the same error using Total7zip 0.8.5.6
I only get

Total Commander
---------------------------
Error in packed file c:\temp\test\x.7z!
---------------------------
ОК

[ghisler(Author)]

I cannot reproduce it for Ctrl+Left arrow or Ctrl+Right arrow.

Maybe you used Ctrl+Up arrow or Ctrl+Shift+Up arrow? Then I can reproduce it.

[Horst.Epp]

I cannot reproduce it for Ctrl+Left arrow or Ctrl+Right arrow.

Maybe you used Ctrl+Up arrow or Ctrl+Shift+Up arrow? Then I can reproduce it.

No, I tested with Ctrl+Left and Ctrl+Right arrow and get the error.
If I use Ctrl-Up arrow an new tab with the name of the archive is opened.
If I enter this tab the error message is shown.

[ghisler(Author)]

Sorry, cannot reproduce with CtrlArrowOpenArchive=4. Are you sure you have that in your wincmd.ini?

Edit:
I found one special case where I still get the error: When the file has a size of 0 bytes. Is this the case in your test?

[Horst.Epp]

Sorry, cannot reproduce with CtrlArrowOpenArchive=4. Are you sure you have that in your wincmd.ini?

Edit:
I found one special case where I still get the error: When the file has a size of 0 bytes. Is this the case in your test?

Yes of course, MVV started this thread with such a file.

[ghisler(Author)]

MVV didn't write anything about a 0 bytes file. When I tested this error, I simply renamed a small text file from name.txt to name.7z.

[MVV]

Well, I call "0-byte" file as "empty file", so yes, this is the case.
Why this case is a special one?

[ghisler(Author)]

TC checked parameters by content for being archives if the size was >0 bytes, because 0 byte files couldn't contain anything to check by content. The 0 byte files were passed directly to the directory read function, where a separate check was made.

[MVV]

Fixed in 9.20b6, thank you!