How about a dark GUI for TC?

English support forum

Moderators: sheep, Hacker, Stefan2, white

Post Reply
Thany
Senior Member
Senior Member
Posts: 251
Joined: 2003-09-30, 09:20 UTC
Location: Netherlands

Re: How about a dark GUI for TC?

Post by *Thany » 2019-06-05, 19:38 UTC

I honestly can't remember how Delphi (still using it, right?) does this, as it's been at least 15 years for me. I'm sure it's moved on to, well, something.

But in C# and WinForms it's pretty easy to change the colours of a control. In webtech-based desktop applications, it's not only easy, it's amazing. And there's probably loads of other toolkits that can do custom colouring.

If your toolkit can't do this, maybe it's beginning to be time to be looking at something else after all these years. Not just for darkmode, but for any kind of drawing that makes the program a little bit easier on the eyes. Because let's be honest, TC is not exactly a super appealing 2019-era-looking program anymore.

And as further encouragement: the Android version is totally darkmode. Brilliant :P
Totally different thing, I know, but just saying because it's still also TC.

User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 38054
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Re: How about a dark GUI for TC?

Post by *ghisler(Author) » 2019-06-06, 10:11 UTC

TC uses standard Windows controls with theme support enabled via MANIFEST resource. To my knowledge, there is no function to change the color of themed elements of desktop programs.
Author of Total Commander
http://www.ghisler.com

User avatar
krstatzar
Junior Member
Junior Member
Posts: 84
Joined: 2005-03-03, 01:52 UTC
Contact:

Re: How about a dark GUI for TC?

Post by *krstatzar » 2019-06-06, 11:02 UTC

There are many examples of apps using dark UI when dark theme is enabled. Like Chrome for instance.
I think TC is very mature feature-wise and maybe should focus on UI overhaul in the next releases.

User avatar
jinsight
Junior Member
Junior Member
Posts: 62
Joined: 2003-02-25, 19:47 UTC
Location: Cleveland, Ohio, USA

Re: How about a dark GUI for TC?

Post by *jinsight » 2019-06-06, 16:18 UTC

Support focus on UI overhaul in future releases consistent with priority decisions.
License #1945
Windows 10 x64 Version 1803
April 2018 Update (OS Build 17134.590)
TC 9.21a x64 and x86, Everything 1.4.1.935 (x64)

User avatar
CAP-Team
Junior Member
Junior Member
Posts: 42
Joined: 2006-09-19, 12:43 UTC
Location: Netherlands
Contact:

Re: How about a dark GUI for TC?

Post by *CAP-Team » 2019-06-21, 21:00 UTC

This is how my Total Commander looks with dark panels.

Image: https://tweakers.net/ext/f/xFICMnl5fotFkfxZm8U2gwZ3/full.png

User avatar
Usher
Power Member
Power Member
Posts: 567
Joined: 2011-03-11, 10:11 UTC

Re: How about a dark GUI for TC?

Post by *Usher » 2019-06-22, 13:56 UTC

2CAP-Team
It's nothing new. This topic is about consistent colour change of other GUI elements.
Regards from Poland
Andrzej P. Wozniak

User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 38054
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Re: How about a dark GUI for TC?

Post by *ghisler(Author) » 2019-06-24, 13:50 UTC

Microsoft has not yet added dark mode support for desktop program themes, only for the Windows 8/10 apps.
Author of Total Commander
http://www.ghisler.com

User avatar
CAP-Team
Junior Member
Junior Member
Posts: 42
Joined: 2006-09-19, 12:43 UTC
Location: Netherlands
Contact:

Re: How about a dark GUI for TC?

Post by *CAP-Team » 2019-06-25, 20:18 UTC

We have explorer in dark theme.. as of version 1809

User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 38054
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Re: How about a dark GUI for TC?

Post by *ghisler(Author) » 2019-06-27, 08:54 UTC

Only the title bar and toolbar are dark - the file panel is still black on white, at least here...
Author of Total Commander
http://www.ghisler.com

User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 38054
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Re: How about a dark GUI for TC?

Post by *ghisler(Author) » 2019-08-05, 13:55 UTC

I'm currently working on dark mode. With Windows 10 1903, it's now possible to make the title bar and scrollbar dark, the only thinks I couldn't make dark in the main window and dialog boxes on older Windows versions.

The only remaining thing I can't make dark is the right click context menus (except when making them owner drawn). I can do this for my own context menus like the directory hotlists, but not for the Windows context menu, which can contain owner drawn items from 3rd party Explorer extensions.

The Explorer on Windows 10 1903 does support a dark context menu! Any idea how it does it? My internet searches didn't lead to any clues.
Author of Total Commander
http://www.ghisler.com

CoolWater
Power Member
Power Member
Posts: 674
Joined: 2003-03-27, 16:33 UTC

Re: How about a dark GUI for TC?

Post by *CoolWater » 2019-08-05, 16:11 UTC

There is a darkmode sample on github which has a few check conditions depending on which build is installed:
https://github.com/ysc3839/win32-darkmode/tree/master/win32-darkmode

DarkMode.h contains the mentioned checks. Maybe there is something you forgot to set?

HTH
CoolWater

User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 38054
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Re: How about a dark GUI for TC?

Post by *ghisler(Author) » 2019-08-08, 09:29 UTC

Thanks, I figured it out - I have to call AllowDarkModeForApp BEFORE creating a window. Otherwise that window gets a black title, but all the context menus are still light gray.
Author of Total Commander
http://www.ghisler.com

CoolWater
Power Member
Power Member
Posts: 674
Joined: 2003-03-27, 16:33 UTC

Re: How about a dark GUI for TC?

Post by *CoolWater » 2019-08-08, 11:35 UTC

That's nice to hear :-) Although it's interessting, since DarkMode.h says that AllowDarkModeForApp was removed before build no. 18334. The new function is SetPreferredAppMode.

Regards,
CoolWater

User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 38054
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Re: How about a dark GUI for TC?

Post by *ghisler(Author) » 2019-08-12, 13:39 UTC

They use the same numeric function value, just that the older takes a boolean (on/off) value, the latter takes a numeric value.

Unfortunately there is still a problem: If I change the mode between light and dark, everything can be changed except for the context menus - they only change color when I close and re-open TC. However, it works correctly when I change the mode in Windows itself and AllowDarkModeForApp is set to use the Windows setting. This means that there will be no toggle button for this option for the TC buttonbar. :(
Author of Total Commander
http://www.ghisler.com

Rockin
Junior Member
Junior Member
Posts: 10
Joined: 2007-02-21, 00:06 UTC

Re: How about a dark GUI for TC?

Post by *Rockin » 2019-08-14, 11:50 UTC

I'm very happy to hear about the progress you are making :) Re: restarting TC for the context menu - for me personally it doesn't matter, TC would always be in dark mode :) I don't even use the button bar (I know, sacrilege!). Wishing you all the best!

Post Reply