TC9.50b12a, Dark Mode: tree nodes issues

Bug reports will be moved here when the described bug has been fixed

Moderators: sheep, Hacker, Stefan2, white

User avatar
Usher
Power Member
Power Member
Posts: 891
Joined: 2011-03-11, 10:11 UTC

Re: TC9.50b12a, Dark Mode: tree nodes issues

Post by *Usher »

Scaling/resizing down picture is more or less lossy. It's better to crop screenshots and show fragments in natural size with discussed details only. For example, in many cases there's no need to show two panels. Use default settings for screen/font metrics (DPI, font style etc.) on screenshots if the problem isn't related to different settings.
Regards from Poland
Andrzej P. Wozniak
User avatar
petermad
Power Member
Power Member
Posts: 9895
Joined: 2003-02-05, 20:24 UTC
Location: Valsted, Denmark
Contact:

Re: TC9.50b12a, Dark Mode: tree nodes issues

Post by *petermad »

DrShark wrote:
2020-01-16, 23:02 UTC
* 32-bit TC uses large [+] icons (ForceDarkModeOptions=2 + [ColorsDark], TreeTriangles=1): http://live.staticflickr.com/65535/49396385647_6abd7a9707_o.png
petermad wrote:
2020-01-17, 03:14 UTC
I cannot get those BIG +'s - here is how it looks by me: https://madsenworld.dk/tcmd/32bitforcedark2.png
So why the differencce in size of the +'s between DrShark and myself. I am not using DPI scaling, maybe DrShark is?
License #524 (1994)
Danish Total Commander Translator
TC 9.51 32+64bit on Win XP 32bit & Win 7, 8.1 & 10 (2004) 64bit, 'Everything' 1.4.1.992 (x64)
TC 3.11 on Android 6.0
Get:
Extended TC Menus | TC Languagebar | TC Dark Help | PHSM-Calendar
User avatar
DrShark
Power Member
Power Member
Posts: 1628
Joined: 2006-11-03, 22:26 UTC
Location: Kyiv, 68/262

Re: TC9.50b12a, Dark Mode: tree nodes issues

Post by *DrShark »

petermad wrote:
2020-01-18, 11:53 UTC
So why the differencce in size of the +'s between DrShark and myself. I am not using DPI scaling, maybe DrShark is?
I just checked it: on this Windows 10 scaling is set to "150% (recommended)", screen resolution is 1920x1280. It's strange that here TC doesn't use larger [+] when TreeTriangles=0, and I think such small (not scaled) [+] icons look better.
Android 4.3.1 no root, kernel 08.09.2016; Win7 Home Premium SP1 rus 32 bit
TC #149847 Personal licence

Cuz we're all in this together, We're here to make it right
User avatar
petermad
Power Member
Power Member
Posts: 9895
Joined: 2003-02-05, 20:24 UTC
Location: Valsted, Denmark
Contact:

Re: TC9.50b12a, Dark Mode: tree nodes issues

Post by *petermad »

DrShark wrote:
2020-01-18, 12:58 UTC
...and I think such small (not scaled) [+] icons look better.
Me too.
License #524 (1994)
Danish Total Commander Translator
TC 9.51 32+64bit on Win XP 32bit & Win 7, 8.1 & 10 (2004) 64bit, 'Everything' 1.4.1.992 (x64)
TC 3.11 on Android 6.0
Get:
Extended TC Menus | TC Languagebar | TC Dark Help | PHSM-Calendar
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 40058
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Re: TC9.50b12a, Dark Mode: tree nodes issues

Post by *ghisler(Author) »

The dark mode triangles are a feature of the "Darkmode_Explorer" theme. When you set ForceDarkModeOptions=2, you turn that off - TC then uses emulated dark mode. I will change it so they will still be used even with ForceDarkModeOptions=2 if the Windows 10 version is new enough.
Author of Total Commander
http://www.ghisler.com
User avatar
DrShark
Power Member
Power Member
Posts: 1628
Joined: 2006-11-03, 22:26 UTC
Location: Kyiv, 68/262

Re: TC9.50b12a, Dark Mode: tree nodes issues

Post by *DrShark »

ghisler(Author) wrote:
2020-01-20, 15:48 UTC
The dark mode triangles are a feature of the "Darkmode_Explorer" theme. When you set ForceDarkModeOptions=2, you turn that off - TC then uses emulated dark mode. I will change it so they will still be used even with ForceDarkModeOptions=2 if the Windows 10 version is new enough.
But please also check how the triangles in dark mode look like on Windows 10 with my problem light theme which messes up "Darkmode_Explorer" theme. Because it seems in this case dark triangles are used instead of white, see screenshots comparison in petermad's post.
Android 4.3.1 no root, kernel 08.09.2016; Win7 Home Premium SP1 rus 32 bit
TC #149847 Personal licence

Cuz we're all in this together, We're here to make it right
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 40058
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Re: TC9.50b12a, Dark Mode: tree nodes issues

Post by *ghisler(Author) »

I found a better solution: Just draw the triangles myself when the "Darkmode_Explorer" theme isn't available, both on older Windows 10 versions and on your misconfigured one.
Author of Total Commander
http://www.ghisler.com
User avatar
DrShark
Power Member
Power Member
Posts: 1628
Joined: 2006-11-03, 22:26 UTC
Location: Kyiv, 68/262

Re: TC9.50b12a, Dark Mode: tree nodes issues

Post by *DrShark »

ghisler(Author) wrote:
2020-01-21, 10:47 UTC
I found a better solution: Just draw the triangles myself when the "Darkmode_Explorer" theme isn't available ... on ... Windows 10
Is it possible to do that on Windows 7 too?
Android 4.3.1 no root, kernel 08.09.2016; Win7 Home Premium SP1 rus 32 bit
TC #149847 Personal licence

Cuz we're all in this together, We're here to make it right
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 40058
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Re: TC9.50b12a, Dark Mode: tree nodes issues

Post by *ghisler(Author) »

Sure, please try with release candidate 1.
Author of Total Commander
http://www.ghisler.com
User avatar
DrShark
Power Member
Power Member
Posts: 1628
Joined: 2006-11-03, 22:26 UTC
Location: Kyiv, 68/262

Re: TC9.50b12a, Dark Mode: tree nodes issues

Post by *DrShark »

I had only very brief time to check on Windows 10 machine because before the TC 9.50 RC1 has been released this notebook got some hardware damage and now its HDD or something else inside makes a loud noise, so I'll come back with detailed tests after (if) repair service will check and fix it.

So for now I can confirm with ForceDarkModeOptions=2 TC now uses white triangles (it seems at least while [ColorsDark] TreeTriangles=-1).

On Windows 7 TC now also uses Win10-style white triangles ([>]) when [ColorsDark] TreeTriangles=-1 or TreeTriangles=1, and pluses ([+]) when TreeTriangles=0 as expected.
Android 4.3.1 no root, kernel 08.09.2016; Win7 Home Premium SP1 rus 32 bit
TC #149847 Personal licence

Cuz we're all in this together, We're here to make it right
User avatar
petermad
Power Member
Power Member
Posts: 9895
Joined: 2003-02-05, 20:24 UTC
Location: Valsted, Denmark
Contact:

Re: TC9.50b12a, Dark Mode: tree nodes issues

Post by *petermad »

I can confirm that all combinations of [Colors] TreeLineColor and TreeTriangles, or [ColorsDark] TreeLineColor and TreeTriangles work as expected and that ForceDarkModeOptions=1/2 now seem to work identically. :-)

TreeTriangles=-1 always defaults to triangles unless TreeLineColor=0 in both Normal and Dark mode.
TreeTriangles=0 always results in +'s in both Normal and Dark mode.
TreeTriangles=1 always results in >'s in both Normal and Dark mode.

Tested on Windows 7 and Windows 10 1909 in both 32bit and 64bit TC 9.5rc1.
License #524 (1994)
Danish Total Commander Translator
TC 9.51 32+64bit on Win XP 32bit & Win 7, 8.1 & 10 (2004) 64bit, 'Everything' 1.4.1.992 (x64)
TC 3.11 on Android 6.0
Get:
Extended TC Menus | TC Languagebar | TC Dark Help | PHSM-Calendar
Post Reply