TC10.50b1: Copy hangs when using non-matching filter

[EricB]

I think I found a bug:

When I select some random files, press F5 Copy (or use drag/drop) to copy it to the other panel AND select in "Only files of this type" a filter that does not match the selection (e.g. *.iso, when only pdf files are selected), and click OK/F2 Queue, I get TC hanging.

Notes:
- TC10.50b1 x32, Windows 10 Pro 1909 x64
- Tested this also with fresh ini
- ONLY happens when queuing is used (doesn't matter if you use F2 Queue or have AlwaysCopyInBackGround=2 in ini)
- ONLY happens when also Dark Interface is set. With Light interface a dialog box "No files selected!" is shown and no hang.
- Could also reproduce this with TC10.50b1 x64

Regards, EricB

[white]

Confirmed also for TC 10.00 x64 and 9.51 x64. Bug is probably since the introduction of dark mode.

[ghisler(Author)]

Not confirmed. Maybe you are getting confused because the background transfer manager shows a warning "No files selected!" which appears behind the main program, as a child of the background transfer manager. When you click on the background transfer manager, the dialog comes to the foreground.

[white]

Maybe you are getting confused because the background transfer manager shows a warning "No files selected!" which appears behind the main program, as a child of the background transfer manager. When you click on the background transfer manager, the dialog comes to the foreground.

No, we are not confused. Remember to use 64bit and dark mode.

BTW, I use Windows 11.

[ghisler(Author)]

You are right, it's the dark mode, I can't use the standard MessageBox in dark mode. I will check it.

[white]

Tested TC10.50b2 with Windows 11 in dark mode.

32bit with fresh ini (dark mode disabled) - Like before: message box behind window and beep sound.
32bit with fresh ini and then dark mode on Always Enabled - Hangs.
32bit with fresh ini and then dark mode on Only when enabled for Windows 10 apps - Message box in front of main window and no beep sound.

64bit with fresh ini (dark mode disabled) - Message box in front of main window, beep sound and hangs.
64bit with fresh ini and then dark mode on Always Enabled - Message box in front of main window and no beep sound.
64bit with fresh ini and then dark mode on Only when enabled for Windows 10 apps - Hangs.

[Usher]

2white
Have you tested "F8/Delete" behavior? It seems to have similarly misconfigured message box in dark mode: no beep, icon "?" instead of "i" in normal mode.

[ghisler(Author)]

I could not reproduce any more hangs myself so far, will have to try with a fresh ini.

[white]

Here is for example how I do it:

1. Make sure there is a normal file in the root for testing (not hidden or system).
2. Delete the ini file
3. Launch the beta 64 bit
4. Confirm Configuration and Icon library
5. Don't navigate to a folder! But select the file from step 1
6. Press F5
7. Hit the Tab key and enter some nonsense like "fssdfawerf3"
8. Press F2

[white]

For the dark modes I do an extra step:

1. Make sure there is a normal file in the root for testing (not hidden or system).
2. Delete the ini file
3. Launch the beta 64 bit
4. Confirm Configuration and Icon library
5. Extra step: Open Configuration again and change to the desired dark mode and click OK
6. Don't navigate to a folder! But select the file from step 1
7. Press F5
8. Hit the Tab key and enter some nonsense like "fssdfawerf3"
9. Press F2

[EricB]

I think the fix for TC10.50b2 has led to a regression in the Light Themed TC, as already partially described by White:

Note that I have Windows 10 Pro 1909 64 bit with Dark Mode on.

When starting TC 10.50b2 with a fresh ini, it defaults to Light Theme.

Running the original scenario from my first post:
When I select some random files, press F5 Copy (or use drag/drop) to copy it to the other panel AND select in "Only files of this type" a filter that does not match the selection (e.g. *.iso, when only pdf files are selected), and click F2 Queue, I get TC hanging.

The Messagebox "No files selected!" is shown, but is unresponsive. I have to kill TC. This is reproducible for both TC 10.50b2 x32 and x64.

Possibly the standard Messagebox (light colour) that is fired up by light-themed TC does not play nice with my dark-themed Windows.

[ghisler(Author)]

I think I will just remove the message altogether. There is no message when copying in the foreground either.

[EricB]

I think I will just remove the message altogether. There is no message when copying in the foreground either.

That seems like a good option. Since the size of the selection is now shown in the copy dialog, applying a filter with no match will update that size neatly to 0 bytes anyway.

[EricB]

Retested in TC10.50b3:

- No hangs when defining a non-matching filter and queueing the copy
- Message is not shown anymore
- Tested with TC x32 and x64 without and with fresh ini, all in both dark and light mode

Problem seems to be fixed.

[white]

Problem seems to be fixed.

Confirmed.

Moderator message from: white » 2022-04-27, 20:57 UTC

Moved to Fixed bugs