[TC 10.50b5] Options - Edit/View

[KozakMak]

Options - Edit/View:

https://i117.fastpic.org/big/2022/0511/ae/6cbf6ca681f6b06026e94c01b33585ae.png

[white]

The problems reported by KozakMak are:

• Access keys in Shift+F3 and Alt+F3 (and F3?) are not filtered.
• In normal mode, the browse button for the editor is placed too high and is overlapping.

[petermad]

06.05.22 Added: Improved viewer configuration in Configuration - Options - Edit/View (32/64)

If the locale has Shortcut keys for strings 5282-5284, 5182-5183 like:
5282="&Ctrl +"
5283="A&lt +"
5284="Ski&ft +"
5182="Intern fremviser med &valgte filer"
5183="&Ekstern fremviser:"

Then these shortcuts are still unnecessarily shown - see:
https://madsenworld.dk/tcmd/editview1.png
https://madsenworld.dk/tcmd/editview2.png

5182 and 5183 can just have their shortcuts removed by the translators, but 5282-5284 are also used in the Configuration/Misc dialog and should not be changed.

[ghisler(Author)]

The hotkeys of 5281 and 5183 will still focus the combobox, so they can stay - but it's better when the translators remove them.

You are right about the prefixes, I will remove the hotkeys in code there. They don't use hotkeys in English and German, so I didn't even consider it...

[AntonyD]

Then these shortcuts are still unnecessarily shown - see:
https://madsenworld.dk/tcmd/editview1.png
https://madsenworld.dk/tcmd/editview2.png

typos at URL links: dk but not dj

[ghisler(Author)]

Moderator message

Links fixed

[AntonyD]

Concerning this bug I have also what to add.
Start TC - choose built-in English. Open this dlg. Open tab Operation - Edit/View.
[img]https://i.ibb.co/NNdQ3xY/1.png[/img]
so far -so good.
Now - Set Russian LNG (of course I have previously entered into it all the lines
that have not yet been officially translated, but exist for the Deutsch language)
PRESS APPLY only button! and back to the tab Operation - Edit/View. And:
[img]https://i.ibb.co/1Z9mKrq/2.png[/img]
Now close the Dlg with OK button and reopen it immediately. And you will see:
[img]https://i.ibb.co/fQNkQFB/3.png[/img]
and all is fine.

That is, it turns out that simply clicking the Apply button is not enough for all language
resources to be correctly reloaded into their components. Only a complete restart of
the dialog allows you to set all the elements in their places.

[ghisler(Author)]

Thanks for your report, indeed I only fixed that in the 32-bit version, not yet in the 64-bit version. I will fix it there too.

[white]

The combo box to choose the hotkey is not aligned properly. It needs to move up a few pixels.

[KozakMak]

(in dark mode): https://fastpic.org/view/117/2022/0512/03f24fc6d5d3c8fe9a4a4c506c02593d.png.html

[ghisler(Author)]

I tried finding out the base line of the text within a combobox so I could align it with other text, but there doesn't seem to be a function in Windows to get that information. A similar problem exists with the left margin, so I could align it with the text below.
So unfortunately this is not solvable.

[white]

I tried finding out the base line of the text within a combobox so I could align it with other text, but there doesn't seem to be a function in Windows to get that information.

Perhaps you can calculate the center of the text (approximately) and then calculate the position of the top of the combo box from that center.

[white]

2ghisler(Author)

The new dialog for "Configuration - Edit/View" is the implementation of the suggestions in the thread Suggestions for Configuration - Edit/View dialog.
You didn't implement all suggestions. I can guess why, but I think it's good to discuss why you didn't.

• You didn't change the group labels "Viewer for F3" and "Editor for F4" to simply "Viewer" and "Editor".
  Why? "Viewer for F3" isn't a correct description and the additional "for F?" doesn't seem necessary.
  
• Why do you suddenly use "SHIFT + F3" and "ALT + F3" instead of "Shift+F3" and "Alt+F3"?
  
• You didn't use a separate label for the External viewer settings.
  In the old dialog you used the label "External Viewer" for a radio button to set the hotkey F3 and as a header for other External Viewer options while being unrelated to the hotkey setting. That wasn't very clear.
  In the new dialog you are using the label "External Viewer" to show the hotkey assignment and at the same time you want the users to understand it is a header for the options below. This isn't clear either.
  Why didn't you use a separate label as suggested?
  
• Related to the previous point, you also kept the "Default" label. Which, if you use my design, seems redundant.

[ghisler(Author)]

You didn't change the group labels "Viewer for F3" and "Editor for F4" to simply "Viewer" and "Editor".
Why? "Viewer for F3" isn't a correct description and the additional "for F?" doesn't seem necessary.

I think that they are still correct, the viewer is invoked with F3 and key combinations with F3, and the editor with F4 and Shift+F4.

Why do you suddenly use "SHIFT + F3" and "ALT + F3" instead of "Shift+F3" and "Alt+F3"?

I'm using translated strings now, they are from Configuration - Options - Misc. The previous ones were hard coded.

Why didn't you use a separate label as suggested?

I'm using "Default" as the label, because I thought that it's clear that it refers to string above, "External viewer". Repeating "External viewer" seemed strange.

[white]

You didn't change the group labels "Viewer for F3" and "Editor for F4" to simply "Viewer" and "Editor".
Why? "Viewer for F3" isn't a correct description and the additional "for F?" doesn't seem necessary.

I think that they are still correct, the viewer is invoked with F3 and key combinations with F3, and the editor with F4 and Shift+F4.

I think that's debatable. But regardless whether it is technically correct, why do you prefer it? Do you think it looks nicer?

Why do you suddenly use "SHIFT + F3" and "ALT + F3" instead of "Shift+F3" and "Alt+F3"?

I'm using translated strings now, they are from Configuration - Options - Misc. The previous ones were hard coded.

I see. But I looked at Configuration - Options - Misc, and it's not in all caps there either.

I'm using "Default" as the label, because I thought that it's clear that it refers to string above, "External viewer". Repeating "External viewer" seemed strange.

In that case you could also reverse the order. First the "External Viewer:" section and then the "Hotkeys:" section.
The resulting order seems like an intuitive order:
* Configure internal viewer
* External Viewer settings
* Hotkeys settings