Display problem with new OneDrive overlay icons (TC 10.51)

[SSc]

TC 10.51 RC2 (win 11, 21H2, 22000.795)

It's about the new feature in 10.51: "Added: OneDrive folder: Show green circle overlay icon with checkmark for files which are marked for always being available offline".

With 10.51, the original overlay icons of OneDrive are no longer shown (or drawn-over?), while TC 10.50 worked fine. Also, the new TC-drawn overlays have a white border, which I think is distracting when displayed with a dark background.

Hopefully the screenshot clarifies what I mean:
Image: https://s20.directupload.net/images/220818/d92x8fhb.png

Hence question/suggestion:
- it would be great if you could turn off the new feature (in the sense: prefer original overlay icons)
- if not possible: can the white border be removed please?

Thanks a lot for checking,
Stefan

[ghisler(Author)]

Unfortunately I cannot reproduce this. There are no green overlay icons here in TC 10.50 on Windows 11 in the OneDrive folder.
They look like regular Windows overlays. You can try turning off TC oneDrive overlays and only show Windows overlays:
1. Open wincmd.ini via menu Configuration - Change settings files directly
2. Look for section [Configuration]
3. Below it, add this line:
IconOverlaysOneDrive=0
4. Make sure regular overlays are enabled in menu Configuration - Options - Icons

can the white border be removed please?

I can't just steal the Windows icons, this would be a copyright violation. I tried without white borders and it looked even worse.

[SSc]

Thanks for the quick reply!

IconOverlaysOneDrive=0

Perfect , that was exactly what I needed. With this setting my original OneDrive overlays are shown again.

Great, thx! Then this issue can be marked as resolved

[ghisler(Author)]

Any idea how to get these OneDrive overlay icons? By default, the Explorer shows them in a separate column which isn't available to third party programs like Total Commander, so I show them as overlays.

[SSc]

By default, the Explorer shows them in a separate column which isn't available to third party programs like Total Commander, so I show them as overlays

I think that's a good idea! I myself use the other OneDrive mode:

We had already discussed this in another thread. See the info starting from the following comment regarding OneDrive setting and possible reason why the icons are not displayed (potentially too many other programs, e.g. TortoiseSVN, "fighting" over the overlay icons and overwriting each other's registry entries described in the other thread):
https://www.ghisler.ch/board/viewtopic.php?p=396938#p396938

Said the other way around:
on a clean system with only OneDrive installed as a test (i.e. no other overlay handlers by GoogleDrive, Dropbox, TortoiseSVN, etc.) the OneDrive icons should be displayed when switching OneDrive mode as described:
Image: https://ibb.co/2MtnZmH

[ghisler(Author)]

Thanks for the information! I will turn off my own OneDrive icons when detecting this mode.

[ghisler(Author)]

Please test with RC3!

[white]

I don't have OneDrive installed. I have a mingw64 folder downloaded by the MinGW package installer.

RC2 shows green TC checkmark overlay icon for folders and binaries.
IconOverlays setting has no influence.
IconOverlaysOneDrive=0 disables it.

RC3 doesn't show these overlay icons.

[ghisler(Author)]

2white
Indeed RC3 only shows these icons when in the special OneDrive folder. you can check whether the virtual folder location is set in your system via command line:
cd %$OneDrive%

If the command brings you to any directory, the variable has been set. If the directory stays the same, it has not been set.

[white]

The variable did exist, but I had removed the folder after I removed OneDrive. To show the contents of the variable people can execute the following command line in Total Commander:

Code: Select all

cmd /c echo %$OneDrive% & pause

Can you add the variable to "Help - Environment variables"?

I have created the OneDrive folder and tested it. I can confirm the checkmark icon is shown in that folder with the following settings:
IconOverlaysOneDrive=2
IconOverlaysOneDrive=3

And not shown with settings:
IconOverlaysOneDrive=0
IconOverlaysOneDrive=1

So as far as I could test it, I confirm the correct behavior.

[ghisler(Author)]

Can you add the variable to "Help - Environment variables"?

Sorry, I was wrong, %$OneDrive% isn't a valid internal variable. TC looks up the environment variable %OneDrive% instead, which leads to the right location. The internal variable would be %$SkyDrive%, the old name used by Microsoft before they had to change the name due to being sued by the TV station "Sky".

[white]

I see. On my computer %$SkyDrive% simply returns %$SkyDrive%. (as normal I assume)

Perhaps add %$OneDrive% as well that does the same as %$SkyDrive%?

[ghisler(Author)]

On my computer %$SkyDrive% simply returns %$SkyDrive%. (as normal I assume)

FOLDERID_SkyDrive calls SHGetKnownFolderPath with the following GUID:
{A52BBA46-E9E1-435f-B3D9-28DAA648C0F6}
Maybe it only returns a valid path when OneDrive is installed and running?

%$OneDrive% isn't resolved, then TC tries %OneDrive% and it is resolved via environment variables.

[white]

On my computer %$SkyDrive% simply returns %$SkyDrive%. (as normal I assume)

FOLDERID_SkyDrive calls SHGetKnownFolderPath with the following GUID:
{A52BBA46-E9E1-435f-B3D9-28DAA648C0F6}
Maybe it only returns a valid path when OneDrive is installed and running?

Tried it on virtual machine. It worked after installing the app.

%$OneDrive% isn't resolved, then TC tries %OneDrive% and it is resolved via environment variables.

I understand, my suggestion was to add %$OneDrive% (because that is the new name) that also does:
FOLDERID_SkyDrive calls SHGetKnownFolderPath with the following GUID:
{A52BBA46-E9E1-435f-B3D9-28DAA648C0F6}

But on second thought that isn't smart It wouldn't be compatible with older versions and TC simply sends the command to the named function.

[ghisler(Author)]

OK, I will leave it as it is for now.

Moderator message

Moved to "will not be changed"