Wrong Icon for "Synchronize dirs" Window sine TC Version ?

[Sir_SiLvA]

So as I have been updating the my ICLs after more then 10 years and updating the file icon list in the TC Wiki
(see https://ghisler.ch/board/viewtopic.php?t=74255 )
I stumbled upon Icon 32 which is supposed to be the Window/Frame Icon for "Synchronize dirs".

After collecting some new icons I begun to recrate my ICL I have been using since forever and I noticed
that when using my ICL with [Configuration] IconLib=<path/filename> that Icon 0 is used as the Frame Icon
(I even colored 25 differently to make sure of it)

ICL to try it out: https://zippysha.re/haC4D3v2ze/My_Icons_icl
(This icl is a work in progress and most of the icons are not made by me, they are mostly windows 10/11 icons,
31 is from FreeCommander and the padlocks are from https://www.iconarchive.com/show/3d-icons-by-3dlb/lock-icon.html
and https://www.graphicsfuel.com/lock-icon-psd-png/ )

[petermad]

2Sir_SiLvA
What do you mean by the Window/Frame Icon for "Synchronize dirs". Is it the Title bar icon for the "Synchronize directories" dialog? See: https://tcmd.madsenworld.dk/syncicon.png

Here by me it is always shown as icon 32 in totalcmd64.exe - also if I make an .icl file where I replace icon 32

[Sir_SiLvA]

2Sir_SiLvA
What do you mean by the Window/Frame Icon for "Synchronize dirs".
Is it the Title bar icon for the "Synchronize directories" dialog?

Yes, sorry my bad I expected that to be obvious.

Here by me it is always shown as icon 32 in totalcmd64.exe - also if I make an .icl file where I replace icon 32

Yes. My OP was about TC32 and yes TC64 is even worse as it is totaly ignoring the icl icon...
I dunno why that is the only icon with that strange behavior.

TC32 if the user choose an icl use icon 0 instead of 32 from that icl.
TC64 if the user choose an icl - dont give a - and use the icon from TC64.exe

[petermad]

I never thought that the 32bit TC would be different in this respect, so I din't test it, but yes, 32bit TC uses icon 0 for the "Synchronize directories" dialog.

[ghisler(Author)]

It's really strange, TC calls LoadIcon(hinstance,MakeIntResource(33)); to load the icon of the synchronize dialog. It makes no sense that it returns something different when an external icon library is set. I could not find any reason why it is happening. I use the same code in Lister and Compare by content, and there it works just fine.

[AntonyD]

I can't confirm that "32bit TC uses icon 0 for the "Synchronize directories" dialog"
https://ibb.co/tQFhJbj
P.S. Or is it necessary to check the bug on some completely non-standard icon library?

[Sir_SiLvA]

It's really strange, TC calls LoadIcon(hinstance,MakeIntResource(33)); to load the icon of the synchronize dialog. It makes no sense that it returns something different when an external icon library is set. I could not find any reason why it is happening. I use the same code in Lister and Compare by content, and there it works just fine.

But at least you can confirm both bugs? Because if you do i can start looking since when it happens

P.S. Or is it necessary to check the bug on some completely non-standard icon library?

Obviosuly, as I have plainly written, you have to use IconLib= and an ICL which contains at least 33 icons....
PS: what the is a "non-standard" icon library???

[AntonyD]

a "non-standard" icon library???

is a lib pointed by the using option IconLib= and an ICL file.

In this case yes - I can confirm this case: https://ibb.co/5n9znJM
But I should also say that in this case of using a third-party file, there is no way to set different icons for 32-bit and 64-bit Total at all.
In both cases it is the same icon. It just doesn't seem right.

[Sir_SiLvA]

a "non-standard" icon library???

is a lib pointed by the using option IconLib= and an ICL file.

so a standard icl file is for you a non-standard icon-library, okay...

In this case yes - I can confirm this case: https://ibb.co/5n9znJM
But I should also say that in this case of using a third-party file, there is no way to set different icons for 32-bit and 64-bit Total at all.
In both cases it is the same icon.

Yes when both tcs use the same icl they do look the same (thats something I pointed out over a decade ago) but this thread is about fixing a bug,
you are welcome to make a suggestion on how you would fix that

[AntonyD]

so a standard icl file is for you a non-standard icon-library, okay...

no, that' not correct. simply because there is NO ANY preinstalled *.icl file with standard installer tcmd1100x32_64.exe.
that what I meant by word "non-standard" what type, what structure the file itself is - this by this word was not evaluated.

you are welcome to make a suggestion on how you would fix that

And we need some good debug build to start with. So that in the log you can evaluate the whole process of loading and applying icons by index. Otherwise, right now, we can guess like on a spirit chat board.

[Sir_SiLvA]

Otherwise, right now, we can guess like on a spirit chat board.

thats not true see https://www.ghisler.ch/wiki/index.php?title=Filelist_icons -> Customize filelist icons

[AntonyD]

thats not true

about what?
IMHO we talked about different moments.
I meant that guessing - is the only feasible process for the current question - WHY we have such strange difference.
32bit TC uses icon 0 for the "Synchronize directories" dialog and 64bit TC uses _proper_ icon 33....

[petermad]

and 64bit TC uses _proper_ icon 33....

Not even that - 64bit ALWAYS uses its own icon no. 32 from inside totalcmd64.exe, even when an external IconLib is stated in wincmd.ini

[ghisler(Author)]

Lister, Compare by content and Synchronize dirs always use the internal icon. They all use the exact same function to load it, so I have no idea what's going wrong in 32-bit for Synchronize dirs only.

[AntonyD]

so I have no idea what's going wrong in 32-bit for Synchronize dirs only.

But - anyway - did you able to reproduce the problem?